Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 39781002: sale_supply_drop_shipment: Handle remaining qty when synchronizing supplier and customer moves

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by nicoe
Modified:
1 week, 4 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use same synchronization algorithm as in ShipmentOut #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -15 lines) Patch
M stock.py View 1 1 chunk +68 lines, -15 lines 1 comment Download

Messages

Total messages: 8
nicoe
1 week, 6 days ago (2017-10-09 15:57:03 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/39781002
1 week, 6 days ago (2017-10-09 16:07:37 UTC) #2
ced
https://codereview.tryton.org/39781002/diff/1/stock.py File stock.py (right): https://codereview.tryton.org/39781002/diff/1/stock.py#newcode477 stock.py:477: Move.copy([f_move], default={ You must not make a copy otherwise ...
1 week, 6 days ago (2017-10-09 20:17:01 UTC) #3
nicoe
https://codereview.tryton.org/39781002/diff/1/stock.py File stock.py (right): https://codereview.tryton.org/39781002/diff/1/stock.py#newcode477 stock.py:477: Move.copy([f_move], default={ On 2017/10/09 20:17:01, ced wrote: > You ...
1 week, 5 days ago (2017-10-10 09:45:13 UTC) #4
ced
https://codereview.tryton.org/39781002/diff/1/stock.py File stock.py (right): https://codereview.tryton.org/39781002/diff/1/stock.py#newcode477 stock.py:477: Move.copy([f_move], default={ On 2017/10/10 09:45:12, nicoe wrote: > On ...
1 week, 5 days ago (2017-10-10 10:56:49 UTC) #5
nicoe
Use same synchronization algorithm as in ShipmentOut
1 week, 5 days ago (2017-10-10 22:14:01 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/39781002
1 week, 5 days ago (2017-10-10 22:49:30 UTC) #7
ced
1 week, 4 days ago (2017-10-11 13:48:45 UTC) #8
I think it deserves a scenario.

https://codereview.tryton.org/39781002/diff/20001/stock.py
File stock.py (right):

https://codereview.tryton.org/39781002/diff/20001/stock.py#newcode504
stock.py:504: 0, c_move.uom.round(c_move.quantity - exc_qty))
I do not understand why a max is needed?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842