Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(389)

Issue 39781002: sale_supply_drop_shipment: Handle remaining qty when synchronizing supplier and customer moves (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 1 week ago by nicoe
Modified:
2 months, 1 week ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use same synchronization algorithm as in ShipmentOut #

Total comments: 2

Patch Set 3 : add scenario #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -15 lines) Patch
M stock.py View 1 1 chunk +68 lines, -15 lines 0 comments Download
A tests/scenario_sale_supply_drop_shipment_remaining_qty.rst View 1 2 1 chunk +129 lines, -0 lines 0 comments Download
M tests/test_sale_supply_drop_shipment.py View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13
nicoe
7 months, 1 week ago (2017-10-09 15:57:03 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/39781002
7 months, 1 week ago (2017-10-09 16:07:37 UTC) #2
ced
https://codereview.tryton.org/39781002/diff/1/stock.py File stock.py (right): https://codereview.tryton.org/39781002/diff/1/stock.py#newcode477 stock.py:477: Move.copy([f_move], default={ You must not make a copy otherwise ...
7 months, 1 week ago (2017-10-09 20:17:01 UTC) #3
nicoe
https://codereview.tryton.org/39781002/diff/1/stock.py File stock.py (right): https://codereview.tryton.org/39781002/diff/1/stock.py#newcode477 stock.py:477: Move.copy([f_move], default={ On 2017/10/09 20:17:01, ced wrote: > You ...
7 months, 1 week ago (2017-10-10 09:45:13 UTC) #4
ced
https://codereview.tryton.org/39781002/diff/1/stock.py File stock.py (right): https://codereview.tryton.org/39781002/diff/1/stock.py#newcode477 stock.py:477: Move.copy([f_move], default={ On 2017/10/10 09:45:12, nicoe wrote: > On ...
7 months, 1 week ago (2017-10-10 10:56:49 UTC) #5
nicoe
Use same synchronization algorithm as in ShipmentOut
7 months, 1 week ago (2017-10-10 22:14:01 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/39781002
7 months, 1 week ago (2017-10-10 22:49:30 UTC) #7
ced
I think it deserves a scenario. https://codereview.tryton.org/39781002/diff/20001/stock.py File stock.py (right): https://codereview.tryton.org/39781002/diff/20001/stock.py#newcode504 stock.py:504: 0, c_move.uom.round(c_move.quantity - ...
7 months, 1 week ago (2017-10-11 13:48:45 UTC) #8
nicoe
add scenario
5 months, 1 week ago (2017-12-10 12:00:39 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/39781002
5 months, 1 week ago (2017-12-10 12:13:58 UTC) #10
nicoe
https://codereview.tryton.org/39781002/diff/20001/stock.py File stock.py (right): https://codereview.tryton.org/39781002/diff/20001/stock.py#newcode504 stock.py:504: 0, c_move.uom.round(c_move.quantity - exc_qty)) On 2017/10/11 13:48:45, ced wrote: ...
5 months, 1 week ago (2017-12-10 13:51:50 UTC) #11
ced
LGTM
5 months, 1 week ago (2017-12-10 16:08:27 UTC) #12
rietveld-bot_tryton.org
2 months, 1 week ago (2018-03-13 13:14:41 UTC) #13
New changeset 471ad47d4129 by Nicolas √Čvrard in branch 'default':
Handle remaining qty when synchronizing supplier and customer moves
http://hg.tryton.org/modules/sale_supply_drop_shipment/rev/471ad47d4129
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922