Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 39851002: sao: Use spellcheck and lang attributes for textbox widget (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 3 weeks ago by xcodinas
Modified:
5 months, 1 week ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add RichText #

Patch Set 3 : Set attribute in richtext only if record #

Total comments: 1

Patch Set 4 : Do not change input value line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/view/form.js View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13
xcodinas
8 months, 3 weeks ago (2017-10-30 12:33:09 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/39851002
8 months, 3 weeks ago (2017-10-30 12:49:05 UTC) #2
ced
Missing for RichText https://codereview.tryton.org/39851002/diff/1/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/39851002/diff/1/src/view/form.js#newcode1653 src/view/form.js:1653: Sao.i18n.getlang()); I do not think it ...
8 months, 1 week ago (2017-11-16 10:13:14 UTC) #3
xcodinas
Add RichText
8 months, 1 week ago (2017-11-16 15:37:54 UTC) #4
xcodinas
Set attribute in richtext only if record
8 months, 1 week ago (2017-11-16 15:38:59 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/39851002
8 months, 1 week ago (2017-11-16 16:07:22 UTC) #6
ced
https://codereview.tryton.org/39851002/diff/40001/src/view/form.js File src/view/form.js (left): https://codereview.tryton.org/39851002/diff/40001/src/view/form.js#oldcode1826 src/view/form.js:1826: this.input.html(value); Why is it changed?
7 months, 4 weeks ago (2017-11-27 11:40:54 UTC) #7
xcodinas
Do not change input value line
7 months, 3 weeks ago (2017-11-28 16:37:54 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/39851002
7 months, 3 weeks ago (2017-11-28 17:06:20 UTC) #9
ced
LGTM
6 months, 3 weeks ago (2018-01-02 12:39:23 UTC) #10
ced
On 2018/01/02 12:39:23, ced wrote: > LGTM Add a changelog entry.
6 months, 3 weeks ago (2018-01-02 12:39:37 UTC) #11
rietveld-bot_tryton.org
New changeset 0a0cc9f312a7 by Xavier Codinas in branch 'default': Use spellcheck and lang attributes for ...
5 months, 1 week ago (2018-02-12 09:57:38 UTC) #12
xcodinas
5 months, 1 week ago (2018-02-12 12:24:34 UTC) #13
sao: Format lang attribute
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69