Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 40011002: trytond: Do not register tests module on non test pools

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by pokoli
Modified:
6 months, 1 week ago
Reviewers:
timitos3000, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix ced's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M trytond/modules/__init__.py View 1 3 chunks +8 lines, -7 lines 0 comments Download
M trytond/pool.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M trytond/tests/test_tryton.py View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8
pokoli
7 months ago (2017-12-19 15:50:06 UTC) #1
reviewbot
https://codereview.tryton.org/40011002/diff/1/trytond/tests/test_tryton.py#newcode610 trytond/tests/test_tryton.py:610: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/40011002/diff/1/trytond/tests/test_tryton.py#newcode611 trytond/tests/test_tryton.py:611: E731 ...
7 months ago (2017-12-19 16:13:33 UTC) #2
timitos3000
7 months ago (2017-12-19 16:17:48 UTC) #3
ced
https://codereview.tryton.org/40011002/diff/1/trytond/modules/__init__.py File trytond/modules/__init__.py (right): https://codereview.tryton.org/40011002/diff/1/trytond/modules/__init__.py#newcode335 trytond/modules/__init__.py:335: def register_classes(tests=False): Why 'tests' instead of 'test'? https://codereview.tryton.org/40011002/diff/1/trytond/pool.py File ...
6 months, 3 weeks ago (2017-12-28 16:32:54 UTC) #4
pokoli
Fix ced's comments
6 months, 1 week ago (2018-01-11 16:20:19 UTC) #5
pokoli
https://codereview.tryton.org/40011002/diff/1/trytond/tests/test_tryton.py File trytond/tests/test_tryton.py (right): https://codereview.tryton.org/40011002/diff/1/trytond/tests/test_tryton.py#newcode40 trytond/tests/test_tryton.py:40: Pool.start() On 2017/12/28 16:32:54, ced wrote: > I think ...
6 months, 1 week ago (2018-01-11 16:32:19 UTC) #6
reviewbot
https://codereview.tryton.org/40011002/diff/20001/trytond/tests/test_tryton.py#newcode615 trytond/tests/test_tryton.py:615: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/40011002/diff/20001/trytond/tests/test_tryton.py#newcode616 trytond/tests/test_tryton.py:616: E731 ...
6 months, 1 week ago (2018-01-11 16:39:31 UTC) #7
ced
6 months, 1 week ago (2018-01-11 18:14:49 UTC) #8
https://codereview.tryton.org/40011002/diff/1/trytond/tests/test_tryton.py
File trytond/tests/test_tryton.py (right):

https://codereview.tryton.org/40011002/diff/1/trytond/tests/test_tryton.py#ne...
trytond/tests/test_tryton.py:40: Pool.start()
On 2018/01/11 16:32:19, pokoli wrote:
> On 2017/12/28 16:32:54, ced wrote:
> > I think test could be a parameter of start.
> 
> But init call's start, then we should also add to init as it's what used when
> restoring a database. 

Why?

> Not sure if we should add the parameter everywhere.

Not necessary everywhere as it could have a default value.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69