Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(374)

Issue 40101002: tryton: Remove alternative code for gtk+-2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by ced
Modified:
2 months, 2 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove set_widget_style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -291 lines) Patch
M tryton/common/cellrendererbinary.py View 2 chunks +64 lines, -126 lines 0 comments Download
M tryton/common/cellrendererbutton.py View 2 chunks +37 lines, -82 lines 0 comments Download
M tryton/common/widget_style.py View 1 1 chunk +6 lines, -27 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/binary.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/calendar.py View 1 3 chunks +0 lines, -3 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/char.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/dictionary.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/many2one.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/multiselection.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/reference.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/selection.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/textbox.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/timedelta.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/graph_gtk/graph.py View 3 chunks +11 lines, -35 lines 0 comments Download

Messages

Total messages: 7
ced
3 months ago (2018-02-13 15:17:44 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/40101002
3 months ago (2018-02-13 15:50:48 UTC) #2
pokoli
https://codereview.tryton.org/40101002/diff/1/tryton/common/widget_style.py File tryton/common/widget_style.py (right): https://codereview.tryton.org/40101002/diff/1/tryton/common/widget_style.py#newcode5 tryton/common/widget_style.py:5: def set_widget_style(widget, editable): Do we need a function that ...
3 months ago (2018-02-14 09:34:49 UTC) #3
ced
remove set_widget_style
3 months ago (2018-02-14 18:08:23 UTC) #4
reviewbot
https://codereview.tryton.org/40101002/diff/20001/tryton/gui/window/view_form/view/form_gtk/textbox.py#newcode111 tryton/gui/window/view_form/view/form_gtk/textbox.py:111: F821 undefined name 'spell' https://codereview.tryton.org/40101002/diff/20001/tryton/gui/window/view_form/view/form_gtk/textbox.py#newcode112 tryton/gui/window/view_form/view/form_gtk/textbox.py:112: F821 undefined name 'spell' https://codereview.tryton.org/40101002/diff/20001/tryton/gui/window/view_form/view/form_gtk/textbox.py#newcode113 tryton/gui/window/view_form/view/form_gtk/textbox.py:113: F821 ...
3 months ago (2018-02-14 18:15:16 UTC) #5
pokoli
LGTM
3 months ago (2018-02-15 09:40:50 UTC) #6
rietveld-bot_tryton.org
2 months, 2 weeks ago (2018-03-04 00:19:19 UTC) #7
New changeset 0979d4cfd115 by Cédric Krier in branch 'default':
Remove alternative code for gtk+-2
http://hg.tryton.org/tryton/rev/0979d4cfd115
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922