Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(80)

Issue 40171002: account: Use tax code line for tax reporting (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by ced
Modified:
1 year, 1 month ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix childs name #

Total comments: 11

Patch Set 3 : Fix remarks #

Patch Set 4 : Fix backend name #

Patch Set 5 : Add template_override to allow edition #

Patch Set 6 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+573 lines, -426 lines) Patch
M CHANGELOG View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M __init__.py View 1 2 3 4 5 3 chunks +19 lines, -17 lines 0 comments Download
M account.py View 1 2 3 4 5 chunks +39 lines, -16 lines 0 comments Download
M doc/index.rst View 1 2 3 4 5 2 chunks +6 lines, -18 lines 0 comments Download
M move_template.py View 3 chunks +18 lines, -6 lines 0 comments Download
M tax.py View 1 2 3 4 5 26 chunks +334 lines, -274 lines 0 comments Download
M tax.xml View 1 chunk +55 lines, -0 lines 0 comments Download
M tests/scenario_move_template.rst View 1 2 3 4 5 4 chunks +13 lines, -9 lines 0 comments Download
M tests/test_account.py View 2 chunks +9 lines, -16 lines 0 comments Download
M tests/tools.py View 2 chunks +12 lines, -17 lines 0 comments Download
M view/tax_code_form.xml View 1 2 3 4 5 1 chunk +7 lines, -4 lines 0 comments Download
A view/tax_code_line_form.xml View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
A view/tax_code_line_list.xml View 1 chunk +10 lines, -0 lines 0 comments Download
A view/tax_code_line_template_form.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A view/tax_code_line_template_list.xml View 1 chunk +10 lines, -0 lines 0 comments Download
M view/tax_code_template_form.xml View 1 1 chunk +5 lines, -2 lines 0 comments Download
M view/tax_code_tree2.xml View 1 chunk +1 line, -1 line 0 comments Download
M view/tax_form.xml View 1 chunk +0 lines, -20 lines 0 comments Download
M view/tax_line_form.xml View 1 chunk +3 lines, -2 lines 0 comments Download
M view/tax_line_template_form.xml View 1 chunk +3 lines, -2 lines 0 comments Download
M view/tax_line_template_list.xml View 1 chunk +1 line, -1 line 0 comments Download
M view/tax_line_tree.xml View 1 chunk +1 line, -1 line 0 comments Download
M view/tax_template_form.xml View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 16
ced
1 year, 2 months ago (2018-03-16 16:37:07 UTC) #1
reviewbot
https://codereview.tryton.org/40171002/diff/1/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/40171002/diff/1/__init__.py#newcode6 __init__.py:6: ...
1 year, 2 months ago (2018-03-16 16:46:04 UTC) #2
ced
Fix childs name
1 year, 2 months ago (2018-03-18 19:19:23 UTC) #3
reviewbot
https://codereview.tryton.org/40171002/diff/20001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/40171002/diff/20001/__init__.py#newcode6 __init__.py:6: ...
1 year, 2 months ago (2018-03-18 19:24:33 UTC) #4
pokoli
https://codereview.tryton.org/40171002/diff/20001/tax.py File tax.py (right): https://codereview.tryton.org/40171002/diff/20001/tax.py#newcode297 tax.py:297: operator = fields.Selection([ I'm not sure if it's better ...
1 year, 2 months ago (2018-03-19 13:08:08 UTC) #5
ced
https://codereview.tryton.org/40171002/diff/20001/tax.py File tax.py (right): https://codereview.tryton.org/40171002/diff/20001/tax.py#newcode297 tax.py:297: operator = fields.Selection([ On 2018/03/19 13:08:08, pokoli wrote: > ...
1 year, 2 months ago (2018-03-19 13:24:03 UTC) #6
ced
Fix remarks
1 year, 2 months ago (2018-03-19 13:24:23 UTC) #7
pokoli
https://codereview.tryton.org/40171002/diff/20001/tax.py File tax.py (right): https://codereview.tryton.org/40171002/diff/20001/tax.py#newcode855 tax.py:855: if backend.name() == 'postgresl': # FIXME On 2018/03/19 13:24:03, ...
1 year, 2 months ago (2018-03-19 13:33:43 UTC) #8
reviewbot
https://codereview.tryton.org/40171002/diff/40001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/40171002/diff/40001/__init__.py#newcode6 __init__.py:6: ...
1 year, 2 months ago (2018-03-19 13:44:52 UTC) #9
ced
Fix backend name
1 year, 2 months ago (2018-03-19 14:45:06 UTC) #10
reviewbot
https://codereview.tryton.org/40171002/diff/60001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/40171002/diff/60001/__init__.py#newcode6 __init__.py:6: ...
1 year, 2 months ago (2018-03-19 14:49:56 UTC) #11
ced
Add template_override to allow edition
1 year, 2 months ago (2018-03-23 18:53:16 UTC) #12
reviewbot
https://codereview.tryton.org/40171002/diff/80001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/40171002/diff/80001/__init__.py#newcode6 __init__.py:6: ...
1 year, 2 months ago (2018-03-23 18:54:03 UTC) #13
ced
Update to tip
1 year, 2 months ago (2018-03-24 16:34:43 UTC) #14
reviewbot
https://codereview.tryton.org/40171002/diff/100001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/40171002/diff/100001/__init__.py#newcode6 __init__.py:6: ...
1 year, 2 months ago (2018-03-24 16:50:02 UTC) #15
rietveld-bot_tryton.org
1 year, 1 month ago (2018-03-25 21:33:51 UTC) #16
New changeset 9135d0ac6abd by Cédric Krier in branch 'default':
Use tax code line for tax reporting
http://hg.tryton.org/modules/account/rev/9135d0ac6abd
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766