Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 40411002: tryton: Manage active field on search widget (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months, 2 weeks ago by pokoli
Modified:
3 weeks, 3 days ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use show inactive entry to determine if active domain must be added #

Patch Set 3 : Manage active field #

Total comments: 2

Patch Set 4 : Automatically add active field on domain parser #

Patch Set 5 : Update to tip #

Patch Set 6 : Add icon to note active field presence #

Total comments: 8

Patch Set 7 : Make tooltip dinamic and use archive icon #

Patch Set 8 : Do not include active on domain text #

Total comments: 3

Patch Set 9 : Copy icon, use button state, do not add active field #

Total comments: 1

Patch Set 10 : Use AND clause to add inactive domain #

Total comments: 2

Patch Set 11 : Set active test to false on context and set active clause as top level #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -2 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A tryton/data/pixmaps/tryton/tryton-archive.svg View 1 2 3 4 5 6 7 8 1 chunk +317 lines, -0 lines 0 comments Download
M tryton/gui/window/view_form/screen/screen.py View 1 2 3 4 5 6 7 8 9 10 3 chunks +15 lines, -2 lines 0 comments Download
M tryton/gui/window/view_form/view/screen_container.py View 1 2 3 4 5 6 7 8 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 36
pokoli
10 months, 2 weeks ago (2017-06-06 14:40:57 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/40411002
10 months, 2 weeks ago (2017-06-06 14:59:08 UTC) #2
ced
https://tryton-rietveld.appspot.com/40411002/diff/1/tryton/gui/window/view_form/screen/screen.py File tryton/gui/window/view_form/screen/screen.py (right): https://tryton-rietveld.appspot.com/40411002/diff/1/tryton/gui/window/view_form/screen/screen.py#newcode299 tryton/gui/window/view_form/screen/screen.py:299: def process(domain): I think we should try to remove ...
10 months, 2 weeks ago (2017-06-06 21:02:14 UTC) #3
pokoli
Use show inactive entry to determine if active domain must be added
10 months, 2 weeks ago (2017-06-07 11:52:06 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/40411002
10 months, 2 weeks ago (2017-06-07 12:05:14 UTC) #5
pokoli
Manage active field
3 months, 4 weeks ago (2017-12-21 09:33:18 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/40411002
3 months, 4 weeks ago (2017-12-21 09:49:00 UTC) #7
ced
See https://bugs.tryton.org/msg37542 https://codereview.tryton.org/40411002/diff/40001/tryton/gui/window/view_form/view/screen_container.py File tryton/gui/window/view_form/view/screen_container.py (right): https://codereview.tryton.org/40411002/diff/40001/tryton/gui/window/view_form/view/screen_container.py#newcode295 tryton/gui/window/view_form/view/screen_container.py:295: self.active_entry.set_sensitive(screen.domain_parser.show_active) I think it is better to ...
3 months, 1 week ago (2018-01-09 18:08:26 UTC) #8
pokoli
Automatically add active field on domain parser
2 months, 3 weeks ago (2018-01-23 13:23:06 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/40411002
2 months, 3 weeks ago (2018-01-23 13:32:34 UTC) #10
pokoli
Update to tip
2 months, 1 week ago (2018-02-06 11:36:02 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/40411002
2 months, 1 week ago (2018-02-06 11:58:43 UTC) #12
pokoli
Add icon to note active field presence
1 month, 3 weeks ago (2018-02-26 13:37:42 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/40411002
1 month, 3 weeks ago (2018-02-26 13:52:02 UTC) #14
ced
https://codereview.tryton.org/40411002/diff/100001/tryton/gui/window/view_form/view/screen_container.py File tryton/gui/window/view_form/view/screen_container.py (right): https://codereview.tryton.org/40411002/diff/100001/tryton/gui/window/view_form/view/screen_container.py#newcode198 tryton/gui/window/view_form/view/screen_container.py:198: tooltips.set_tip(but_active, _('Show inactive records')) I think the tooltip should ...
4 weeks, 1 day ago (2018-03-21 12:23:47 UTC) #15
pokoli
Make tooltip dinamic and use archive icon
4 weeks ago (2018-03-22 13:05:51 UTC) #16
pokoli
https://codereview.tryton.org/40411002/diff/100001/tryton/gui/window/view_form/view/screen_container.py File tryton/gui/window/view_form/view/screen_container.py (right): https://codereview.tryton.org/40411002/diff/100001/tryton/gui/window/view_form/view/screen_container.py#newcode198 tryton/gui/window/view_form/view/screen_container.py:198: tooltips.set_tip(but_active, _('Show inactive records')) On 2018/03/21 12:23:47, ced wrote: ...
4 weeks ago (2018-03-22 13:05:59 UTC) #17
reviewbot
flake8 OK URL: https://codereview.tryton.org/40411002
4 weeks ago (2018-03-22 13:20:14 UTC) #18
ced
https://codereview.tryton.org/40411002/diff/100001/tryton/gui/window/view_form/view/screen_container.py File tryton/gui/window/view_form/view/screen_container.py (right): https://codereview.tryton.org/40411002/diff/100001/tryton/gui/window/view_form/view/screen_container.py#newcode401 tryton/gui/window/view_form/view/screen_container.py:401: self.screen.search_filter(self.get_text(), set_text=False) On 2018/03/22 13:05:59, pokoli wrote: > On ...
4 weeks ago (2018-03-22 13:41:13 UTC) #19
pokoli
Do not include active on domain text
4 weeks ago (2018-03-22 14:10:32 UTC) #20
pokoli
https://codereview.tryton.org/40411002/diff/100001/tryton/gui/window/view_form/view/screen_container.py File tryton/gui/window/view_form/view/screen_container.py (right): https://codereview.tryton.org/40411002/diff/100001/tryton/gui/window/view_form/view/screen_container.py#newcode401 tryton/gui/window/view_form/view/screen_container.py:401: self.screen.search_filter(self.get_text(), set_text=False) On 2018/03/22 13:41:13, ced wrote: > On ...
4 weeks ago (2018-03-22 14:10:54 UTC) #21
reviewbot
flake8 OK URL: https://codereview.tryton.org/40411002
4 weeks ago (2018-03-22 14:18:52 UTC) #22
ced
https://codereview.tryton.org/40411002/diff/140001/tryton/gui/window/view_form/screen/screen.py File tryton/gui/window/view_form/screen/screen.py (right): https://codereview.tryton.org/40411002/diff/140001/tryton/gui/window/view_form/screen/screen.py#newcode192 tryton/gui/window/view_form/screen/screen.py:192: # Add active field if not present How is ...
4 weeks ago (2018-03-22 18:22:59 UTC) #23
ced
https://codereview.tryton.org/40411002/diff/140001/tryton/gui/window/view_form/view/screen_container.py File tryton/gui/window/view_form/view/screen_container.py (right): https://codereview.tryton.org/40411002/diff/140001/tryton/gui/window/view_form/view/screen_container.py#newcode200 tryton/gui/window/view_form/view/screen_container.py:200: img_active.set_from_stock('tryton-system-file-manager', I would prefer to have a copy with ...
4 weeks ago (2018-03-22 18:29:50 UTC) #24
ced
https://codereview.tryton.org/40411002/diff/140001/tryton/gui/window/view_form/view/screen_container.py File tryton/gui/window/view_form/view/screen_container.py (right): https://codereview.tryton.org/40411002/diff/140001/tryton/gui/window/view_form/view/screen_container.py#newcode400 tryton/gui/window/view_form/view/screen_container.py:400: self.show_inactive = not self.show_inactive I would prefer to not ...
4 weeks ago (2018-03-22 18:32:11 UTC) #25
pokoli
Copy icon, use button state, do not add active field
3 weeks, 6 days ago (2018-03-23 09:28:37 UTC) #26
ced
LGTM
3 weeks, 6 days ago (2018-03-23 09:49:56 UTC) #27
reviewbot
flake8 OK URL: https://codereview.tryton.org/40411002
3 weeks, 6 days ago (2018-03-23 09:55:11 UTC) #28
ced
https://codereview.tryton.org/40411002/diff/160001/tryton/gui/window/view_form/screen/screen.py File tryton/gui/window/view_form/screen/screen.py (right): https://codereview.tryton.org/40411002/diff/160001/tryton/gui/window/view_form/screen/screen.py#newcode302 tryton/gui/window/view_form/screen/screen.py:302: domain.append(('active', '=', False)) You can not use append because ...
3 weeks, 6 days ago (2018-03-23 10:26:07 UTC) #29
pokoli
Use AND clause to add inactive domain
3 weeks, 6 days ago (2018-03-23 11:36:30 UTC) #30
reviewbot
flake8 OK URL: https://codereview.tryton.org/40411002
3 weeks, 6 days ago (2018-03-23 11:44:52 UTC) #31
ced
https://codereview.tryton.org/40411002/diff/180001/tryton/gui/window/view_form/screen/screen.py File tryton/gui/window/view_form/screen/screen.py (right): https://codereview.tryton.org/40411002/diff/180001/tryton/gui/window/view_form/screen/screen.py#newcode264 tryton/gui/window/view_form/screen/screen.py:264: self.offset, self.limit, self.order, context=self.context) I think the active_test context ...
3 weeks, 6 days ago (2018-03-23 14:13:03 UTC) #32
pokoli
Set active test to false on context and set active clause as top level
3 weeks, 6 days ago (2018-03-23 14:58:44 UTC) #33
ced
LGTM
3 weeks, 6 days ago (2018-03-23 15:15:48 UTC) #34
reviewbot
flake8 OK URL: https://codereview.tryton.org/40411002
3 weeks, 6 days ago (2018-03-23 15:15:58 UTC) #35
rietveld-bot_tryton.org
3 weeks, 3 days ago (2018-03-26 12:26:58 UTC) #36
New changeset e7059be59f9e by Sergi Almacellas Abellana in branch 'default':
Manage active field on search widget
http://hg.tryton.org/tryton/rev/e7059be59f9e
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922