Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(151)

Issue 40411002: tryton: Manage active field

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 3 weeks ago by pokoli
Modified:
21 hours, 41 minutes ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use show inactive entry to determine if active domain must be added #

Patch Set 3 : Manage active field #

Total comments: 2

Patch Set 4 : Automatically add active field on domain parser #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M CHANGELOG View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tryton/gui/window/view_form/screen/screen.py View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10
pokoli
7 months, 3 weeks ago (2017-06-06 14:40:57 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/40411002
7 months, 3 weeks ago (2017-06-06 14:59:08 UTC) #2
ced
https://tryton-rietveld.appspot.com/40411002/diff/1/tryton/gui/window/view_form/screen/screen.py File tryton/gui/window/view_form/screen/screen.py (right): https://tryton-rietveld.appspot.com/40411002/diff/1/tryton/gui/window/view_form/screen/screen.py#newcode299 tryton/gui/window/view_form/screen/screen.py:299: def process(domain): I think we should try to remove ...
7 months, 3 weeks ago (2017-06-06 21:02:14 UTC) #3
pokoli
Use show inactive entry to determine if active domain must be added
7 months, 2 weeks ago (2017-06-07 11:52:06 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/40411002
7 months, 2 weeks ago (2017-06-07 12:05:14 UTC) #5
pokoli
Manage active field
1 month ago (2017-12-21 09:33:18 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/40411002
1 month ago (2017-12-21 09:49:00 UTC) #7
ced
See https://bugs.tryton.org/msg37542 https://codereview.tryton.org/40411002/diff/40001/tryton/gui/window/view_form/view/screen_container.py File tryton/gui/window/view_form/view/screen_container.py (right): https://codereview.tryton.org/40411002/diff/40001/tryton/gui/window/view_form/view/screen_container.py#newcode295 tryton/gui/window/view_form/view/screen_container.py:295: self.active_entry.set_sensitive(screen.domain_parser.show_active) I think it is better to ...
2 weeks ago (2018-01-09 18:08:26 UTC) #8
pokoli
Automatically add active field on domain parser
21 hours, 50 minutes ago (2018-01-23 13:23:06 UTC) #9
reviewbot
21 hours, 41 minutes ago (2018-01-23 13:32:34 UTC) #10
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922