Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(383)

Issue 40811002: trytond: Add depends on Button (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by pokoli
Modified:
3 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : reupload test #

Total comments: 2

Patch Set 3 : Do not test for missing depends #

Patch Set 4 : Add modules #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -7 lines) Patch
M CHANGELOG View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M doc/topics/views/index.rst View 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/ir/model.py View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/ir/module.py View 1 chunk +6 lines, -0 lines 0 comments Download
M trytond/ir/ui/view.py View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/model/modelview.py View 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/modules/account/fiscalyear.py View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/modules/account/journal.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/modules/account/move.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M trytond/modules/account/period.py View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/modules/account_asset/asset.py View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/modules/account_deposit/invoice.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M trytond/modules/account_invoice/invoice.py View 1 2 3 3 chunks +5 lines, -0 lines 0 comments Download
M trytond/modules/account_invoice_correction/invoice.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M trytond/modules/account_payment/account.py View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/modules/account_payment_sepa/payment.py View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M trytond/modules/account_payment_stripe/payment.py View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M trytond/modules/account_payment_stripe/view/customer_form.xml View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M trytond/modules/account_payment_stripe/view/payment_form.xml View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M trytond/modules/account_statement/statement.py View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M trytond/modules/account_stock_landed_cost/account.py View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/modules/commission/commission.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M trytond/modules/production/production.py View 1 2 3 3 chunks +7 lines, -0 lines 0 comments Download
M trytond/modules/production_split/production.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M trytond/modules/production_work/work.py View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/modules/project_invoice/work.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/modules/purchase/purchase.py View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M trytond/modules/purchase_request/purchase_request.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M trytond/modules/purchase_requisition/purchase.py View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M trytond/modules/sale/sale.py View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M trytond/modules/sale_complaint/complaint.py View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M trytond/modules/sale_opportunity/opportunity.py View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/modules/sale_subscription/subscription.py View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M trytond/modules/sale_supply_drop_shipment/stock.py View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/modules/stock/inventory.py View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/modules/stock/move.py View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M trytond/modules/stock/period.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/modules/stock/shipment.py View 1 2 3 8 chunks +24 lines, -0 lines 0 comments Download
M trytond/modules/stock/view/move_form.xml View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M trytond/modules/stock_forecast/forecast.py View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M trytond/modules/stock_package_shipping/stock.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/modules/stock_split/stock.py View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M trytond/modules/web_user/user.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/res/user.py View 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/tests/test_tryton.py View 1 2 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 40
pokoli
6 months, 1 week ago (2017-11-10 10:44:10 UTC) #1
pokoli
reupload test
6 months, 1 week ago (2017-11-10 10:49:18 UTC) #2
reviewbot
https://codereview.tryton.org/40811002/diff/20001/trytond/tests/test_tryton.py#newcode616 trytond/tests/test_tryton.py:616: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/40811002/diff/20001/trytond/tests/test_tryton.py#newcode617 trytond/tests/test_tryton.py:617: E731 ...
6 months, 1 week ago (2017-11-10 11:01:56 UTC) #3
ced
LGTM
5 months, 3 weeks ago (2017-11-24 09:29:00 UTC) #4
ced
https://codereview.tryton.org/40811002/diff/20001/trytond/tests/test_tryton.py File trytond/tests/test_tryton.py (right): https://codereview.tryton.org/40811002/diff/20001/trytond/tests/test_tryton.py#newcode314 trytond/tests/test_tryton.py:314: for key, value in button.iteritems(): Should be limited to ...
5 months, 3 weeks ago (2017-11-27 12:03:09 UTC) #5
ced
https://codereview.tryton.org/40811002/diff/20001/trytond/tests/test_tryton.py File trytond/tests/test_tryton.py (right): https://codereview.tryton.org/40811002/diff/20001/trytond/tests/test_tryton.py#newcode314 trytond/tests/test_tryton.py:314: for key, value in button.iteritems(): On 2017/11/27 12:03:09, ced ...
5 months, 3 weeks ago (2017-11-27 12:04:27 UTC) #6
pokoli
Do not test for missing depends
5 months, 3 weeks ago (2017-11-27 12:22:18 UTC) #7
reviewbot
https://codereview.tryton.org/40811002/diff/40001/trytond/tests/test_tryton.py#newcode616 trytond/tests/test_tryton.py:616: E731 do not assign a lambda expression, use a def https://codereview.tryton.org/40811002/diff/40001/trytond/tests/test_tryton.py#newcode617 trytond/tests/test_tryton.py:617: E731 ...
5 months, 3 weeks ago (2017-11-27 12:33:50 UTC) #8
pokoli
Add modules
5 months, 3 weeks ago (2017-11-27 12:50:08 UTC) #9
reviewbot
patch is not applicable URL: https://codereview.tryton.org/40811002
5 months, 3 weeks ago (2017-11-27 13:03:23 UTC) #10
ced
LGTM
3 months ago (2018-02-13 17:52:09 UTC) #11
rietveld-bot_tryton.org
New changeset 4206d6bbf68f by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/trytond/rev/4206d6bbf68f
3 months ago (2018-02-19 10:45:09 UTC) #12
rietveld-bot_tryton.org
New changeset 99324a88d56c by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/account/rev/99324a88d56c
3 months ago (2018-02-19 10:45:12 UTC) #13
rietveld-bot_tryton.org
New changeset e4dbe15c9e83 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/account_asset/rev/e4dbe15c9e83
3 months ago (2018-02-19 10:45:15 UTC) #14
rietveld-bot_tryton.org
New changeset 03ebffaade91 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/account_deposit/rev/03ebffaade91
3 months ago (2018-02-19 10:45:19 UTC) #15
rietveld-bot_tryton.org
New changeset 80fbc1dacc95 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/account_invoice/rev/80fbc1dacc95
3 months ago (2018-02-19 10:45:24 UTC) #16
rietveld-bot_tryton.org
New changeset ca7524ac26e8 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/account_invoice_correction/rev/ca7524ac26e8
3 months ago (2018-02-19 10:45:27 UTC) #17
rietveld-bot_tryton.org
New changeset 8013d4e76c06 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/account_payment/rev/8013d4e76c06
3 months ago (2018-02-19 10:45:29 UTC) #18
rietveld-bot_tryton.org
New changeset ac9057b51cef by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/account_payment_sepa/rev/ac9057b51cef
3 months ago (2018-02-19 10:45:31 UTC) #19
rietveld-bot_tryton.org
New changeset a1b4aa244da0 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/account_payment_stripe/rev/a1b4aa244da0
3 months ago (2018-02-19 10:45:34 UTC) #20
rietveld-bot_tryton.org
New changeset 2ad09697781d by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/account_statement/rev/2ad09697781d
3 months ago (2018-02-19 10:47:51 UTC) #21
rietveld-bot_tryton.org
New changeset 0226662967b5 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/account_stock_landed_cost/rev/0226662967b5
3 months ago (2018-02-19 10:47:58 UTC) #22
rietveld-bot_tryton.org
New changeset ac369e103531 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/commission/rev/ac369e103531
3 months ago (2018-02-19 10:48:06 UTC) #23
rietveld-bot_tryton.org
New changeset 32cc81828f21 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/production/rev/32cc81828f21
3 months ago (2018-02-19 10:48:22 UTC) #24
rietveld-bot_tryton.org
New changeset 5c91db118d88 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/production_split/rev/5c91db118d88
3 months ago (2018-02-19 10:48:31 UTC) #25
rietveld-bot_tryton.org
New changeset 816f5a7b9258 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/production_work/rev/816f5a7b9258
3 months ago (2018-02-19 10:48:38 UTC) #26
rietveld-bot_tryton.org
New changeset 173c1a7301e4 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/project_invoice/rev/173c1a7301e4
3 months ago (2018-02-19 10:48:43 UTC) #27
rietveld-bot_tryton.org
New changeset 09417c6de8e4 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/purchase/rev/09417c6de8e4
3 months ago (2018-02-19 10:48:48 UTC) #28
rietveld-bot_tryton.org
New changeset ca66542abf93 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/purchase_request/rev/ca66542abf93
3 months ago (2018-02-19 10:48:53 UTC) #29
rietveld-bot_tryton.org
New changeset 9d9e3522ea97 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/purchase_requisition/rev/9d9e3522ea97
3 months ago (2018-02-19 10:48:57 UTC) #30
rietveld-bot_tryton.org
New changeset 975d1ee4eb6c by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/sale/rev/975d1ee4eb6c
3 months ago (2018-02-19 10:49:01 UTC) #31
rietveld-bot_tryton.org
New changeset e01f6bae01fc by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/sale_complaint/rev/e01f6bae01fc
3 months ago (2018-02-19 10:49:04 UTC) #32
rietveld-bot_tryton.org
New changeset cb0f645a131b by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/sale_opportunity/rev/cb0f645a131b
3 months ago (2018-02-19 10:49:09 UTC) #33
rietveld-bot_tryton.org
New changeset 79e6c3964cb9 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/sale_subscription/rev/79e6c3964cb9
3 months ago (2018-02-19 10:49:14 UTC) #34
rietveld-bot_tryton.org
New changeset 6c9109a47b3c by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/sale_supply_drop_shipment/rev/6c9109a47b3c
3 months ago (2018-02-19 10:49:21 UTC) #35
rietveld-bot_tryton.org
New changeset bfaf80a1d4e8 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/stock/rev/bfaf80a1d4e8
3 months ago (2018-02-19 10:49:26 UTC) #36
rietveld-bot_tryton.org
New changeset 448bb66fdf64 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/stock_forecast/rev/448bb66fdf64
3 months ago (2018-02-19 10:49:32 UTC) #37
rietveld-bot_tryton.org
New changeset 01d342c19f3c by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/stock_package_shipping/rev/01d342c19f3c
3 months ago (2018-02-19 10:49:42 UTC) #38
rietveld-bot_tryton.org
New changeset 87bf4df3f136 by Sergi Almacellas Abellana in branch 'default': Add depends on Button http://hg.tryton.org/modules/stock_split/rev/87bf4df3f136
3 months ago (2018-02-19 10:49:49 UTC) #39
rietveld-bot_tryton.org
3 months ago (2018-02-19 10:49:55 UTC) #40
New changeset 4153faf25a3e by Sergi Almacellas Abellana in branch 'default':
Add depends on Button
http://hg.tryton.org/modules/web_user/rev/4153faf25a3e
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922