Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(142)

Issue 40921002: account_product 4.6: Use numbered arguments for missing account on Products (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by pokoli
Modified:
17 hours, 22 minutes ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Test explicity the special case #

Total comments: 1

Patch Set 3 : Add keyword #

Total comments: 1

Patch Set 4 : Remove issue from comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M product.py View 1 2 3 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 13
pokoli
1 week, 5 days ago (2018-01-11 16:50:55 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/40921002
1 week, 5 days ago (2018-01-11 17:08:06 UTC) #2
ced
https://codereview.tryton.org/40921002/diff/1/product.py File product.py (right): https://codereview.tryton.org/40921002/diff/1/product.py#newcode32 product.py:32: if self.__class__.__name__ == 'product.category': This is the wrong way. ...
1 week, 3 days ago (2018-01-13 22:39:27 UTC) #3
pokoli
Test explicity the special case
6 days, 1 hour ago (2018-01-18 09:19:32 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/40921002
6 days, 1 hour ago (2018-01-18 09:37:42 UTC) #5
ced
https://codereview.tryton.org/40921002/diff/20001/product.py File product.py (right): https://codereview.tryton.org/40921002/diff/20001/product.py#newcode32 product.py:32: if self.__class__.__name__ == 'product.template': Could have a comment
6 days, 1 hour ago (2018-01-18 10:02:23 UTC) #6
pokoli
Add keyword
6 days ago (2018-01-18 10:37:39 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/40921002
6 days ago (2018-01-18 10:45:16 UTC) #8
ced
https://codereview.tryton.org/40921002/diff/40001/product.py File product.py (right): https://codereview.tryton.org/40921002/diff/40001/product.py#newcode32 product.py:32: # Template message does not have keywords. See issue7043 ...
5 days, 23 hours ago (2018-01-18 11:15:53 UTC) #9
pokoli
Remove issue from comment
5 days, 23 hours ago (2018-01-18 11:27:46 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/40921002
5 days, 23 hours ago (2018-01-18 11:41:28 UTC) #11
ced
LGTM
5 days, 23 hours ago (2018-01-18 11:42:46 UTC) #12
rietveld-bot_tryton.org
17 hours, 22 minutes ago (2018-01-23 17:46:15 UTC) #13
New changeset fc6f33b02ef4 by Sergi Almacellas Abellana in branch '4.6':
Use numbered arguments for missing account on Products
http://hg.tryton.org/modules/account_product/rev/fc6f33b02ef4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922