Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

Issue 41091002: account_tax_cash: Initial commit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months ago by ced
Modified:
8 months, 4 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add some comment #

Patch Set 3 : Support no no period line and group by ratio and period #

Patch Set 4 : Override Invoice.write, fix update ratio and add documentation #

Patch Set 5 : Update update_cash_basis also when invoice is posted, paid or cancel #

Patch Set 6 : Add on_cash_basis property to InvoiceTax #

Patch Set 7 : Add support of tax group on cash basis per supplier #

Total comments: 6

Patch Set 8 : Allow to customize the ratio computation #

Patch Set 9 : Fix tax report by fiscalyear #

Patch Set 10 : Use top parent tax group #

Patch Set 11 : Fix tax group in Invoice.get_move #

Total comments: 4

Patch Set 12 : Use single write #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1740 lines, -0 lines) Patch
A .drone.yml View 1 chunk +51 lines, -0 lines 0 comments Download
A COPYRIGHT View 1 chunk +15 lines, -0 lines 0 comments Download
A INSTALL View 1 chunk +29 lines, -0 lines 0 comments Download
A LICENSE View 1 chunk +674 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 chunk +13 lines, -0 lines 0 comments Download
A README View 1 chunk +35 lines, -0 lines 0 comments Download
A __init__.py View 1 2 3 4 5 6 1 chunk +27 lines, -0 lines 0 comments Download
A account.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +335 lines, -0 lines 0 comments Download
A account.xml View 1 2 3 4 5 6 1 chunk +30 lines, -0 lines 0 comments Download
A doc/index.rst View 1 2 3 4 5 6 1 chunk +21 lines, -0 lines 0 comments Download
A party.py View 1 2 3 4 5 6 1 chunk +14 lines, -0 lines 0 comments Download
A party.xml View 1 2 3 4 5 6 1 chunk +12 lines, -0 lines 0 comments Download
A setup.py View 1 chunk +125 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 chunk +9 lines, -0 lines 0 comments Download
A tests/scenario_account_tax_cash.rst View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +152 lines, -0 lines 0 comments Download
A tests/scenario_account_tax_cash_supplier.rst View 1 2 3 4 5 6 1 chunk +93 lines, -0 lines 0 comments Download
A tests/test_account_tax_cash.py View 1 2 3 4 5 6 1 chunk +33 lines, -0 lines 0 comments Download
A tox.ini View 1 chunk +15 lines, -0 lines 0 comments Download
A tryton.cfg View 1 2 3 4 5 6 1 chunk +10 lines, -0 lines 0 comments Download
A view/fiscalyear_form.xml View 1 chunk +10 lines, -0 lines 0 comments Download
A view/invoice_form.xml View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
A view/party_form.xml View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
A view/period_form.xml View 1 chunk +8 lines, -0 lines 0 comments Download
A view/tax_line_form.xml View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 28
ced
10 months ago (2018-02-16 18:23:31 UTC) #1
ced
Add some comment
10 months ago (2018-02-16 18:34:01 UTC) #2
reviewbot
https://codereview.tryton.org/41091002/diff/20001/account.py#newcode68 account.py:68: E712 comparison to False should be 'if cond is False:' or 'if not ...
10 months ago (2018-02-16 18:45:03 UTC) #3
ced
Support no no period line and group by ratio and period
10 months ago (2018-02-19 10:11:29 UTC) #4
reviewbot
https://codereview.tryton.org/41091002/diff/40001/account.py#newcode69 account.py:69: E712 comparison to False should be 'if cond is False:' or 'if not ...
10 months ago (2018-02-19 10:21:13 UTC) #5
ced
Override Invoice.write, fix update ratio and add documentation
10 months ago (2018-02-19 17:40:00 UTC) #6
reviewbot
https://codereview.tryton.org/41091002/diff/60001/account.py#newcode98 account.py:98: E712 comparison to False should be 'if cond is False:' or 'if not ...
10 months ago (2018-02-19 17:47:33 UTC) #7
ced
Update update_cash_basis also when invoice is posted, paid or cancel
10 months ago (2018-02-19 17:52:19 UTC) #8
reviewbot
https://codereview.tryton.org/41091002/diff/80001/account.py#newcode98 account.py:98: E712 comparison to False should be 'if cond is False:' or 'if not ...
10 months ago (2018-02-19 18:17:04 UTC) #9
ced
Add on_cash_basis property to InvoiceTax
10 months ago (2018-02-20 10:18:19 UTC) #10
reviewbot
https://codereview.tryton.org/41091002/diff/70020/account.py#newcode98 account.py:98: E712 comparison to False should be 'if cond is False:' or 'if not ...
10 months ago (2018-02-20 10:43:18 UTC) #11
ced
Add support of tax group on cash basis per supplier
10 months ago (2018-02-20 11:59:15 UTC) #12
reviewbot
https://codereview.tryton.org/41091002/diff/100001/account.py#newcode100 account.py:100: E712 comparison to False should be 'if cond is False:' or 'if not ...
10 months ago (2018-02-20 12:12:46 UTC) #13
pokoli
https://codereview.tryton.org/41091002/diff/100001/account.py File account.py (right): https://codereview.tryton.org/41091002/diff/100001/account.py#newcode161 account.py:161: if not key['on_cash_basis']: it's not better to filter the ...
10 months ago (2018-02-20 12:22:12 UTC) #14
ced
https://codereview.tryton.org/41091002/diff/100001/account.py File account.py (right): https://codereview.tryton.org/41091002/diff/100001/account.py#newcode161 account.py:161: if not key['on_cash_basis']: On 2018/02/20 12:22:12, pokoli wrote: > ...
10 months ago (2018-02-20 12:39:18 UTC) #15
ced
Allow to customize the ratio computation
10 months ago (2018-02-20 13:37:17 UTC) #16
reviewbot
https://codereview.tryton.org/41091002/diff/120001/account.py#newcode100 account.py:100: E712 comparison to False should be 'if cond is False:' or 'if not ...
10 months ago (2018-02-20 13:42:17 UTC) #17
ced
Fix tax report by fiscalyear
9 months, 2 weeks ago (2018-03-07 17:58:55 UTC) #18
reviewbot
https://codereview.tryton.org/41091002/diff/140001/account.py#newcode100 account.py:100: E712 comparison to False should be 'if cond is False:' or 'if not ...
9 months, 2 weeks ago (2018-03-07 18:22:49 UTC) #19
ced
Use top parent tax group
9 months, 2 weeks ago (2018-03-09 15:56:46 UTC) #20
reviewbot
https://codereview.tryton.org/41091002/diff/160001/account.py#newcode102 account.py:102: E712 comparison to False should be 'if cond is False:' or 'if not ...
9 months, 2 weeks ago (2018-03-09 16:19:09 UTC) #21
ced
Fix tax group in Invoice.get_move
9 months, 1 week ago (2018-03-12 14:02:49 UTC) #22
reviewbot
https://codereview.tryton.org/41091002/diff/180001/account.py#newcode107 account.py:107: E712 comparison to False should be 'if cond is False:' or 'if not ...
9 months, 1 week ago (2018-03-12 14:23:47 UTC) #23
pokoli
https://codereview.tryton.org/41091002/diff/180001/account.py File account.py (right): https://codereview.tryton.org/41091002/diff/180001/account.py#newcode212 account.py:212: tax_line.on_cash_basis = period.is_on_cash_basis( This will trigger a write for ...
9 months ago (2018-03-22 09:46:21 UTC) #24
ced
https://codereview.tryton.org/41091002/diff/180001/account.py File account.py (right): https://codereview.tryton.org/41091002/diff/180001/account.py#newcode212 account.py:212: tax_line.on_cash_basis = period.is_on_cash_basis( On 2018/03/22 09:46:20, pokoli wrote: > ...
9 months ago (2018-03-22 09:59:24 UTC) #25
ced
Use single write
9 months ago (2018-03-22 09:59:32 UTC) #26
reviewbot
https://codereview.tryton.org/41091002/diff/200001/account.py#newcode107 account.py:107: E712 comparison to False should be 'if cond is False:' or 'if not ...
9 months ago (2018-03-22 10:22:22 UTC) #27
rietveld-bot_tryton.org
8 months, 4 weeks ago (2018-03-24 15:00:17 UTC) #28
New changeset 28fbdf1a6625 by Cédric Krier in branch 'default':
Initial commit
http://hg.tryton.org/modules/account_tax_cash/rev/28fbdf1a6625
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766