Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(46)

Issue 411701003: tryton-env: Improve moves synchronisation on drop shipment (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 3 weeks ago by ced
Modified:
4 months, 1 week ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

tryton-env: Improve moves synchronisation on drop shipment By using an origin drop as synchronisation key, the code is simplified but also it allows to follow when products are changed. This allows also to synchronise lots. The origin drop is filled on the customer moves when the drop shipment is set to waiting by using the purchase request as link. issue11700

Patch Set 1 #

Total comments: 2

Patch Set 2 : Keep locations from template #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -74 lines) Patch
M modules/sale_supply_drop_shipment/CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M modules/sale_supply_drop_shipment/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M modules/sale_supply_drop_shipment/stock.py View 1 5 chunks +97 lines, -72 lines 4 comments Download
M modules/sale_supply_drop_shipment/stock.xml View 1 chunk +5 lines, -0 lines 0 comments Download
A modules/sale_supply_drop_shipment/view/stock_move_form.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M modules/stock/view/move_form.xml View 1 chunk +3 lines, -1 line 0 comments Download
M modules/stock_lot/CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M modules/stock_lot/__init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
M modules/stock_lot/stock.py View 1 chunk +7 lines, -0 lines 0 comments Download
M modules/stock_lot/tryton.cfg View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12
ced
4 months, 3 weeks ago (2022-09-12 12:12:24 UTC) #1
reviewbot
patch is not applicable URL: https://codereview.tryton.org/411701003
4 months, 3 weeks ago (2022-09-12 12:18:19 UTC) #2
reviewbot
checks OK URL: https://codereview.tryton.org/411701003
4 months, 3 weeks ago (2022-09-12 12:44:45 UTC) #3
pokoli
https://codereview.tryton.org/411701003/diff/441441003/modules/sale_supply_drop_shipment/stock.py File modules/sale_supply_drop_shipment/stock.py (left): https://codereview.tryton.org/411701003/diff/441441003/modules/sale_supply_drop_shipment/stock.py#oldcode503 modules/sale_supply_drop_shipment/stock.py:503: from_location=move.to_location, I think we should keep the to_location from ...
4 months, 3 weeks ago (2022-09-12 12:53:37 UTC) #4
ced
https://codereview.tryton.org/411701003/diff/441441003/modules/sale_supply_drop_shipment/stock.py File modules/sale_supply_drop_shipment/stock.py (left): https://codereview.tryton.org/411701003/diff/441441003/modules/sale_supply_drop_shipment/stock.py#oldcode503 modules/sale_supply_drop_shipment/stock.py:503: from_location=move.to_location, On 2022/09/12 12:53:37, pokoli wrote: > I think ...
4 months, 3 weeks ago (2022-09-12 14:40:51 UTC) #5
ced
4 months, 3 weeks ago (2022-09-12 14:41:35 UTC) #6
reviewbot
checks OK URL: https://codereview.tryton.org/411701003
4 months, 3 weeks ago (2022-09-12 14:48:26 UTC) #7
pokoli
https://codereview.tryton.org/411701003/diff/421691003/modules/sale_supply_drop_shipment/stock.py File modules/sale_supply_drop_shipment/stock.py (right): https://codereview.tryton.org/411701003/diff/421691003/modules/sale_supply_drop_shipment/stock.py#newcode508 modules/sale_supply_drop_shipment/stock.py:508: move.from_location = template.from_location this should be template.to_location https://codereview.tryton.org/411701003/diff/421691003/modules/sale_supply_drop_shipment/stock.py#newcode509 modules/sale_supply_drop_shipment/stock.py:509: ...
4 months, 3 weeks ago (2022-09-12 16:08:49 UTC) #8
ced
https://codereview.tryton.org/411701003/diff/421691003/modules/sale_supply_drop_shipment/stock.py File modules/sale_supply_drop_shipment/stock.py (right): https://codereview.tryton.org/411701003/diff/421691003/modules/sale_supply_drop_shipment/stock.py#newcode508 modules/sale_supply_drop_shipment/stock.py:508: move.from_location = template.from_location On 2022/09/12 16:08:49, pokoli wrote: > ...
4 months, 3 weeks ago (2022-09-12 17:13:17 UTC) #9
rietveld-bot_tryton.org
New changeset aa298e7213e0 by Cédric Krier in branch 'default': Improve moves synchronisation on drop shipment ...
4 months, 1 week ago (2022-09-26 22:29:55 UTC) #10
rietveld-bot_tryton.org
New changeset c516c469500c by Cédric Krier in branch 'default': Improve moves synchronisation on drop shipment ...
4 months, 1 week ago (2022-09-26 22:30:11 UTC) #11
rietveld-bot_tryton.org
4 months, 1 week ago (2022-09-26 22:30:27 UTC) #12
New changeset c799a13dbc19 by Cédric Krier in branch 'default':
Improve moves synchronisation on drop shipment
https://hg.tryton.org/tryton-env/rev/c799a13dbc19
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted