Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 412081003: tryton-env: Do not trigger button not selected records (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by nicoe
Modified:
3 weeks, 5 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

tryton-env: Ensure that click on button in list-form mode selects first the line issue11824

Patch Set 1 #

Total comments: 4

Patch Set 2 : Do not trigger button not selected records #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M sao/src/view/list_form.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/list_form.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7
nicoe
3 months, 1 week ago (2022-10-24 12:20:20 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/412081003
3 months, 1 week ago (2022-10-24 12:38:22 UTC) #2
ced
https://codereview.tryton.org/412081003/diff/447381003/sao/src/view/list_form.js File sao/src/view/list_form.js (right): https://codereview.tryton.org/412081003/diff/447381003/sao/src/view/list_form.js#newcode15 sao/src/view/list_form.js:15: (this.listform.selected_records.length != 1)) { Could use screen.selected_records so there ...
3 months, 1 week ago (2022-10-25 14:52:54 UTC) #3
nicoe
2 months, 3 weeks ago (2022-11-08 22:59:18 UTC) #4
nicoe
https://codereview.tryton.org/412081003/diff/447381003/sao/src/view/list_form.js File sao/src/view/list_form.js (right): https://codereview.tryton.org/412081003/diff/447381003/sao/src/view/list_form.js#newcode15 sao/src/view/list_form.js:15: (this.listform.selected_records.length != 1)) { On 2022/10/25 14:52:53, ced wrote: ...
2 months, 3 weeks ago (2022-11-08 23:00:25 UTC) #5
reviewbot
checks OK URL: https://codereview.tryton.org/412081003
2 months, 3 weeks ago (2022-11-08 23:04:15 UTC) #6
ced
2 months, 3 weeks ago (2022-11-10 21:02:17 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted