tryton-env: Do not trigger button not selected records

tryton-env: Ensure that click on button in list-form mode selects first the line

issue11824

[reviewbot, 2022-10-24 12:38:22]

checks OK
URL: https://codereview.tryton.org/412081003

[ced, 2022-10-25 14:52:54]

https://codereview.tryton.org/412081003/diff/447381003/sao/src/view/list_form.js
File sao/src/view/list_form.js (right):

https://codereview.tryton.org/412081003/diff/447381003/sao/src/view/list_form...
sao/src/view/list_form.js:15: (this.listform.selected_records.length != 1)) {
Could use screen.selected_records so there is no need for listform attribute.

https://codereview.tryton.org/412081003/diff/447381003/tryton/tryton/gui/wind...
File tryton/tryton/gui/window/view_form/view/list_form.py (right):

https://codereview.tryton.org/412081003/diff/447381003/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/view/list_form.py:28: or
len(self.listform.selected_records) != 1):
For me it is better to test selected_records from the screen because it is this
list that is used.

Also I think it will be easier to understand like this:

if self.screen.selected_records == [self.record]:

[nicoe, 2022-11-08 23:00:25]

https://codereview.tryton.org/412081003/diff/447381003/sao/src/view/list_form.js
File sao/src/view/list_form.js (right):

https://codereview.tryton.org/412081003/diff/447381003/sao/src/view/list_form...
sao/src/view/list_form.js:15: (this.listform.selected_records.length != 1)) {
On 2022/10/25 14:52:53, ced wrote:
> Could use screen.selected_records so there is no need for listform attribute.

Done.

https://codereview.tryton.org/412081003/diff/447381003/tryton/tryton/gui/wind...
File tryton/tryton/gui/window/view_form/view/list_form.py (right):

https://codereview.tryton.org/412081003/diff/447381003/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/view/list_form.py:28: or
len(self.listform.selected_records) != 1):
On 2022/10/25 14:52:53, ced wrote:
> For me it is better to test selected_records from the screen because it is
this
> list that is used.
> 
> Also I think it will be easier to understand like this:
> 
> if self.screen.selected_records == [self.record]:

Done.

[reviewbot, 2022-11-08 23:04:15]

checks OK
URL: https://codereview.tryton.org/412081003

[ced, 2022-11-10 21:02:17]

LGTM