Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(61)

Issue 41251002: analytic_account: Quantize to number of digits instead of rounding computed amount (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 days, 7 hours ago by ced
Modified:
1 day, 16 hours ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Rounding may change the result if currency rounding is not unitary. issue7284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M account.py View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4
ced
4 days, 7 hours ago (2018-04-15 17:10:42 UTC) #1
reviewbot
https://codereview.tryton.org/41251002/diff/1/account.py#newcode210 account.py:210: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
4 days, 7 hours ago (2018-04-15 17:24:39 UTC) #2
pokoli
LGTM
3 days, 16 hours ago (2018-04-16 08:33:54 UTC) #3
rietveld-bot_tryton.org
1 day, 16 hours ago (2018-04-18 08:19:12 UTC) #4
New changeset 0abecf4b7c9c by Cédric Krier in branch 'default':
Quantize to number of digits instead of rounding computed amount
http://hg.tryton.org/modules/analytic_account/rev/0abecf4b7c9c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922