Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 413351003: project_invoice: allow project task to use parent description

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 1 week ago by cman
Modified:
3 months ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Responded to feedback and fixed the rounding of the sums of unit quantities #

Patch Set 3 : Parent field set as readonly when task has been invoiced using parent's description #

Total comments: 13
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M CHANGELOG View 1 1 chunk +2 lines, -0 lines 0 comments Download
M project.py View 1 2 6 chunks +24 lines, -3 lines 13 comments Download
M view/work_form.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11
cman
7 months, 1 week ago (2022-06-25 05:33:36 UTC) #1
cman
On 2022/06/25 05:33:36, cman wrote: Sorry I did not include translations. I'll submit those once ...
7 months, 1 week ago (2022-06-25 05:51:50 UTC) #2
reviewbot
https://codereview.tryton.org/413351003/diff/423441003/project.py#newcode403 project.py:403: line too long (84 > 79 characters) URL: https://codereview.tryton.org/413351003
7 months, 1 week ago (2022-06-25 06:01:27 UTC) #3
pokoli
https://codereview.tryton.org/413351003/diff/423441003/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/413351003/diff/423441003/CHANGELOG#newcode1 CHANGELOG:1: Version Version is not required, such lines are automatically ...
7 months, 1 week ago (2022-06-27 08:07:04 UTC) #4
cman
7 months, 1 week ago (2022-06-28 23:48:21 UTC) #5
reviewbot
checks OK URL: https://codereview.tryton.org/413351003
7 months, 1 week ago (2022-06-29 00:16:31 UTC) #6
cman
7 months ago (2022-07-01 05:41:26 UTC) #7
reviewbot
checks OK URL: https://codereview.tryton.org/413351003
7 months ago (2022-07-01 05:42:26 UTC) #8
ced
Missing a test. https://codereview.tryton.org/413351003/diff/417491003/project.py File project.py (right): https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode397 project.py:397: invoice_on_parent = fields.Boolean("Invoice on Parent", For ...
6 months, 3 weeks ago (2022-07-11 20:13:27 UTC) #9
cman
https://codereview.tryton.org/413351003/diff/417491003/project.py File project.py (right): https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode397 project.py:397: invoice_on_parent = fields.Boolean("Invoice on Parent", On 2022/07/11 20:13:27, ced ...
3 months ago (2022-10-29 17:00:10 UTC) #10
cman
3 months ago (2022-10-29 17:07:16 UTC) #11
https://codereview.tryton.org/413351003/diff/417491003/project.py
File project.py (right):

https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode420
project.py:420: Eval('invoice_on_parent') & Bool(Eval('invoiced_amount'))
On 2022/10/29 17:00:09, cman wrote:
> On 2022/07/11 20:13:27, ced wrote:
> > I do not see the point of such restriction.
> 
> Good point (as mentioned above). I will remove this restriction.

Actually, one more consideration as I'm remembering more about my earlier
reasoning for this: if a task is being invoiced using its parent's description
and it has an invoiced_amount, should it be possible to change the parent?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted