project_invoice: allow project task to use parent description

issue11579

[cman, 2022-06-25 05:51:50]

On 2022/06/25 05:33:36, cman wrote:

Sorry I did not include translations. I'll submit those once I get some feedback
on the general approach I have taken.

[reviewbot, 2022-06-25 06:01:27]

https://codereview.tryton.org/413351003/diff/423441003/project.py#newcode403
project.py:403:
line too long (84 > 79 characters)


URL: https://codereview.tryton.org/413351003

[pokoli, 2022-06-27 08:07:04]

https://codereview.tryton.org/413351003/diff/423441003/CHANGELOG
File CHANGELOG (right):

https://codereview.tryton.org/413351003/diff/423441003/CHANGELOG#newcode1
CHANGELOG:1: Version
Version is not required, such lines are automatically managed by the relase
process

https://codereview.tryton.org/413351003/diff/423441003/CHANGELOG#newcode2
CHANGELOG:2: * Allow to invoice tasks using parent description
allow to invoice -> allow invoicing

https://codereview.tryton.org/413351003/diff/423441003/project.py
File project.py (right):

https://codereview.tryton.org/413351003/diff/423441003/project.py#newcode650
project.py:650: def description(self):
I think it is better named invoice_description

[reviewbot, 2022-06-29 00:16:31]

checks OK
URL: https://codereview.tryton.org/413351003

[reviewbot, 2022-07-01 05:42:26]

checks OK
URL: https://codereview.tryton.org/413351003

[ced, 2022-07-11 20:13:27]

Missing a test.

https://codereview.tryton.org/413351003/diff/417491003/project.py
File project.py (right):

https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode397
project.py:397: invoice_on_parent = fields.Boolean("Invoice on Parent",
For me the name does not correspond to what it does.

https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode399
project.py:399: 'readonly': Bool(Eval('invoiced_amount')),
Why?

https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode401
project.py:401: },
for me it will be good to have a domain that enforce the value to False when it
can not be true.

https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode418
project.py:418: cls.parent.states.update({
You can not crush previous readonly state, you must manage to merge them.

https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode420
project.py:420: Eval('invoice_on_parent') & Bool(Eval('invoiced_amount'))
I do not see the point of such restriction.

https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode575
project.py:575: quantity = unit.round(sum(l['quantity'] for l in lines))
I do not see the link with the current feature.

[cman, 2022-10-29 17:00:10]

https://codereview.tryton.org/413351003/diff/417491003/project.py
File project.py (right):

https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode397
project.py:397: invoice_on_parent = fields.Boolean("Invoice on Parent",
On 2022/07/11 20:13:27, ced wrote:
> For me the name does not correspond to what it does.

Would it be more clear to say "Invoice using parent's description"?

https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode399
project.py:399: 'readonly': Bool(Eval('invoiced_amount')),
On 2022/07/11 20:13:27, ced wrote:
> Why?

I was initially thinking that once an invoice method is chosen, a project should
invoice the same way for the duration of the project, but I see that logic is
not enforced anywhere else in Tryton. I think it is better continue with
Tryton's logic, i.e. to be flexible.

https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode401
project.py:401: },
On 2022/07/11 20:13:27, ced wrote:
> for me it will be good to have a domain that enforce the value to False when
it
> can not be true.

Agreed. I will fix this to not only be invisible, but to enforce the value to
False.

https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode418
project.py:418: cls.parent.states.update({
On 2022/07/11 20:13:27, ced wrote:
> You can not crush previous readonly state, you must manage to merge them.

Acknowledged.

https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode420
project.py:420: Eval('invoice_on_parent') & Bool(Eval('invoiced_amount'))
On 2022/07/11 20:13:27, ced wrote:
> I do not see the point of such restriction.

Good point (as mentioned above). I will remove this restriction.

https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode575
project.py:575: quantity = unit.round(sum(l['quantity'] for l in lines))
On 2022/07/11 20:13:27, ced wrote:
> I do not see the link with the current feature.

This is a fix for a bug that came up as I was working on this feature. I'll make
a separate bug report.

[cman, 2022-10-29 17:07:16]

https://codereview.tryton.org/413351003/diff/417491003/project.py
File project.py (right):

https://codereview.tryton.org/413351003/diff/417491003/project.py#newcode420
project.py:420: Eval('invoice_on_parent') & Bool(Eval('invoiced_amount'))
On 2022/10/29 17:00:09, cman wrote:
> On 2022/07/11 20:13:27, ced wrote:
> > I do not see the point of such restriction.
> 
> Good point (as mentioned above). I will remove this restriction.

Actually, one more consideration as I'm remembering more about my earlier
reasoning for this: if a task is being invoiced using its parent's description
and it has an invoiced_amount, should it be possible to change the parent?