Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 413951003: sao: Use date input for DateTime picker on Firefox

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by pokoli
Modified:
2 months, 1 week ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Use date input for DateTime picker on Firefox issue11910

Patch Set 1 #

Patch Set 2 : Keep time when editing #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M src/view/form.js View 1 2 chunks +25 lines, -1 line 4 comments Download

Messages

Total messages: 8
pokoli
2 months, 1 week ago (2022-11-23 12:16:24 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/413951003
2 months, 1 week ago (2022-11-23 12:30:33 UTC) #2
pokoli
Keep time when editing
2 months, 1 week ago (2022-11-23 13:33:06 UTC) #3
reviewbot
checks OK URL: https://codereview.tryton.org/413951003
2 months, 1 week ago (2022-11-23 13:34:20 UTC) #4
ced
https://codereview.tryton.org/413951003/diff/439801003/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/413951003/diff/439801003/src/view/form.js#newcode1830 src/view/form.js:1830: this.get_format(), this.date.val()); For me this is wrong to parse ...
2 months, 1 week ago (2022-11-23 13:38:00 UTC) #5
pokoli
https://codereview.tryton.org/413951003/diff/439801003/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/413951003/diff/439801003/src/view/form.js#newcode1830 src/view/form.js:1830: this.get_format(), this.date.val()); On 2022/11/23 13:38:00, ced wrote: > For ...
2 months, 1 week ago (2022-11-23 13:44:34 UTC) #6
ced
https://codereview.tryton.org/413951003/diff/439801003/src/view/form.js File src/view/form.js (right): https://codereview.tryton.org/413951003/diff/439801003/src/view/form.js#newcode1830 src/view/form.js:1830: this.get_format(), this.date.val()); On 2022/11/23 13:44:34, pokoli wrote: > On ...
2 months, 1 week ago (2022-11-23 14:03:16 UTC) #7
pokoli
2 months, 1 week ago (2022-11-23 14:26:59 UTC) #8
https://codereview.tryton.org/413951003/diff/439801003/src/view/form.js
File src/view/form.js (right):

https://codereview.tryton.org/413951003/diff/439801003/src/view/form.js#newco...
src/view/form.js:1830: this.get_format(), this.date.val());
On 2022/11/23 14:03:16, ced wrote:
> On 2022/11/23 13:44:34, pokoli wrote:
> > On 2022/11/23 13:38:00, ced wrote:
> > > For me this is wrong to parse twice the date value.
> > 
> > THis is not parsing the value twice, this is parsing the current value of
the
> > text to read the time. 
> 
> When called from get_value.
> 

get_value calls this._parse, so to avoid calling the current value I just
updated the code to avoid the recursive call.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted