tryton-env: Improve docs of product_quantity modules

issue11562

[reviewbot, 2022-06-20 11:01:27]

patch is not applicable
URL: https://codereview.tryton.org/415231003

[pokoli, 2022-06-20 11:53:29]

On 2022/06/20 11:01:27, reviewbot wrote:
> patch is not applicable
> URL: https://codereview.tryton.org/415231003
Prefix should be tryton-env

[pokoli, 2022-06-20 12:03:05]

I just commented the purchase one but similar comments should be applicable for
the sale modules.

https://codereview.tryton.org/415231003/diff/427401003/modules/purchase_produ...
File modules/purchase_product_quantity/doc/design.rst (right):

https://codereview.tryton.org/415231003/diff/427401003/modules/purchase_produ...
modules/purchase_product_quantity/doc/design.rst:18: - Buy a minimal quantity of
a product
It's not buy, but force the purchase of a minimal quantity for a product (and
supplier)

https://codereview.tryton.org/415231003/diff/427401003/modules/purchase_produ...
modules/purchase_product_quantity/doc/design.rst:19: - Buy by roundings of that
product unit
Idem, it's force the rounding (purchasing by pack).

https://codereview.tryton.org/415231003/diff/427401003/modules/purchase_produ...
modules/purchase_product_quantity/doc/design.rst:20: - And with combination of
both you can set a minimum and force the rounding
I think that this sentence is reduncation and does not clarify any additional
feature.

https://codereview.tryton.org/415231003/diff/427401003/modules/purchase_produ...
File modules/purchase_product_quantity/product.py (right):

https://codereview.tryton.org/415231003/diff/427401003/modules/purchase_produ...
modules/purchase_product_quantity/product.py:22: help="Minimal quantity to buy")
help text should end with dot.

https://codereview.tryton.org/415231003/diff/427401003/modules/purchase_produ...
modules/purchase_product_quantity/product.py:22: help="Minimal quantity to buy")
I think is better: The minimual quantity that can be bought for the supplier. 

Note that the supplier is important.

https://codereview.tryton.org/415231003/diff/427401003/modules/purchase_produ...
modules/purchase_product_quantity/product.py:30: help="Value to force purchase
quantity to be multiple of")
The quantity that the product should be bought at multiple of for the supplier.

[acaubet, 2022-06-20 14:19:19]

Fix pokoli remarks

[reviewbot, 2022-06-20 14:34:16]

checks OK
URL: https://codereview.tryton.org/415231003