Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(423)

Issue 41571002: trytond: Make application decorator and classes reusable

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by pokoli
Modified:
1 week, 4 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 7

Patch Set 2 : Use static mixind and functions to reuse more code #

Patch Set 3 : Fix class name on super call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -69 lines) Patch
M trytond/protocols/wrappers.py View 1 1 chunk +39 lines, -35 lines 0 comments Download
M trytond/res/routes.py View 1 3 chunks +2 lines, -29 lines 0 comments Download
M trytond/res/user.py View 1 2 4 chunks +42 lines, -5 lines 0 comments Download

Messages

Total messages: 9
pokoli
2 months ago (2017-09-20 13:59:47 UTC) #1
reviewbot
https://codereview.tryton.org/41571002/diff/1/trytond/res/user.py#newcode535 trytond/res/user.py:535: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
2 months ago (2017-09-20 14:21:29 UTC) #2
ced
https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/protocols/wrappers.py File trytond/protocols/wrappers.py (right): https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/protocols/wrappers.py#newcode147 trytond/protocols/wrappers.py:147: def application_decorator(logger, model): I do not think logger should ...
2 months ago (2017-09-25 18:45:59 UTC) #3
pokoli
Use static mixind and functions to reuse more code
1 month, 4 weeks ago (2017-09-26 16:05:10 UTC) #4
reviewbot
https://codereview.tryton.org/41571002/diff/20001/trytond/res/user.py#newcode535 trytond/res/user.py:535: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
1 month, 4 weeks ago (2017-09-26 16:16:03 UTC) #5
pokoli
https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/res/user.py File trytond/res/user.py (right): https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/res/user.py#newcode766 trytond/res/user.py:766: def user_application(user_model): On 2017/09/25 18:45:59, ced wrote: > idem ...
1 month, 4 weeks ago (2017-09-26 16:58:38 UTC) #6
ced
LGTM
1 week, 4 days ago (2017-11-13 10:09:57 UTC) #7
pokoli
Fix class name on super call
1 week, 4 days ago (2017-11-13 11:31:28 UTC) #8
reviewbot
1 week, 4 days ago (2017-11-13 11:33:48 UTC) #9
https://codereview.tryton.org/41571002/diff/40001/trytond/res/user.py#newcode535
trytond/res/user.py:535:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

URL: https://codereview.tryton.org/41571002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922