trytond: Make application decorator and classes reusable

issue6086

[reviewbot, 2017-09-20 14:21:29]

https://codereview.tryton.org/41571002/diff/1/trytond/res/user.py#newcode535
trytond/res/user.py:535:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

URL: https://codereview.tryton.org/41571002

[ced, 2017-09-25 18:45:59]

https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/protocols/wrapper...
File trytond/protocols/wrappers.py (right):

https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/protocols/wrapper...
trytond/protocols/wrappers.py:147: def application_decorator(logger, model):
I do not think logger should be changed.

https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/res/routes.py
File trytond/res/routes.py (right):

https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/res/routes.py#new...
trytond/res/routes.py:15: def create_user_application(logger, path, model,
search_field, user_field):
idem about logger

https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/res/routes.py#new...
trytond/res/routes.py:17: 
I do not find wise to create entry point this way.
It is not very flexible and it complicate the code.

It will be better to just have few methods to ease implementation of similar
entry point.

https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/res/user.py
File trytond/res/user.py (right):

https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/res/user.py#newco...
trytond/res/user.py:766: def user_application(user_model):
idem about complexity.

It could be done with a static mixin.

https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/res/user.py#newco...
trytond/res/user.py:771: user = fields.Many2One(user_model, "User", select=True)
Why not use a Reference?

[pokoli, 2017-09-26 16:05:10]

Use static mixind and functions to reuse more code

[reviewbot, 2017-09-26 16:16:03]

https://codereview.tryton.org/41571002/diff/20001/trytond/res/user.py#newcode535
trytond/res/user.py:535:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

URL: https://codereview.tryton.org/41571002

[pokoli, 2017-09-26 16:58:38]

https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/res/user.py
File trytond/res/user.py (right):

https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/res/user.py#newco...
trytond/res/user.py:766: def user_application(user_model):
On 2017/09/25 18:45:59, ced wrote:
> idem about complexity.
> 
> It could be done with a static mixin.

Done.

https://tryton-rietveld.appspot.com/41571002/diff/1/trytond/res/user.py#newco...
trytond/res/user.py:771: user = fields.Many2One(user_model, "User", select=True)
On 2017/09/25 18:45:59, ced wrote:
> Why not use a Reference?

Indeed I prefer Many2One to ensure relational data. 

BTW, I just moved it outside the mixin, so the developer can chose which field
to use.

[ced, 2017-11-13 10:09:57]

LGTM

[pokoli, 2017-11-13 11:31:28]

Fix class name on super call

[reviewbot, 2017-11-13 11:33:48]

https://codereview.tryton.org/41571002/diff/40001/trytond/res/user.py#newcode535
trytond/res/user.py:535:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

URL: https://codereview.tryton.org/41571002

[ced, 2018-03-10 18:34:39]

https://codereview.tryton.org/41571002/diff/40001/trytond/res/user.py
File trytond/res/user.py (right):

https://codereview.tryton.org/41571002/diff/40001/trytond/res/user.py#newcode845
trytond/res/user.py:845: def login(cls, users, login, data):
For me, login is the wrong name.

[ced, 2018-03-10 18:35:02]

https://codereview.tryton.org/41571002/diff/40001/trytond/res/user.py
File trytond/res/user.py (right):

https://codereview.tryton.org/41571002/diff/40001/trytond/res/user.py#newcode845
trytond/res/user.py:845: def login(cls, users, login, data):
On 2018/03/10 18:34:39, ced wrote:
> For me, login is the wrong name.

register is probably a better name.

[pokoli, 2018-03-19 09:37:37]

Rename login into register

[reviewbot, 2018-03-19 09:47:00]

https://codereview.tryton.org/41571002/diff/60001/trytond/res/user.py#newcode621
trytond/res/user.py:621:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

URL: https://codereview.tryton.org/41571002