Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 415861003: tryton-env: Catch error when rendering cells in treeviews (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by nicoe
Modified:
3 weeks, 5 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

tryton-env: Catch error when rendering cells in treeviews issue11835

Patch Set 1 #

Total comments: 13

Patch Set 2 : Fix remarks #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -38 lines) Patch
M tryton/tryton/common/selection.py View 2 chunks +2 lines, -2 lines 1 comment Download
M tryton/tryton/gui/window/view_form/model/record.py View 1 3 chunks +7 lines, -3 lines 0 comments Download
M tryton/tryton/gui/window/view_form/view/list_gtk/editabletree.py View 3 chunks +3 lines, -3 lines 2 comments Download
M tryton/tryton/gui/window/view_form/view/list_gtk/widget.py View 1 14 chunks +59 lines, -30 lines 6 comments Download

Messages

Total messages: 8
nicoe
3 months, 1 week ago (2022-10-27 16:01:09 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/415861003
3 months, 1 week ago (2022-10-27 16:04:11 UTC) #2
ced
https://codereview.tryton.org/415861003/diff/418541003/tryton/tryton/gui/window/view_form/model/record.py File tryton/tryton/gui/window/view_form/model/record.py (right): https://codereview.tryton.org/415861003/diff/418541003/tryton/tryton/gui/window/view_form/model/record.py#newcode49 tryton/tryton/gui/window/view_form/model/record.py:49: def fetch(self, name, process_exception=True): why not use load like ...
3 months, 1 week ago (2022-10-27 18:21:30 UTC) #3
nicoe
https://codereview.tryton.org/415861003/diff/418541003/tryton/tryton/gui/window/view_form/model/record.py File tryton/tryton/gui/window/view_form/model/record.py (right): https://codereview.tryton.org/415861003/diff/418541003/tryton/tryton/gui/window/view_form/model/record.py#newcode49 tryton/tryton/gui/window/view_form/model/record.py:49: def fetch(self, name, process_exception=True): On 2022/10/27 18:21:30, ced wrote: ...
2 months, 3 weeks ago (2022-11-08 20:26:46 UTC) #4
nicoe
2 months, 3 weeks ago (2022-11-08 20:30:15 UTC) #5
reviewbot
checks OK URL: https://codereview.tryton.org/415861003
2 months, 3 weeks ago (2022-11-08 20:57:13 UTC) #6
ced
https://codereview.tryton.org/415861003/diff/418541003/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/415861003/diff/418541003/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode62 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:62: traceback.print_exc() On 2022/11/08 20:26:45, nicoe wrote: > On 2022/10/27 ...
2 months, 3 weeks ago (2022-11-09 07:30:38 UTC) #7
ced
2 months, 3 weeks ago (2022-11-10 20:57:37 UTC) #8
https://codereview.tryton.org/415861003/diff/421941003/tryton/tryton/common/s...
File tryton/tryton/common/selection.py (right):

https://codereview.tryton.org/415861003/diff/421941003/tryton/tryton/common/s...
tryton/tryton/common/selection.py:74: context=context,
process_exception=process_exception)
I think process_exception could always be False.

https://codereview.tryton.org/415861003/diff/421941003/tryton/tryton/gui/wind...
File tryton/tryton/gui/window/view_form/view/list_gtk/editabletree.py (right):

https://codereview.tryton.org/415861003/diff/421941003/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/view/list_gtk/editabletree.py:54: field =
record.group.fields[column.name]
we must ensure that the field has been loaded.

https://codereview.tryton.org/415861003/diff/421941003/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/view/list_gtk/editabletree.py:86: field =
current_record.group.fields[column.name]
idem

https://codereview.tryton.org/415861003/diff/421941003/tryton/tryton/gui/wind...
File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right):

https://codereview.tryton.org/415861003/diff/421941003/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:62:
traceback.print_exc()
must use logging

https://codereview.tryton.org/415861003/diff/421941003/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:350:
self.attrs['name'], process_exception=False).get_client(record)
load does not return field.

https://codereview.tryton.org/415861003/diff/421941003/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:415: field =
record.load(self.attrs['name'], process_exception=False)
load does not return field

https://codereview.tryton.org/415861003/diff/421941003/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:750: pixbuf =
data2pixbuf(value)
If there is an error value is a string so this will not work.

https://codereview.tryton.org/415861003/diff/421941003/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:758: field =
record.load(self.attrs['name'], process_exception=False)
idem

https://codereview.tryton.org/415861003/diff/421941003/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:999: field =
record.load(self.attrs['name'], process_exception=False)
idem
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted