Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(431)

Issue 41671002: party: Improve distinction of address record name. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 1 day ago by ced
Modified:
1 week, 3 days ago
Reviewers:
pokoli, rietveld-bot, rmu, reviewbot
Visibility:
Public.

Description

Add building name, first street line and country code on address rec_name. Also use party full_name instead of rec_name as it is used to format the address. issue6926

Patch Set 1 #

Patch Set 2 : Update the searcher to match the getter #

Total comments: 1

Patch Set 3 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M address.py View 1 2 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 9
ced
2 weeks, 1 day ago (2017-11-09 12:05:22 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/41671002
2 weeks, 1 day ago (2017-11-09 12:09:18 UTC) #2
ced
Update the searcher to match the getter
2 weeks, 1 day ago (2017-11-09 12:49:58 UTC) #3
reviewbot
flake8 OK URL: https://codereview.tryton.org/41671002
2 weeks, 1 day ago (2017-11-09 12:58:40 UTC) #4
rmu
https://codereview.tryton.org/41671002/diff/20001/address.py File address.py (right): https://codereview.tryton.org/41671002/diff/20001/address.py#newcode191 address.py:191: ('coutry',) + tuple(clause[1:]), should probably be 'country'
1 week, 4 days ago (2017-11-13 09:34:08 UTC) #5
ced
fix typo
1 week, 4 days ago (2017-11-13 09:57:48 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/41671002
1 week, 4 days ago (2017-11-13 10:07:25 UTC) #7
pokoli
LGTM
1 week, 3 days ago (2017-11-14 11:54:47 UTC) #8
rietveld-bot_tryton.org
1 week, 3 days ago (2017-11-14 23:31:09 UTC) #9
New changeset 897517562490 by Cédric Krier in branch 'default':
Improve distinction of address record name
http://hg.tryton.org/modules/party/rev/897517562490
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922