Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(850)

Issue 41701002: project_revenue: Round revenue amounts in company currency (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks ago by pokoli
Modified:
1 day, 12 hours ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update setup.py #

Total comments: 1

Patch Set 3 : Use single loop for computing revenue #

Total comments: 1

Patch Set 4 : Test outside round #

Total comments: 3

Patch Set 5 : Do not quantize 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -4 lines) Patch
M setup.py View 1 4 chunks +12 lines, -1 line 0 comments Download
A tests/scenario_project_revenue.rst View 1 2 3 4 1 chunk +127 lines, -0 lines 0 comments Download
M tests/test_project_revenue.py View 2 chunks +8 lines, -0 lines 0 comments Download
M work.py View 1 2 3 4 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 16
pokoli
2 weeks ago (2017-12-01 08:47:45 UTC) #1
pokoli
Update setup.py
2 weeks ago (2017-12-01 08:56:57 UTC) #2
ced
https://codereview.tryton.org/41701002/diff/20001/work.py File work.py (right): https://codereview.tryton.org/41701002/diff/20001/work.py#newcode162 work.py:162: revenues[work.id] = work.company.currency.round(revenues[work.id]) Better to have a single loop.
2 weeks ago (2017-12-01 08:58:26 UTC) #3
reviewbot
https://codereview.tryton.org/41701002/diff/20001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/41701002
2 weeks ago (2017-12-01 09:02:06 UTC) #4
pokoli
Use single loop for computing revenue
2 weeks ago (2017-12-01 09:06:23 UTC) #5
reviewbot
https://codereview.tryton.org/41701002/diff/40001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/41701002
2 weeks ago (2017-12-01 09:32:34 UTC) #6
ced
https://codereview.tryton.org/41701002/diff/40001/work.py File work.py (right): https://codereview.tryton.org/41701002/diff/40001/work.py#newcode162 work.py:162: if work.list_price else Decimal(0)) Why keeping if test inside ...
1 week, 6 days ago (2017-12-02 11:27:23 UTC) #7
pokoli
Test outside round
1 week, 1 day ago (2017-12-07 09:38:24 UTC) #8
reviewbot
https://codereview.tryton.org/41701002/diff/60001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/41701002
1 week, 1 day ago (2017-12-07 09:43:22 UTC) #9
ced
https://codereview.tryton.org/41701002/diff/60001/work.py File work.py (right): https://codereview.tryton.org/41701002/diff/60001/work.py#newcode165 work.py:165: Decimal('10') ** -work.currency_digits) Why quantize 0?
5 days, 9 hours ago (2017-12-10 11:47:36 UTC) #10
pokoli
https://codereview.tryton.org/41701002/diff/60001/work.py File work.py (right): https://codereview.tryton.org/41701002/diff/60001/work.py#newcode165 work.py:165: Decimal('10') ** -work.currency_digits) On 2017/12/10 11:47:35, ced wrote: > ...
4 days, 5 hours ago (2017-12-11 15:37:19 UTC) #11
ced
https://codereview.tryton.org/41701002/diff/60001/work.py File work.py (right): https://codereview.tryton.org/41701002/diff/60001/work.py#newcode165 work.py:165: Decimal('10') ** -work.currency_digits) On 2017/12/11 15:37:19, pokoli wrote: > ...
4 days, 5 hours ago (2017-12-11 15:59:34 UTC) #12
pokoli
Do not quantize 0
4 days, 5 hours ago (2017-12-11 16:07:41 UTC) #13
reviewbot
https://codereview.tryton.org/41701002/diff/80001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/41701002
4 days, 5 hours ago (2017-12-11 16:11:33 UTC) #14
ced
LGTM
2 days, 4 hours ago (2017-12-13 17:16:45 UTC) #15
rietveld-bot_tryton.org
1 day, 12 hours ago (2017-12-14 08:49:11 UTC) #16
New changeset 44a5e7b289a0 by Sergi Almacellas Abellana in branch 'default':
Round revenue amounts in company currency
http://hg.tryton.org/modules/project_revenue/rev/44a5e7b289a0


New changeset 628320aeb720 by Sergi Almacellas Abellana in branch 'default':
Add test scenario
http://hg.tryton.org/modules/project_revenue/rev/628320aeb720
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922