Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(23)

Issue 417261003: production: Set unit price to 0 for output move with no quantity (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by bernat-nan
Modified:
1 week ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Set unit_price to 0 if quantity is None #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M production.py View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12
bernat-nan
1 month, 1 week ago (2022-05-27 14:21:23 UTC) #1
reviewbot
Review's title does not follow the convention: '^(?P<repository>[A-Za-z_][\w\.-]+)(?P<version> [0-9.]+)?:' URL: https://codereview.tryton.org/417261003
1 month, 1 week ago (2022-05-27 14:23:18 UTC) #2
pokoli
I think the commit message should be more explanatory: Something like: "AVoid division by zero ...
3 weeks, 6 days ago (2022-06-08 15:04:06 UTC) #3
ced
Agree with pokoli about commit message. I think it should even be: Set unit price ...
1 week, 6 days ago (2022-06-21 21:56:32 UTC) #4
bernat-nan
1 week, 6 days ago (2022-06-22 09:20:00 UTC) #5
reviewbot
Review's title does not follow the convention: '^(?P<repository>[A-Za-z_][\w\.-]+)(?P<version> [0-9.]+)?:' URL: https://codereview.tryton.org/417261003
1 week, 6 days ago (2022-06-22 09:31:42 UTC) #6
pokoli
On 2022/06/22 09:31:42, reviewbot wrote: > Review's title does not follow the convention: > '^(?P<repository>[A-Za-z_][\w\.-]+)(?P<version> ...
1 week, 6 days ago (2022-06-22 11:18:44 UTC) #7
ced
Please re-upload to trigger a new check.
1 week, 5 days ago (2022-06-23 08:43:37 UTC) #8
bernat-nan
1 week, 1 day ago (2022-06-27 14:53:39 UTC) #9
reviewbot
checks OK URL: https://codereview.tryton.org/417261003
1 week, 1 day ago (2022-06-27 15:07:15 UTC) #10
ced
LGTM
1 week ago (2022-06-28 13:24:52 UTC) #11
rietveld-bot_tryton.org
1 week ago (2022-06-28 13:25:50 UTC) #12
New changeset b12afbde5a7a by Bernat in branch 'default':
Set unit price to 0 for output move with no quantity
https://hg.tryton.org/modules/production/rev/b12afbde5a7a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted