production: Set unit price to 0 for output move with no quantity

issue11520

[reviewbot, 2022-05-27 14:23:18]

Review's title does not follow the convention:
'^(?P<repository>[A-Za-z_][\w\.-]+)(?P<version> [0-9.]+)?:'
URL: https://codereview.tryton.org/417261003

[pokoli, 2022-06-08 15:04:06]

I think the commit message should be more explanatory: Something like: "AVoid
division by zero when finishing productions"

[ced, 2022-06-21 21:56:32]

Agree with pokoli about commit message.
I think it should even be: Set unit price to 0 for output move with no quantity.

https://codereview.tryton.org/417261003/diff/421231003/production.py
File production.py (right):

https://codereview.tryton.org/417261003/diff/421231003/production.py#newcode600
production.py:600: quantity = Decimal(str(output.quantity))
Better to test before converting to Decimal nor compute the ratio.

https://codereview.tryton.org/417261003/diff/421231003/production.py#newcode602
production.py:602: continue
I think it will be better to set the unit_price to 0 like set_moves does.

[reviewbot, 2022-06-22 09:31:42]

Review's title does not follow the convention:
'^(?P<repository>[A-Za-z_][\w\.-]+)(?P<version> [0-9.]+)?:'
URL: https://codereview.tryton.org/417261003

[pokoli, 2022-06-22 11:18:44]

On 2022/06/22 09:31:42, reviewbot wrote:
> Review's title does not follow the convention:
> '^(?P<repository>[A-Za-z_][\w\.-]+)(?P<version> [0-9.]+)?:'
> URL: https://codereview.tryton.org/417261003

Review title should start with "production:" as the review should be applied to
this repository.

[ced, 2022-06-23 08:43:37]

Please re-upload to trigger a new check.

[reviewbot, 2022-06-27 15:07:15]

checks OK
URL: https://codereview.tryton.org/417261003

[ced, 2022-06-28 13:24:52]

LGTM

[rietveld-bot_tryton.org, 2022-06-28 13:25:50]

New changeset b12afbde5a7a by Bernat in branch 'default':
Set unit price to 0 for output move with no quantity
https://hg.tryton.org/modules/production/rev/b12afbde5a7a

[rietveld-bot_tryton.org, 2022-07-17 17:48:41]

New changeset 3159886b2f52 by Bernat in branch '6.4':
Set unit price to 0 for output move with no quantity
https://hg.tryton.org/modules/production/rev/3159886b2f52


New changeset 4420222e42fd by Bernat in branch '6.2':
Set unit price to 0 for output move with no quantity
https://hg.tryton.org/modules/production/rev/4420222e42fd


New changeset 932816ac8f53 by Bernat in branch '6.0':
Set unit price to 0 for output move with no quantity
https://hg.tryton.org/modules/production/rev/932816ac8f53