Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 417441003: account: Do not compare debit or credit to None when searching (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 1 day ago by acaubet
Modified:
1 week, 4 days ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Filter operand to None #

Total comments: 1

Patch Set 3 : Fix more searchers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M account.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10
acaubet
2 weeks, 1 day ago (2022-06-20 10:39:05 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/417441003
2 weeks, 1 day ago (2022-06-20 11:01:24 UTC) #2
ced
https://codereview.tryton.org/417441003/diff/419401003/account.py File account.py (right): https://codereview.tryton.org/417441003/diff/419401003/account.py#newcode2017 account.py:2017: if operand and operator_(getattr(a, name), operand)] Should be evaluated ...
2 weeks, 1 day ago (2022-06-20 16:28:20 UTC) #3
acaubet
Filter operand to None
2 weeks ago (2022-06-21 08:44:56 UTC) #4
reviewbot
checks OK URL: https://codereview.tryton.org/417441003
2 weeks ago (2022-06-21 09:05:36 UTC) #5
ced
https://codereview.tryton.org/417441003/diff/411341003/account.py File account.py (right): https://codereview.tryton.org/417441003/diff/411341003/account.py#newcode1969 account.py:1969: if operator_(getattr(a, fname), operand)] The same must be applied ...
1 week, 6 days ago (2022-06-21 21:37:26 UTC) #6
acaubet
Fix more searchers
1 week, 6 days ago (2022-06-22 08:19:04 UTC) #7
reviewbot
checks OK URL: https://codereview.tryton.org/417441003
1 week, 6 days ago (2022-06-22 08:37:57 UTC) #8
ced
LGTM
1 week, 5 days ago (2022-06-23 08:50:03 UTC) #9
rietveld-bot_tryton.org
1 week, 4 days ago (2022-06-24 07:19:35 UTC) #10
New changeset 6d06c13574dd by AdriĆ  Tarroja Caubet in branch 'default':
Do not compare debit or credit to None when searching
https://hg.tryton.org/modules/account/rev/6d06c13574dd
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted