Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79)

Issue 41751002: trytond: Allow to include mixin to pool objects (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by ced
Modified:
1 year, 3 months ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 7

Patch Set 2 : Remove duplicated modules list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -1 line) Patch
M CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M doc/ref/pool.rst View 2 chunks +10 lines, -0 lines 0 comments Download
M trytond/modules/__init__.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/pool.py View 4 chunks +20 lines, -0 lines 0 comments Download
M trytond/tests/__init__.py View 2 chunks +2 lines, -0 lines 0 comments Download
A trytond/tests/mixin.py View 1 chunk +22 lines, -0 lines 0 comments Download
M trytond/tests/test_mixins.py View 2 chunks +34 lines, -1 line 0 comments Download

Messages

Total messages: 11
ced
1 year, 3 months ago (2017-12-28 17:53:59 UTC) #1
reviewbot
https://codereview.tryton.org/41751002/diff/1/trytond/tests/__init__.py#newcode11 trytond/tests/__init__.py:11: F403 'from test import *' used; unable to detect undefined names https://codereview.tryton.org/41751002/diff/1/trytond/tests/__init__.py#newcode12 trytond/tests/__init__.py:12: ...
1 year, 3 months ago (2017-12-28 17:57:46 UTC) #2
pokoli
https://codereview.tryton.org/41751002/diff/1/trytond/modules/__init__.py File trytond/modules/__init__.py (right): https://codereview.tryton.org/41751002/diff/1/trytond/modules/__init__.py#newcode227 trytond/modules/__init__.py:227: modules.append(module) Is not the same as defined on line ...
1 year, 3 months ago (2018-01-11 09:12:51 UTC) #3
ced
https://codereview.tryton.org/41751002/diff/1/trytond/modules/__init__.py File trytond/modules/__init__.py (right): https://codereview.tryton.org/41751002/diff/1/trytond/modules/__init__.py#newcode227 trytond/modules/__init__.py:227: modules.append(module) On 2018/01/11 09:12:50, pokoli wrote: > Is not ...
1 year, 3 months ago (2018-01-11 10:06:08 UTC) #4
ced
Remove duplicated modules list
1 year, 3 months ago (2018-01-11 10:06:30 UTC) #5
pokoli
https://codereview.tryton.org/41751002/diff/1/trytond/tests/test_mixins.py File trytond/tests/test_mixins.py (right): https://codereview.tryton.org/41751002/diff/1/trytond/tests/test_mixins.py#newcode67 trytond/tests/test_mixins.py:67: def test_second_mixin_on_modelview(self): On 2018/01/11 10:06:08, ced wrote: > On ...
1 year, 3 months ago (2018-01-11 10:14:27 UTC) #6
reviewbot
https://codereview.tryton.org/41751002/diff/20001/trytond/tests/__init__.py#newcode11 trytond/tests/__init__.py:11: F403 'from test import *' used; unable to detect undefined names https://codereview.tryton.org/41751002/diff/20001/trytond/tests/__init__.py#newcode12 trytond/tests/__init__.py:12: ...
1 year, 3 months ago (2018-01-11 10:14:30 UTC) #7
ced
https://codereview.tryton.org/41751002/diff/1/trytond/tests/test_mixins.py File trytond/tests/test_mixins.py (right): https://codereview.tryton.org/41751002/diff/1/trytond/tests/test_mixins.py#newcode67 trytond/tests/test_mixins.py:67: def test_second_mixin_on_modelview(self): On 2018/01/11 10:14:27, pokoli wrote: > On ...
1 year, 3 months ago (2018-01-11 10:38:06 UTC) #8
pokoli
https://codereview.tryton.org/41751002/diff/1/trytond/tests/test_mixins.py File trytond/tests/test_mixins.py (right): https://codereview.tryton.org/41751002/diff/1/trytond/tests/test_mixins.py#newcode67 trytond/tests/test_mixins.py:67: def test_second_mixin_on_modelview(self): On 2018/01/11 10:38:06, ced wrote: > On ...
1 year, 3 months ago (2018-01-11 11:29:57 UTC) #9
pokoli
LGTM
1 year, 3 months ago (2018-01-11 11:30:03 UTC) #10
rietveld-bot_tryton.org
1 year, 3 months ago (2018-01-12 14:47:00 UTC) #11
New changeset eada0e901e47 by Cédric Krier in branch 'default':
Allow to include mixin to pool objects
http://hg.tryton.org/trytond/rev/eada0e901e47
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766