Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(367)

Issue 41761002: trytond: Add reset password (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 3 weeks ago by ced
Modified:
2 months, 2 weeks ago
Reviewers:
pokoli, rietveld-bot, jeremy, reviewbot
Visibility:
Public.

Description

The reset password button generates a temporary random password which expires after 1 day and is sent to the email address of the user. The temporary password does not work as soon as a new password has been set. The trytond-admin asks the email address for admin user and has an option to set the admin email and to reset its password. issue7037

Patch Set 1 #

Patch Set 2 : Update to tip #

Patch Set 3 : Add email option #

Patch Set 4 : Fix test for hash set to None and use time tag #

Patch Set 5 : Improve email #

Total comments: 3

Patch Set 6 : Improve text #

Total comments: 2

Patch Set 7 : Hide button and password field if password is not configured #

Total comments: 6

Patch Set 8 : Set reset_timeout under password #

Total comments: 8

Patch Set 9 : Allow to set admin email even when db is not init #

Patch Set 10 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -44 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
M MANIFEST.in View 1 chunk +1 line, -0 lines 0 comments Download
M doc/topics/configuration.rst View 1 2 3 4 5 6 7 8 9 1 chunk +7 lines, -0 lines 0 comments Download
M setup.py View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M trytond/admin.py View 1 2 3 4 5 6 7 8 1 chunk +38 lines, -31 lines 0 comments Download
M trytond/commandline.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/config.py View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M trytond/res/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
A trytond/res/email_reset_password.html View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
M trytond/res/user.py View 1 2 3 4 5 6 7 8 9 10 chunks +117 lines, -9 lines 0 comments Download
M trytond/res/user.xml View 1 chunk +7 lines, -0 lines 0 comments Download
M trytond/res/view/user_form.xml View 1 chunk +7 lines, -2 lines 0 comments Download
M trytond/tests/test_user.py View 1 2 3 3 chunks +79 lines, -1 line 0 comments Download

Messages

Total messages: 34
ced
4 months, 3 weeks ago (2017-12-29 18:09:01 UTC) #1
reviewbot
https://codereview.tryton.org/41761002/diff/1/setup.py#newcode69 setup.py:69: E501 line too long (85 > 79 characters) https://codereview.tryton.org/41761002/diff/1/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to ...
4 months, 3 weeks ago (2017-12-29 18:34:04 UTC) #2
ced
Update to tip
4 months, 1 week ago (2018-01-13 17:52:52 UTC) #3
reviewbot
https://codereview.tryton.org/41761002/diff/20001/setup.py#newcode69 setup.py:69: E501 line too long (85 > 79 characters) https://codereview.tryton.org/41761002/diff/20001/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to ...
4 months, 1 week ago (2018-01-13 18:03:21 UTC) #4
ced
Add email option
4 months, 1 week ago (2018-01-13 18:25:34 UTC) #5
reviewbot
https://codereview.tryton.org/41761002/diff/40001/setup.py#newcode69 setup.py:69: E501 line too long (85 > 79 characters) https://codereview.tryton.org/41761002/diff/40001/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to ...
4 months, 1 week ago (2018-01-13 18:42:17 UTC) #6
ced
Fix test for hash set to None and use time tag
4 months, 1 week ago (2018-01-13 18:52:03 UTC) #7
ced
Improve email
4 months, 1 week ago (2018-01-13 19:06:33 UTC) #8
reviewbot
https://codereview.tryton.org/41761002/diff/80001/setup.py#newcode69 setup.py:69: E501 line too long (85 > 79 characters) https://codereview.tryton.org/41761002/diff/80001/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to ...
4 months, 1 week ago (2018-01-13 19:09:54 UTC) #9
jeremy
https://codereview.tryton.org/41761002/diff/80001/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/41761002/diff/80001/CHANGELOG#newcode1 CHANGELOG:1: * Make trytond-admin to ask for admin email I ...
4 months ago (2018-01-15 10:56:18 UTC) #10
ced
https://codereview.tryton.org/41761002/diff/80001/trytond/res/user.py File trytond/res/user.py (right): https://codereview.tryton.org/41761002/diff/80001/trytond/res/user.py#newcode73 trytond/res/user.py:73: logger.info("Missing email address for '%s' to send", user.login) On ...
4 months ago (2018-01-15 12:12:45 UTC) #11
ced
Improve text
4 months ago (2018-01-15 12:12:50 UTC) #12
reviewbot
https://codereview.tryton.org/41761002/diff/100001/setup.py#newcode69 setup.py:69: E501 line too long (85 > 79 characters) https://codereview.tryton.org/41761002/diff/100001/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to ...
4 months ago (2018-01-15 12:33:33 UTC) #13
pokoli
https://codereview.tryton.org/41761002/diff/100001/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/41761002/diff/100001/trytond/admin.py#newcode78 trytond/admin.py:78: if init[db_name] or options.email is not None: Why making ...
4 months ago (2018-01-16 08:50:18 UTC) #14
ced
https://codereview.tryton.org/41761002/diff/100001/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/41761002/diff/100001/trytond/admin.py#newcode78 trytond/admin.py:78: if init[db_name] or options.email is not None: On 2018/01/16 ...
4 months ago (2018-01-16 09:04:10 UTC) #15
ced
Hide button and password field if password is not configured
3 months, 1 week ago (2018-02-07 00:13:12 UTC) #16
reviewbot
https://codereview.tryton.org/41761002/diff/120001/setup.py#newcode68 setup.py:68: E501 line too long (85 > 79 characters) https://codereview.tryton.org/41761002/diff/120001/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to ...
3 months, 1 week ago (2018-02-07 00:21:21 UTC) #17
pokoli
https://codereview.tryton.org/41761002/diff/120001/trytond/config.py File trytond/config.py (right): https://codereview.tryton.org/41761002/diff/120001/trytond/config.py#newcode68 trytond/config.py:68: self.set('session', 'timeout_reset', 24 * 60 * 60) I think ...
3 months, 1 week ago (2018-02-07 11:04:37 UTC) #18
ced
https://codereview.tryton.org/41761002/diff/120001/trytond/config.py File trytond/config.py (right): https://codereview.tryton.org/41761002/diff/120001/trytond/config.py#newcode68 trytond/config.py:68: self.set('session', 'timeout_reset', 24 * 60 * 60) On 2018/02/07 ...
3 months, 1 week ago (2018-02-07 12:42:27 UTC) #19
ced
Set reset_timeout under password
3 months, 1 week ago (2018-02-07 12:42:31 UTC) #20
reviewbot
https://codereview.tryton.org/41761002/diff/140001/setup.py#newcode68 setup.py:68: E501 line too long (85 > 79 characters) https://codereview.tryton.org/41761002/diff/140001/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to ...
3 months, 1 week ago (2018-02-07 12:47:58 UTC) #21
pokoli
https://codereview.tryton.org/41761002/diff/140001/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/41761002/diff/140001/trytond/admin.py#newcode78 trytond/admin.py:78: if init[db_name] or options.email is not None: I think ...
3 months, 1 week ago (2018-02-12 15:36:50 UTC) #22
ced
https://codereview.tryton.org/41761002/diff/140001/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/41761002/diff/140001/trytond/admin.py#newcode78 trytond/admin.py:78: if init[db_name] or options.email is not None: On 2018/02/12 ...
3 months, 1 week ago (2018-02-12 15:59:03 UTC) #23
pokoli
https://codereview.tryton.org/41761002/diff/140001/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/41761002/diff/140001/trytond/admin.py#newcode78 trytond/admin.py:78: if init[db_name] or options.email is not None: On 2018/02/12 ...
3 months, 1 week ago (2018-02-12 16:22:53 UTC) #24
pokoli
LGTM
3 months, 1 week ago (2018-02-12 16:23:14 UTC) #25
ced
https://codereview.tryton.org/41761002/diff/140001/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/41761002/diff/140001/trytond/admin.py#newcode78 trytond/admin.py:78: if init[db_name] or options.email is not None: On 2018/02/12 ...
3 months, 1 week ago (2018-02-12 16:44:39 UTC) #26
pokoli
https://codereview.tryton.org/41761002/diff/140001/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/41761002/diff/140001/trytond/admin.py#newcode78 trytond/admin.py:78: if init[db_name] or options.email is not None: On 2018/02/12 ...
3 months, 1 week ago (2018-02-12 16:53:58 UTC) #27
ced
https://codereview.tryton.org/41761002/diff/140001/trytond/admin.py File trytond/admin.py (right): https://codereview.tryton.org/41761002/diff/140001/trytond/admin.py#newcode78 trytond/admin.py:78: if init[db_name] or options.email is not None: On 2018/02/12 ...
3 months, 1 week ago (2018-02-12 22:25:03 UTC) #28
ced
Allow to set admin email even when db is not init
3 months, 1 week ago (2018-02-12 22:30:04 UTC) #29
reviewbot
https://codereview.tryton.org/41761002/diff/160001/setup.py#newcode68 setup.py:68: E501 line too long (85 > 79 characters) https://codereview.tryton.org/41761002/diff/160001/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to ...
3 months, 1 week ago (2018-02-12 22:49:03 UTC) #30
pokoli
LGTM
3 months ago (2018-02-13 09:35:39 UTC) #31
ced
Update to tip
2 months, 3 weeks ago (2018-02-23 17:38:12 UTC) #32
reviewbot
https://codereview.tryton.org/41761002/diff/180001/setup.py#newcode68 setup.py:68: E501 line too long (85 > 79 characters) https://codereview.tryton.org/41761002/diff/180001/trytond/admin.py#newcode45 trytond/admin.py:45: E712 comparison to ...
2 months, 3 weeks ago (2018-02-23 17:49:59 UTC) #33
rietveld-bot_tryton.org
2 months, 3 weeks ago (2018-02-23 18:13:28 UTC) #34
New changeset 5ade83a210f0 by Cédric Krier in branch 'default':
Add reset password
http://hg.tryton.org/trytond/rev/5ade83a210f0
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922