Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(205)

Issue 41841002: sao: Add the context model name in the screen context (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by pokoli
Modified:
6 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rename include into add #

Patch Set 3 : Update to issue7157 #

Total comments: 2

Patch Set 4 : Add spaces #

Total comments: 1

Patch Set 5 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/screen.js View 1 2 3 4 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 20
pokoli
7 months ago (2018-02-15 16:38:13 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/41841002
7 months ago (2018-02-15 16:52:26 UTC) #2
ced
This is not the same as for tryton. I think Screen.context should become a function ...
7 months ago (2018-02-20 23:58:06 UTC) #3
pokoli
On 2018/02/20 23:58:06, ced wrote: > This is not the same as for tryton. > ...
6 months, 4 weeks ago (2018-02-21 13:02:37 UTC) #4
pokoli
Rename include into add
6 months, 4 weeks ago (2018-02-21 13:05:15 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/41841002
6 months, 4 weeks ago (2018-02-21 13:16:47 UTC) #6
ced
On 2018/02/21 13:02:37, pokoli wrote: > On 2018/02/20 23:58:06, ced wrote: > > This is ...
6 months, 4 weeks ago (2018-02-21 13:28:42 UTC) #7
pokoli
On 2018/02/21 13:28:42, ced wrote: > On 2018/02/21 13:02:37, pokoli wrote: > > On 2018/02/20 ...
6 months, 4 weeks ago (2018-02-21 14:29:31 UTC) #8
ced
On 2018/02/21 14:29:31, pokoli wrote: > On 2018/02/21 13:28:42, ced wrote: > > On 2018/02/21 ...
6 months, 4 weeks ago (2018-02-21 14:42:04 UTC) #9
pokoli
On 2018/02/21 14:42:04, ced wrote: > On 2018/02/21 14:29:31, pokoli wrote: > > On 2018/02/21 ...
6 months, 4 weeks ago (2018-02-21 14:46:40 UTC) #10
pokoli
Update to issue7157
6 months, 4 weeks ago (2018-02-21 15:46:15 UTC) #11
ced
Title should be: "Add…" https://codereview.tryton.org/41841002/diff/40001/src/screen.js File src/screen.js (right): https://codereview.tryton.org/41841002/diff/40001/src/screen.js#newcode1754 src/screen.js:1754: if (this.context_screen){ space between ) ...
6 months, 4 weeks ago (2018-02-21 15:53:53 UTC) #12
pokoli
Add spaces
6 months, 4 weeks ago (2018-02-21 15:55:52 UTC) #13
pokoli
https://codereview.tryton.org/41841002/diff/40001/src/screen.js File src/screen.js (right): https://codereview.tryton.org/41841002/diff/40001/src/screen.js#newcode1754 src/screen.js:1754: if (this.context_screen){ On 2018/02/21 15:53:53, ced wrote: > space ...
6 months, 4 weeks ago (2018-02-21 15:56:17 UTC) #14
ced
https://codereview.tryton.org/41841002/diff/60001/src/screen.js File src/screen.js (right): https://codereview.tryton.org/41841002/diff/60001/src/screen.js#newcode1754 src/screen.js:1754: if ( this.context_screen ){ no space inside () but ...
6 months, 4 weeks ago (2018-02-21 16:04:01 UTC) #15
reviewbot
patch is not applicable URL: https://codereview.tryton.org/41841002
6 months, 4 weeks ago (2018-02-21 16:17:07 UTC) #16
pokoli
Update to tip
6 months, 1 week ago (2018-03-13 10:04:28 UTC) #17
reviewbot
flake8 OK URL: https://codereview.tryton.org/41841002
6 months, 1 week ago (2018-03-13 10:16:58 UTC) #18
ced
LGTM
6 months, 1 week ago (2018-03-15 09:53:19 UTC) #19
rietveld-bot_tryton.org
6 months ago (2018-03-22 10:25:20 UTC) #20
New changeset 05659b9bc5b1 by Sergi Almacellas Abellana in branch 'default':
Add the context model name in the screen context
http://hg.tryton.org/sao/rev/05659b9bc5b1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766