Issue 419121003: trytond: Ignore write and delete rule domains if they are the same as the read domain

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 419121003: trytond: Ignore write and delete rule domains if they are the same as the read domain

Can't Edit
Can't Publish+Mail
Start Review

Created:
2 weeks ago by ced

Modified:
2 weeks ago

Reviewers:
pokoli, reviewbot

Visibility:
Public.

More Reviews

Description

trytond: Ignore write and delete rule domains if they are the same as the read domain issue11480

Patch Set 2 : Add comment #

Created: 2 weeks ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	trytond/model/modelsql.py	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

pokoli

https://codereview.tryton.org/419121003/diff/437081003/trytond/model/modelsql.py File trytond/model/modelsql.py (right): https://codereview.tryton.org/419121003/diff/437081003/trytond/model/modelsql.py#newcode793 trytond/model/modelsql.py:793: if rule_domain and rule_domain != domain: I think it's ...

2 weeks ago (2022-05-13 08:05:24 UTC) #3

LGTM

Expand All Messages | Collapse All Messages