Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37)

Issue 419231003: sale_stock_quantity: Apply check_stock_quantity per warehouse line (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 1 week ago by mrichez
Modified:
1 month ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

issue11531 COLLABORATOR=cedric.krier@b2ck.com

Patch Set 1 #

Total comments: 1

Patch Set 2 : Do test inside check_stock_quantity #

Total comments: 4

Patch Set 3 : Apply remarks #

Total comments: 6

Patch Set 4 : Apply Ced's remrks #

Total comments: 6

Patch Set 5 : Apply remarks #

Total comments: 14

Patch Set 6 : Apply remarks #

Total comments: 6

Patch Set 7 : Apply Ced's remarks #

Total comments: 2

Patch Set 8 : Apply remark and update to tip #

Total comments: 4

Patch Set 9 : Apply remark and update to tip #

Total comments: 1

Patch Set 10 : Compute quantity per warehouse #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -44 lines) Patch
M sale.py View 1 2 3 4 5 6 7 8 9 4 chunks +60 lines, -44 lines 0 comments Download

Messages

Total messages: 38
mrichez
8 months, 1 week ago (2022-06-01 08:43:01 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/419231003
8 months, 1 week ago (2022-06-01 08:56:01 UTC) #2
pokoli
https://codereview.tryton.org/419231003/diff/439161003/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/439161003/sale.py#newcode38 sale.py:38: if sale.warehouse: I think it's better to do the ...
8 months, 1 week ago (2022-06-01 09:42:50 UTC) #3
mrichez
8 months, 1 week ago (2022-06-01 09:51:05 UTC) #4
reviewbot
checks OK URL: https://codereview.tryton.org/419231003
8 months, 1 week ago (2022-06-01 09:54:09 UTC) #5
ced
https://codereview.tryton.org/419231003/diff/435231003/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/435231003/sale.py#newcode87 sale.py:87: def filter_line(line): I think it is here that the ...
8 months, 1 week ago (2022-06-01 21:22:02 UTC) #6
mrichez
https://codereview.tryton.org/419231003/diff/435231003/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/435231003/sale.py#newcode87 sale.py:87: def filter_line(line): On 2022/06/01 21:22:02, ced wrote: > I ...
8 months, 1 week ago (2022-06-02 07:47:02 UTC) #7
mrichez
8 months, 1 week ago (2022-06-02 07:47:05 UTC) #8
reviewbot
checks OK URL: https://codereview.tryton.org/419231003
8 months, 1 week ago (2022-06-02 08:04:29 UTC) #9
ced
https://codereview.tryton.org/419231003/diff/411221005/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/411221005/sale.py#newcode142 sale.py:142: quantities = {p: p.forecast_quantity for p in products} quantities ...
8 months, 1 week ago (2022-06-02 09:26:13 UTC) #10
mrichez
https://codereview.tryton.org/419231003/diff/411221005/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/411221005/sale.py#newcode142 sale.py:142: quantities = {p: p.forecast_quantity for p in products} On ...
8 months, 1 week ago (2022-06-07 11:17:29 UTC) #11
mrichez
8 months, 1 week ago (2022-06-07 11:17:45 UTC) #12
mrichez
8 months, 1 week ago (2022-06-07 11:19:08 UTC) #13
reviewbot
checks OK URL: https://codereview.tryton.org/419231003
8 months, 1 week ago (2022-06-07 11:22:53 UTC) #14
ced
https://codereview.tryton.org/419231003/diff/427331003/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/427331003/sale.py#newcode143 sale.py:143: quantities[warehouse.id] = { could be done outside the with ...
8 months ago (2022-06-07 21:29:22 UTC) #15
mrichez
https://codereview.tryton.org/419231003/diff/427331003/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/427331003/sale.py#newcode143 sale.py:143: quantities[warehouse.id] = { On 2022/06/07 21:29:22, ced wrote: > ...
8 months ago (2022-06-08 07:44:24 UTC) #16
mrichez
8 months ago (2022-06-08 07:44:46 UTC) #17
reviewbot
checks OK URL: https://codereview.tryton.org/419231003
8 months ago (2022-06-08 07:52:52 UTC) #18
ced
https://codereview.tryton.org/419231003/diff/435301003/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/435301003/sale.py#newcode134 sale.py:134: for warehouse, lines in groupby(lines, key=lambda l: l.warehouse): you ...
7 months, 3 weeks ago (2022-06-17 09:39:51 UTC) #19
mrichez
https://codereview.tryton.org/419231003/diff/435301003/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/435301003/sale.py#newcode134 sale.py:134: for warehouse, lines in groupby(lines, key=lambda l: l.warehouse): On ...
7 months, 3 weeks ago (2022-06-20 09:37:45 UTC) #20
mrichez
7 months, 3 weeks ago (2022-06-20 09:37:59 UTC) #21
reviewbot
checks OK URL: https://codereview.tryton.org/419231003
7 months, 3 weeks ago (2022-06-20 10:02:41 UTC) #22
ced
https://codereview.tryton.org/419231003/diff/419391003/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/419391003/sale.py#newcode104 sale.py:104: product_ids = [p.id for p in products] better to ...
7 months, 3 weeks ago (2022-06-21 21:46:01 UTC) #23
mrichez
https://codereview.tryton.org/419231003/diff/419391003/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/419391003/sale.py#newcode104 sale.py:104: product_ids = [p.id for p in products] On 2022/06/21 ...
7 months, 3 weeks ago (2022-06-22 10:51:20 UTC) #24
mrichez
7 months, 3 weeks ago (2022-06-22 10:51:32 UTC) #25
reviewbot
checks OK URL: https://codereview.tryton.org/419231003
7 months, 3 weeks ago (2022-06-22 11:11:05 UTC) #26
ced
https://codereview.tryton.org/419231003/diff/441211003/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/441211003/sale.py#newcode95 sale.py:95: def get_delta(date): products must be passed now as it ...
6 months, 3 weeks ago (2022-07-18 20:11:12 UTC) #27
mrichez
https://codereview.tryton.org/419231003/diff/441211003/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/441211003/sale.py#newcode95 sale.py:95: def get_delta(date): On 2022/07/18 20:11:12, ced wrote: > products ...
6 months, 3 weeks ago (2022-07-19 13:21:24 UTC) #28
mrichez
6 months, 3 weeks ago (2022-07-19 13:22:00 UTC) #29
reviewbot
checks OK URL: https://codereview.tryton.org/419231003
6 months, 3 weeks ago (2022-07-19 13:44:00 UTC) #30
ced
I think the title should be changed to reflect the actual change. https://codereview.tryton.org/419231003/diff/419521003/sale.py File sale.py ...
5 months ago (2022-09-08 06:25:24 UTC) #31
mrichez
https://codereview.tryton.org/419231003/diff/419521003/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/419521003/sale.py#newcode138 sale.py:138: for warehouse, w_lines in groupby(lines, keyfunc): On 2022/09/08 06:25:24, ...
5 months ago (2022-09-12 09:37:23 UTC) #32
mrichez
5 months ago (2022-09-12 09:38:42 UTC) #33
reviewbot
checks OK URL: https://codereview.tryton.org/419231003
5 months ago (2022-09-12 09:44:01 UTC) #34
ced
https://codereview.tryton.org/419231003/diff/419521003/sale.py File sale.py (right): https://codereview.tryton.org/419231003/diff/419521003/sale.py#newcode138 sale.py:138: for warehouse, w_lines in groupby(lines, keyfunc): On 2022/09/08 06:25:24, ...
4 months, 4 weeks ago (2022-09-13 10:20:29 UTC) #35
ced
4 months, 4 weeks ago (2022-09-13 10:21:32 UTC) #36
reviewbot
checks OK URL: https://codereview.tryton.org/419231003
4 months, 4 weeks ago (2022-09-13 10:38:04 UTC) #37
mrichez
1 month ago (2023-01-09 15:16:34 UTC) #38

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted