tryton-env: Ensure unique taxes when applying tax rule

tryton-env: Ensure unique taxes when applying tax rule

Since issue10841 the taxes must be unique so the tax rule application must
result on unique taxes.

issue11230

[reviewbot, 2022-06-16 08:31:04]

checks OK
URL: https://codereview.tryton.org/419361003

[raimonesteve, 2022-06-21 10:41:07]

On 2022/06/16 08:31:04, reviewbot wrote:
> checks OK
> URL: https://codereview.tryton.org/419361003

Missing modules?

sale_subscription/subscription.py:956:            line.taxes = taxes
sale_shipment_cost/stock.py:200:        invoice_line.taxes = taxes
project_invoice/project.py:599:        invoice_line.taxes = taxes

[ced, 2022-06-21 10:48:38]

On 2022/06/21 10:41:07, raimonesteve wrote:
> On 2022/06/16 08:31:04, reviewbot wrote:
> > checks OK
> > URL: https://codereview.tryton.org/419361003
> 
> Missing modules?
> 
> sale_subscription/subscription.py:956:            line.taxes = taxes
> sale_shipment_cost/stock.py:200:        invoice_line.taxes = taxes
> project_invoice/project.py:599:        invoice_line.taxes = taxes

Please if you do not take the time to make sentence that people can understand,
do not post.

[raimonesteve, 2022-06-21 10:52:19]

On 2022/06/21 10:48:38, ced wrote:
> On 2022/06/21 10:41:07, raimonesteve wrote:
> > On 2022/06/16 08:31:04, reviewbot wrote:
> > > checks OK
> > > URL: https://codereview.tryton.org/419361003
> > 
> > Missing modules?
> > 
> > sale_subscription/subscription.py:956:            line.taxes = taxes
> > sale_shipment_cost/stock.py:200:        invoice_line.taxes = taxes
> > project_invoice/project.py:599:        invoice_line.taxes = taxes
> 
> Please if you do not take the time to make sentence that people can
understand,
> do not post.

you publish a review that add 4 modules: account_invoice, sale, purchase and
stock_consignment. But there are other modules that has rules taxes, for
example, sale_subscription, sale_shipment_cost and project_invoice. Why not add
those modules in the review?

[ced, 2022-06-21 10:57:45]

On 2022/06/21 10:52:19, raimonesteve wrote:
> On 2022/06/21 10:48:38, ced wrote:
> > On 2022/06/21 10:41:07, raimonesteve wrote:
> > > On 2022/06/16 08:31:04, reviewbot wrote:
> > > > checks OK
> > > > URL: https://codereview.tryton.org/419361003
> > > 
> > > Missing modules?
> > > 
> > > sale_subscription/subscription.py:956:            line.taxes = taxes
> > > sale_shipment_cost/stock.py:200:        invoice_line.taxes = taxes
> > > project_invoice/project.py:599:        invoice_line.taxes = taxes
> > 
> > Please if you do not take the time to make sentence that people can
> understand,
> > do not post.
> 
> you publish a review that add 4 modules: account_invoice, sale, purchase and
> stock_consignment. But there are other modules that has rules taxes, for
> example, sale_subscription, sale_shipment_cost and project_invoice. Why not
add
> those modules in the review?

They do not use taxes.

[raimonesteve, 2022-06-21 12:08:20]

LGTM

[reviewbot, 2022-06-28 22:48:21]

checks OK
URL: https://codereview.tryton.org/419361003

[rietveld-bot_tryton.org, 2022-07-16 22:03:12]

New changeset 33d9a972aec9 by Cédric Krier in branch 'default':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/account_invoice/rev/33d9a972aec9

[rietveld-bot_tryton.org, 2022-07-16 22:03:32]

New changeset 60fe20c8a431 by Cédric Krier in branch 'default':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/purchase/rev/60fe20c8a431

[rietveld-bot_tryton.org, 2022-07-16 22:03:42]

New changeset 453100758df4 by Cédric Krier in branch 'default':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/sale/rev/453100758df4

[rietveld-bot_tryton.org, 2022-07-16 22:03:59]

New changeset 4b2d18f8cd61 by Cédric Krier in branch 'default':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/stock_consignment/rev/4b2d18f8cd61

[rietveld-bot_tryton.org, 2022-07-16 22:04:15]

New changeset b31d8703761f by Cédric Krier in branch 'default':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/web_shop/rev/b31d8703761f

[rietveld-bot_tryton.org, 2022-07-16 22:04:37]

New changeset 00eddfa2d25f by Cédric Krier in branch 'default':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/tryton-env/rev/00eddfa2d25f

[rietveld-bot_tryton.org, 2022-07-17 17:48:19]

New changeset 8fffa57bd1f8 by Cédric Krier in branch '6.4':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/account_invoice/rev/8fffa57bd1f8


New changeset 32b96d770e06 by Cédric Krier in branch '6.2':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/account_invoice/rev/32b96d770e06

[rietveld-bot_tryton.org, 2022-07-17 17:48:54]

New changeset 27a1a34ce6ec by Cédric Krier in branch '6.4':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/purchase/rev/27a1a34ce6ec


New changeset ef7519ebd9f0 by Cédric Krier in branch '6.2':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/purchase/rev/ef7519ebd9f0

[rietveld-bot_tryton.org, 2022-07-17 17:49:10]

New changeset d50f5ad354e8 by Cédric Krier in branch '6.4':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/sale/rev/d50f5ad354e8


New changeset c7e8c1dfef72 by Cédric Krier in branch '6.2':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/sale/rev/c7e8c1dfef72

[rietveld-bot_tryton.org, 2022-07-17 17:49:34]

New changeset 35b0bb152ef0 by Cédric Krier in branch '6.4':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/stock_consignment/rev/35b0bb152ef0


New changeset 855d89552bd6 by Cédric Krier in branch '6.2':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/stock_consignment/rev/855d89552bd6

[rietveld-bot_tryton.org, 2022-07-17 17:49:39]

New changeset bba0c5062c7d by Cédric Krier in branch '6.4':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/web_shop/rev/bba0c5062c7d


New changeset d58df28746b4 by Cédric Krier in branch '6.2':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/web_shop/rev/d58df28746b4