Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 419361003: tryton-env: Ensure unique taxes when applying tax rule (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 4 weeks ago by ced
Modified:
3 weeks, 6 days ago
Reviewers:
raimonesteve, rietveld-bot, reviewbot
Visibility:
Public.

Description

tryton-env: Ensure unique taxes when applying tax rule Since issue10841 the taxes must be unique so the tax rule application must result on unique taxes. issue11230

Patch Set 1 #

Patch Set 2 : Update web_shop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M modules/account_invoice/invoice.py View 4 chunks +12 lines, -12 lines 0 comments Download
M modules/purchase/purchase.py View 1 chunk +5 lines, -5 lines 0 comments Download
M modules/sale/sale.py View 1 chunk +5 lines, -5 lines 0 comments Download
M modules/stock_consignment/stock.py View 2 chunks +8 lines, -8 lines 0 comments Download
M modules/web_shop/web.py View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 20
ced
1 month, 4 weeks ago (2022-06-16 07:58:58 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/419361003
1 month, 4 weeks ago (2022-06-16 08:31:04 UTC) #2
raimonesteve
On 2022/06/16 08:31:04, reviewbot wrote: > checks OK > URL: https://codereview.tryton.org/419361003 Missing modules? sale_subscription/subscription.py:956: line.taxes ...
1 month, 3 weeks ago (2022-06-21 10:41:07 UTC) #3
ced
On 2022/06/21 10:41:07, raimonesteve wrote: > On 2022/06/16 08:31:04, reviewbot wrote: > > checks OK ...
1 month, 3 weeks ago (2022-06-21 10:48:38 UTC) #4
raimonesteve
On 2022/06/21 10:48:38, ced wrote: > On 2022/06/21 10:41:07, raimonesteve wrote: > > On 2022/06/16 ...
1 month, 3 weeks ago (2022-06-21 10:52:19 UTC) #5
ced
On 2022/06/21 10:52:19, raimonesteve wrote: > On 2022/06/21 10:48:38, ced wrote: > > On 2022/06/21 ...
1 month, 3 weeks ago (2022-06-21 10:57:45 UTC) #6
raimonesteve
LGTM
1 month, 3 weeks ago (2022-06-21 12:08:20 UTC) #7
ced
1 month, 2 weeks ago (2022-06-28 22:14:55 UTC) #8
reviewbot
checks OK URL: https://codereview.tryton.org/419361003
1 month, 2 weeks ago (2022-06-28 22:48:21 UTC) #9
rietveld-bot_tryton.org
New changeset 33d9a972aec9 by Cédric Krier in branch 'default': Ensure unique taxes when applying tax ...
4 weeks ago (2022-07-16 22:03:12 UTC) #10
rietveld-bot_tryton.org
New changeset 60fe20c8a431 by Cédric Krier in branch 'default': Ensure unique taxes when applying tax ...
4 weeks ago (2022-07-16 22:03:32 UTC) #11
rietveld-bot_tryton.org
New changeset 453100758df4 by Cédric Krier in branch 'default': Ensure unique taxes when applying tax ...
4 weeks ago (2022-07-16 22:03:42 UTC) #12
rietveld-bot_tryton.org
New changeset 4b2d18f8cd61 by Cédric Krier in branch 'default': Ensure unique taxes when applying tax ...
4 weeks ago (2022-07-16 22:03:59 UTC) #13
rietveld-bot_tryton.org
New changeset b31d8703761f by Cédric Krier in branch 'default': Ensure unique taxes when applying tax ...
4 weeks ago (2022-07-16 22:04:15 UTC) #14
rietveld-bot_tryton.org
New changeset 00eddfa2d25f by Cédric Krier in branch 'default': Ensure unique taxes when applying tax ...
4 weeks ago (2022-07-16 22:04:37 UTC) #15
rietveld-bot_tryton.org
New changeset 8fffa57bd1f8 by Cédric Krier in branch '6.4': Ensure unique taxes when applying tax ...
3 weeks, 6 days ago (2022-07-17 17:48:19 UTC) #16
rietveld-bot_tryton.org
New changeset 27a1a34ce6ec by Cédric Krier in branch '6.4': Ensure unique taxes when applying tax ...
3 weeks, 6 days ago (2022-07-17 17:48:54 UTC) #17
rietveld-bot_tryton.org
New changeset d50f5ad354e8 by Cédric Krier in branch '6.4': Ensure unique taxes when applying tax ...
3 weeks, 6 days ago (2022-07-17 17:49:10 UTC) #18
rietveld-bot_tryton.org
New changeset 35b0bb152ef0 by Cédric Krier in branch '6.4': Ensure unique taxes when applying tax ...
3 weeks, 6 days ago (2022-07-17 17:49:34 UTC) #19
rietveld-bot_tryton.org
3 weeks, 6 days ago (2022-07-17 17:49:39 UTC) #20
New changeset bba0c5062c7d by Cédric Krier in branch '6.4':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/web_shop/rev/bba0c5062c7d


New changeset d58df28746b4 by Cédric Krier in branch '6.2':
Ensure unique taxes when applying tax rule
https://hg.tryton.org/modules/web_shop/rev/d58df28746b4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted