Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 419361003: tryton-env: Ensure unique taxes when applying tax rule

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 5 days ago by ced
Modified:
6 days, 20 hours ago
Reviewers:
raimonesteve, reviewbot
Visibility:
Public.

Description

tryton-env: Ensure unique taxes when applying tax rule Since issue10841 the taxes must be unique so the tax rule application must result on unique taxes. issue11230

Patch Set 1 #

Patch Set 2 : Update web_shop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M modules/account_invoice/invoice.py View 4 chunks +12 lines, -12 lines 0 comments Download
M modules/purchase/purchase.py View 1 chunk +5 lines, -5 lines 0 comments Download
M modules/sale/sale.py View 1 chunk +5 lines, -5 lines 0 comments Download
M modules/stock_consignment/stock.py View 2 chunks +8 lines, -8 lines 0 comments Download
M modules/web_shop/web.py View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9
ced
2 weeks, 5 days ago (2022-06-16 07:58:58 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/419361003
2 weeks, 5 days ago (2022-06-16 08:31:04 UTC) #2
raimonesteve
On 2022/06/16 08:31:04, reviewbot wrote: > checks OK > URL: https://codereview.tryton.org/419361003 Missing modules? sale_subscription/subscription.py:956: line.taxes ...
2 weeks ago (2022-06-21 10:41:07 UTC) #3
ced
On 2022/06/21 10:41:07, raimonesteve wrote: > On 2022/06/16 08:31:04, reviewbot wrote: > > checks OK ...
2 weeks ago (2022-06-21 10:48:38 UTC) #4
raimonesteve
On 2022/06/21 10:48:38, ced wrote: > On 2022/06/21 10:41:07, raimonesteve wrote: > > On 2022/06/16 ...
2 weeks ago (2022-06-21 10:52:19 UTC) #5
ced
On 2022/06/21 10:52:19, raimonesteve wrote: > On 2022/06/21 10:48:38, ced wrote: > > On 2022/06/21 ...
2 weeks ago (2022-06-21 10:57:45 UTC) #6
raimonesteve
LGTM
2 weeks ago (2022-06-21 12:08:20 UTC) #7
ced
6 days, 20 hours ago (2022-06-28 22:14:55 UTC) #8
reviewbot
6 days, 20 hours ago (2022-06-28 22:48:21 UTC) #9
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted