Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(124)

Issue 41941002: account_invoice: Remove tax code from invoice tax (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by ced
Modified:
11 months, 4 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused code in scenario #

Patch Set 3 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -125 lines) Patch
M invoice.py View 1 2 11 chunks +25 lines, -76 lines 0 comments Download
M tests/scenario_invoice.rst View 1 2 4 chunks +18 lines, -14 lines 0 comments Download
M tests/scenario_invoice_alternate_currency.rst View 1 3 chunks +3 lines, -7 lines 0 comments Download
M tests/scenario_invoice_supplier.rst View 1 2 3 chunks +14 lines, -10 lines 0 comments Download
M view/invoice_tax_form.xml View 1 chunk +4 lines, -14 lines 0 comments Download
M view/invoice_tax_tree_sequence.xml View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9
ced
1 year ago (2018-03-16 16:37:57 UTC) #1
reviewbot
https://codereview.tryton.org/41941002/diff/1/invoice.py#newcode630 invoice.py:630: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/41941002
1 year ago (2018-03-16 16:46:08 UTC) #2
pokoli
https://codereview.tryton.org/41941002/diff/1/tests/scenario_invoice_alternate_currency.rst File tests/scenario_invoice_alternate_currency.rst (right): https://codereview.tryton.org/41941002/diff/1/tests/scenario_invoice_alternate_currency.rst#newcode63 tests/scenario_invoice_alternate_currency.rst:63: >>> invoice_base_code = create_tax_code(tax, 'base', 'invoice') I don't see ...
1 year ago (2018-03-19 13:11:46 UTC) #3
ced
https://codereview.tryton.org/41941002/diff/1/tests/scenario_invoice_alternate_currency.rst File tests/scenario_invoice_alternate_currency.rst (right): https://codereview.tryton.org/41941002/diff/1/tests/scenario_invoice_alternate_currency.rst#newcode63 tests/scenario_invoice_alternate_currency.rst:63: >>> invoice_base_code = create_tax_code(tax, 'base', 'invoice') On 2018/03/19 13:11:46, ...
1 year ago (2018-03-19 13:28:12 UTC) #4
ced
Remove unused code in scenario
1 year ago (2018-03-19 13:28:13 UTC) #5
reviewbot
https://codereview.tryton.org/41941002/diff/20001/invoice.py#newcode630 invoice.py:630: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/41941002
1 year ago (2018-03-19 13:44:45 UTC) #6
ced
Update to tip
12 months ago (2018-03-24 16:36:22 UTC) #7
reviewbot
https://codereview.tryton.org/41941002/diff/40001/invoice.py#newcode649 invoice.py:649: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/41941002
12 months ago (2018-03-24 16:50:05 UTC) #8
rietveld-bot_tryton.org
11 months, 4 weeks ago (2018-03-25 21:34:48 UTC) #9
New changeset f45f42b6b358 by Cédric Krier in branch 'default':
Remove tax code from invoice tax
http://hg.tryton.org/modules/account_invoice/rev/f45f42b6b358
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766