Issue 421151003: tryton-env: Correctly complete after opening OR-ed parenthesis

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 421151003: tryton-env: Correctly complete after opening OR-ed parenthesis (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
2 weeks, 1 day ago by ced

Modified:
1 week ago

Reviewers:
rietveld-bot, reviewbot

Visibility:
Public.

More Reviews

Description

tryton-env: Correctly complete after opening OR-ed parenthesis The nested call to replace_ending_clause must be pushed in the result instead of concatenated because the clause can be OR-ed. And pslice must remove depth from the length of the sting. issue11477

Patch Set 1 #

Patch Set 2 : Update with issue11472 #

Created: 1 week, 2 days ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -17 lines)			Patch
M	sao/src/common.js	View	1	5 chunks	+15 lines, -17 lines	0 comments	Download
M	sao/tests/sao.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tryton/tryton/tests/test_common_domain_parser.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

rietveld-bot_tryton.org

New changeset b4f0e27a3198 by Cédric Krier in branch 'default': Correctly complete after opening OR-ed parenthesis ...

1 week ago (2022-05-19 19:58:49 UTC) #5

rietveld-bot_tryton.org

New changeset 30db515c84d6 by Cédric Krier in branch 'default': Add test for completion after opening ...

1 week ago (2022-05-19 19:58:55 UTC) #6

rietveld-bot_tryton.org

1 week ago (2022-05-19 19:59:04 UTC) #7

New changeset ef83fc5b3638 by Cédric Krier in branch 'default':
Correctly complete after opening OR-ed parenthesis
https://hg.tryton.org/tryton-env/rev/ef83fc5b3638

Expand All Messages | Collapse All Messages