Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 421151003: tryton-env: Correctly complete after opening OR-ed parenthesis (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 1 day ago by ced
Modified:
1 week ago
Reviewers:
rietveld-bot, reviewbot
Visibility:
Public.

Description

tryton-env: Correctly complete after opening OR-ed parenthesis The nested call to replace_ending_clause must be pushed in the result instead of concatenated because the clause can be OR-ed. And pslice must remove depth from the length of the sting. issue11477

Patch Set 1 #

Patch Set 2 : Update with issue11472 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M sao/src/common.js View 1 5 chunks +15 lines, -17 lines 0 comments Download
M sao/tests/sao.js View 1 chunk +1 line, -0 lines 0 comments Download
M tryton/tryton/tests/test_common_domain_parser.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7
ced
2 weeks, 1 day ago (2022-05-11 23:15:38 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/421151003
2 weeks, 1 day ago (2022-05-11 23:20:50 UTC) #2
ced
1 week, 2 days ago (2022-05-17 15:41:15 UTC) #3
reviewbot
checks OK URL: https://codereview.tryton.org/421151003
1 week, 2 days ago (2022-05-17 15:48:35 UTC) #4
rietveld-bot_tryton.org
New changeset b4f0e27a3198 by Cédric Krier in branch 'default': Correctly complete after opening OR-ed parenthesis ...
1 week ago (2022-05-19 19:58:49 UTC) #5
rietveld-bot_tryton.org
New changeset 30db515c84d6 by Cédric Krier in branch 'default': Add test for completion after opening ...
1 week ago (2022-05-19 19:58:55 UTC) #6
rietveld-bot_tryton.org
1 week ago (2022-05-19 19:59:04 UTC) #7
New changeset ef83fc5b3638 by Cédric Krier in branch 'default':
Correctly complete after opening OR-ed parenthesis
https://hg.tryton.org/tryton-env/rev/ef83fc5b3638
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted