Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 42211002: stock_forecast: Use multivalue api to access product multivalue fields

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 3 weeks ago by pokoli
Modified:
4 months, 1 week ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use single method to get all multivalue values #

Total comments: 1

Patch Set 3 : Compute unit price with move get_product_multivalue #

Total comments: 2

Patch Set 4 : Set unit price to the move #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M forecast.py View 1 2 3 2 chunks +5 lines, -6 lines 1 comment Download

Messages

Total messages: 12
pokoli
5 months, 3 weeks ago (2018-05-28 16:03:00 UTC) #1
reviewbot
https://codereview.tryton.org/42211002/diff/1/forecast.py#newcode429 forecast.py:429: E731 do not assign a lambda expression, use a def URL: https://codereview.tryton.org/42211002
5 months, 3 weeks ago (2018-05-28 16:20:52 UTC) #2
pokoli
Use single method to get all multivalue values
5 months, 1 week ago (2018-06-11 12:15:11 UTC) #3
reviewbot
https://codereview.tryton.org/42211002/diff/20001/forecast.py#newcode429 forecast.py:429: E731 do not assign a lambda expression, use a def URL: https://codereview.tryton.org/42211002
5 months, 1 week ago (2018-06-11 12:28:33 UTC) #4
ced
https://codereview.tryton.org/42211002/diff/20001/forecast.py File forecast.py (right): https://codereview.tryton.org/42211002/diff/20001/forecast.py#newcode512 forecast.py:512: move.unit_price = unit_price I think the unit_price could be ...
4 months, 4 weeks ago (2018-06-22 09:31:10 UTC) #5
pokoli
Compute unit price with move get_product_multivalue
4 months, 4 weeks ago (2018-06-22 11:56:21 UTC) #6
reviewbot
https://codereview.tryton.org/42211002/diff/40001/forecast.py#newcode429 forecast.py:429: E731 do not assign a lambda expression, use a def URL: https://codereview.tryton.org/42211002
4 months, 4 weeks ago (2018-06-22 12:04:46 UTC) #7
ced
https://codereview.tryton.org/42211002/diff/40001/forecast.py File forecast.py (right): https://codereview.tryton.org/42211002/diff/40001/forecast.py#newcode511 forecast.py:511: unit_price, move.uom) I the unit_price is never set to ...
4 months, 2 weeks ago (2018-07-05 22:40:09 UTC) #8
pokoli
Set unit price to the move
4 months, 2 weeks ago (2018-07-06 15:28:12 UTC) #9
pokoli
https://codereview.tryton.org/42211002/diff/40001/forecast.py File forecast.py (right): https://codereview.tryton.org/42211002/diff/40001/forecast.py#newcode511 forecast.py:511: unit_price, move.uom) On 2018/07/05 22:40:08, ced wrote: > I ...
4 months, 2 weeks ago (2018-07-06 15:28:31 UTC) #10
reviewbot
https://codereview.tryton.org/42211002/diff/60001/forecast.py#newcode429 forecast.py:429: E731 do not assign a lambda expression, use a def URL: https://codereview.tryton.org/42211002
4 months, 2 weeks ago (2018-07-06 15:51:02 UTC) #11
ced
4 months, 1 week ago (2018-07-11 13:35:40 UTC) #12
https://codereview.tryton.org/42211002/diff/60001/forecast.py
File forecast.py (right):

https://codereview.tryton.org/42211002/diff/60001/forecast.py#newcode507
forecast.py:507: unit_price = None
What is the purpose?
Maybe move.unit_price should always be set.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766