stock_forecast: Use multivalue api to access product multivalue fields

issue7474

[reviewbot, 2018-05-28 16:20:52]

https://codereview.tryton.org/42211002/diff/1/forecast.py#newcode429
forecast.py:429:
E731 do not assign a lambda expression, use a def

URL: https://codereview.tryton.org/42211002

[pokoli, 2018-06-11 12:15:11]

Use single method to get all multivalue values

[reviewbot, 2018-06-11 12:28:33]

https://codereview.tryton.org/42211002/diff/20001/forecast.py#newcode429
forecast.py:429:
E731 do not assign a lambda expression, use a def

URL: https://codereview.tryton.org/42211002

[ced, 2018-06-22 09:31:10]

https://codereview.tryton.org/42211002/diff/20001/forecast.py
File forecast.py (right):

https://codereview.tryton.org/42211002/diff/20001/forecast.py#newcode512
forecast.py:512: move.unit_price = unit_price
I think the unit_price could be computed from the move instead of adding
get_product_multivalue on this model.

[pokoli, 2018-06-22 11:56:21]

Compute unit price with move get_product_multivalue

[reviewbot, 2018-06-22 12:04:46]

https://codereview.tryton.org/42211002/diff/40001/forecast.py#newcode429
forecast.py:429:
E731 do not assign a lambda expression, use a def

URL: https://codereview.tryton.org/42211002

[ced, 2018-07-05 22:40:09]

https://codereview.tryton.org/42211002/diff/40001/forecast.py
File forecast.py (right):

https://codereview.tryton.org/42211002/diff/40001/forecast.py#newcode511
forecast.py:511: unit_price, move.uom)
I the unit_price is never set to the move.

[pokoli, 2018-07-06 15:28:12]

Set unit price to the move

[pokoli, 2018-07-06 15:28:31]

https://codereview.tryton.org/42211002/diff/40001/forecast.py
File forecast.py (right):

https://codereview.tryton.org/42211002/diff/40001/forecast.py#newcode511
forecast.py:511: unit_price, move.uom)
On 2018/07/05 22:40:08, ced wrote:
> I the unit_price is never set to the move.

Ooops!

[reviewbot, 2018-07-06 15:51:02]

https://codereview.tryton.org/42211002/diff/60001/forecast.py#newcode429
forecast.py:429:
E731 do not assign a lambda expression, use a def

URL: https://codereview.tryton.org/42211002

[ced, 2018-07-11 13:35:40]

https://codereview.tryton.org/42211002/diff/60001/forecast.py
File forecast.py (right):

https://codereview.tryton.org/42211002/diff/60001/forecast.py#newcode507
forecast.py:507: unit_price = None
What is the purpose?
Maybe move.unit_price should always be set.