Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(91)

Issue 42221002: stock: Check stock move if planned_date is equal to stock period date (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 3 weeks ago by perilla
Modified:
6 months ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M move.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3
perilla
9 months, 3 weeks ago (2018-06-01 17:46:15 UTC) #1
reviewbot
https://codereview.tryton.org/42221002/diff/1/move.py#newcode1089 move.py:1089: E712 comparison to True should be 'if cond is not True:' or 'if ...
9 months, 3 weeks ago (2018-06-01 17:48:41 UTC) #2
ced
9 months, 3 weeks ago (2018-06-01 18:15:50 UTC) #3
I think test_period should check this case and that test_products_by_location
should have periods up to today.

https://codereview.tryton.org/42221002/diff/1/move.py
File move.py (right):

https://codereview.tryton.org/42221002/diff/1/move.py#newcode1267
move.py:1267: ('date', '<', context['stock_date_end']),
Than I think this can be changed for <=
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766