Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(222)

Issue 42231002: proteus: Remove support for Python 2.7 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by ced
Modified:
2 weeks, 5 days ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix remarks #

Patch Set 3 : Update to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -136 lines) Patch
M .drone.yml View 1 chunk +0 lines, -2 lines 0 comments Download
M CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M INSTALL View 1 chunk +1 line, -1 line 0 comments Download
M proteus/__init__.py View 1 2 18 chunks +26 lines, -26 lines 0 comments Download
M proteus/config.py View 6 chunks +13 lines, -13 lines 0 comments Download
M proteus/pyson.py View 26 chunks +47 lines, -69 lines 0 comments Download
M proteus/tests/test_config.py View 1 chunk +3 lines, -3 lines 0 comments Download
M proteus/tests/test_model.py View 10 chunks +14 lines, -14 lines 0 comments Download
M proteus/tests/test_wizard.py View 2 chunks +2 lines, -2 lines 0 comments Download
M setup.py View 5 chunks +5 lines, -5 lines 0 comments Download
M tox.ini View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
ced
1 month, 1 week ago (2018-06-07 12:49:06 UTC) #1
reviewbot
https://codereview.tryton.org/42231002/diff/1/proteus/__init__.py#newcode735 proteus/__init__.py:735: E901 SyntaxError: invalid syntax URL: https://codereview.tryton.org/42231002
1 month, 1 week ago (2018-06-07 12:57:17 UTC) #2
pokoli
https://codereview.tryton.org/42231002/diff/1/proteus/__init__.py File proteus/__init__.py (right): https://codereview.tryton.org/42231002/diff/1/proteus/__init__.py#newcode978 proteus/__init__.py:978: definitions = iter(self._fields.items()) it is really required to make ...
1 month ago (2018-06-12 08:34:19 UTC) #3
ced
Fix remarks
1 month ago (2018-06-12 09:00:23 UTC) #4
reviewbot
https://codereview.tryton.org/42231002/diff/20001/proteus/__init__.py#newcode735 proteus/__init__.py:735: E901 SyntaxError: invalid syntax URL: https://codereview.tryton.org/42231002
1 month ago (2018-06-12 09:33:23 UTC) #5
ced
Update to tip
2 weeks, 5 days ago (2018-06-26 10:07:47 UTC) #6
reviewbot
https://codereview.tryton.org/42231002/diff/40001/proteus/__init__.py#newcode735 proteus/__init__.py:735: E901 SyntaxError: invalid syntax URL: https://codereview.tryton.org/42231002
2 weeks, 5 days ago (2018-06-26 10:28:00 UTC) #7
rietveld-bot_tryton.org
2 weeks, 5 days ago (2018-06-26 17:15:29 UTC) #8
New changeset ccce0bd65aff by Cédric Krier in branch 'default':
Remove support for Python 2.7
https://hg.tryton.org/proteus/rev/ccce0bd65aff
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69