Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11)

Issue 427111003: tryton-env: Read at most cache size or IN_MAX records from the database

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 6 days ago by nicoe
Modified:
2 weeks, 2 days ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

tryton-env: Read at most cache size or IN_MAX records from the database issue11468

Patch Set 1 #

Total comments: 3

Patch Set 2 : Move read_size computation above and limit ids #

Total comments: 2

Patch Set 3 : Ensure to read at least 1 id #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M trytond/trytond/model/modelstorage.py View 1 2 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13
reviewbot
checks OK URL: https://codereview.tryton.org/427111003
2 weeks, 6 days ago (2022-05-06 14:50:51 UTC) #1
ced
https://codereview.tryton.org/427111003/diff/437071005/trytond/trytond/model/modelstorage.py File trytond/trytond/model/modelstorage.py (right): https://codereview.tryton.org/427111003/diff/437071005/trytond/trytond/model/modelstorage.py#newcode1683 trytond/trytond/model/modelstorage.py:1683: self._transaction.database.IN_MAX) Must also be limited https://codereview.tryton.org/427111003/diff/437071005/trytond/trytond/model/modelstorage.py#newcode1763 trytond/trytond/model/modelstorage.py:1763: list(index.keys())[:read_size], list(ffields.keys())) ...
2 weeks, 6 days ago (2022-05-06 16:23:13 UTC) #2
nicoe
Test
2 weeks, 6 days ago (2022-05-06 16:25:17 UTC) #3
nicoe
2 weeks, 6 days ago (2022-05-06 16:43:51 UTC) #4
reviewbot
checks OK URL: https://codereview.tryton.org/427111003
2 weeks, 6 days ago (2022-05-06 16:48:31 UTC) #5
nicoe
https://codereview.tryton.org/427111003/diff/437071005/trytond/trytond/model/modelstorage.py File trytond/trytond/model/modelstorage.py (right): https://codereview.tryton.org/427111003/diff/437071005/trytond/trytond/model/modelstorage.py#newcode1683 trytond/trytond/model/modelstorage.py:1683: self._transaction.database.IN_MAX) On 2022/05/06 16:23:12, ced wrote: > Must also ...
2 weeks, 6 days ago (2022-05-06 16:51:33 UTC) #6
ced
https://codereview.tryton.org/427111003/diff/439081003/trytond/trytond/model/modelstorage.py File trytond/trytond/model/modelstorage.py (right): https://codereview.tryton.org/427111003/diff/439081003/trytond/trytond/model/modelstorage.py#newcode1681 trytond/trytond/model/modelstorage.py:1681: self._transaction.database.IN_MAX) I think we must ensure that it is ...
2 weeks, 6 days ago (2022-05-07 08:36:51 UTC) #7
nicoe
2 weeks, 3 days ago (2022-05-09 14:01:28 UTC) #8
nicoe
https://codereview.tryton.org/427111003/diff/439081003/trytond/trytond/model/modelstorage.py File trytond/trytond/model/modelstorage.py (right): https://codereview.tryton.org/427111003/diff/439081003/trytond/trytond/model/modelstorage.py#newcode1681 trytond/trytond/model/modelstorage.py:1681: self._transaction.database.IN_MAX) On 2022/05/07 08:36:50, ced wrote: > I think ...
2 weeks, 3 days ago (2022-05-09 14:01:33 UTC) #9
reviewbot
checks OK URL: https://codereview.tryton.org/427111003
2 weeks, 3 days ago (2022-05-09 14:27:09 UTC) #10
ced
LGTM
2 weeks, 3 days ago (2022-05-09 21:03:48 UTC) #11
rietveld-bot_tryton.org
New changeset 48bad78f99b0 by Nicolas Évrard in branch 'default': Read at most cache size or ...
2 weeks, 2 days ago (2022-05-10 13:24:54 UTC) #12
rietveld-bot_tryton.org
2 weeks, 2 days ago (2022-05-10 13:24:59 UTC) #13
New changeset a3e4c48f3a45 by Nicolas Évrard in branch 'default':
Read at most cache size or IN_MAX records from the database
https://hg.tryton.org/tryton-env/rev/a3e4c48f3a45
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted