Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 427161003: stock_supply: Only delete draft requests when generating new ones (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks ago by pokoli
Modified:
1 week ago
Reviewers:
acaubet, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

We can not rely on purchase_line as purchase_request_quotation adds new states before the request is purchased that should not be deleted issue11479

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove purchase_line domain #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M purchase_request.py View 1 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 10
pokoli
2 weeks ago (2022-05-12 15:51:37 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/427161003
2 weeks ago (2022-05-12 15:59:24 UTC) #2
ced
I think we could have a commit description that explain why we should filter by ...
2 weeks ago (2022-05-12 22:07:21 UTC) #3
pokoli
Remove purchase_line domain
2 weeks ago (2022-05-13 10:37:42 UTC) #4
pokoli
On 2022/05/12 22:07:21, ced wrote: > I think we could have a commit description that ...
2 weeks ago (2022-05-13 10:38:04 UTC) #5
reviewbot
checks OK URL: https://codereview.tryton.org/427161003
2 weeks ago (2022-05-13 10:55:31 UTC) #6
ced
LGTM
2 weeks ago (2022-05-13 10:58:40 UTC) #7
rietveld-bot_tryton.org
New changeset f4bea63d827a by Sergi Almacellas Abellana in branch 'default': Only delete draft requests when ...
1 week, 4 days ago (2022-05-16 07:59:51 UTC) #8
rietveld-bot_tryton.org
New changeset a3569e336d02 by Sergi Almacellas Abellana in branch 'default': Only delete draft requests when ...
1 week, 4 days ago (2022-05-16 08:00:00 UTC) #9
acaubet
1 week ago (2022-05-20 07:28:01 UTC) #10
Message was sent while issue was closed.
https://codereview.tryton.org/427161003/diff/419141004/purchase_request.py
File purchase_request.py (right):

https://codereview.tryton.org/427161003/diff/419141004/purchase_request.py#ne...
purchase_request.py:132: # delete purchase requests without a purchase line
This comment needs to be erased
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted