Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(46)

Issue 427221003: party: Avoid duplicated emails in party and contact mechanism default email (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by pokoli
Modified:
2 months, 1 week ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Exclude party instead of id #

Patch Set 3 : Exclude contact_mechanisms instead of id #

Total comments: 1

Patch Set 4 : Do not exclude email #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ir.py View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 16
pokoli
2 months, 3 weeks ago (2022-05-20 12:35:13 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/427221003
2 months, 3 weeks ago (2022-05-20 12:53:33 UTC) #2
ced
https://codereview.tryton.org/427221003/diff/425211003/ir.py File ir.py (right): https://codereview.tryton.org/427221003/diff/425211003/ir.py#newcode61 ir.py:61: exclude.append('id') I do not think it is the id ...
2 months, 3 weeks ago (2022-05-20 13:17:02 UTC) #3
pokoli
Exclude party instead of id
2 months, 3 weeks ago (2022-05-23 09:10:20 UTC) #4
pokoli
https://codereview.tryton.org/427221003/diff/425211003/ir.py File ir.py (right): https://codereview.tryton.org/427221003/diff/425211003/ir.py#newcode61 ir.py:61: exclude.append('id') On 2022/05/20 13:17:02, ced wrote: > I do ...
2 months, 3 weeks ago (2022-05-23 09:12:20 UTC) #5
reviewbot
checks OK URL: https://codereview.tryton.org/427221003
2 months, 3 weeks ago (2022-05-23 09:19:42 UTC) #6
ced
https://codereview.tryton.org/427221003/diff/425211003/ir.py File ir.py (right): https://codereview.tryton.org/427221003/diff/425211003/ir.py#newcode61 ir.py:61: exclude.append('id') On 2022/05/23 09:12:20, pokoli wrote: > On 2022/05/20 ...
2 months, 3 weeks ago (2022-05-24 09:54:52 UTC) #7
pokoli
Exclude contact_mechanisms instead of id
2 months, 3 weeks ago (2022-05-24 12:25:26 UTC) #8
reviewbot
checks OK URL: https://codereview.tryton.org/427221003
2 months, 3 weeks ago (2022-05-24 12:44:33 UTC) #9
ced
https://codereview.tryton.org/427221003/diff/421201003/ir.py File ir.py (right): https://codereview.tryton.org/427221003/diff/421201003/ir.py#newcode62 ir.py:62: exclude.append('email') I do not see why email must be ...
2 months, 3 weeks ago (2022-05-25 07:42:21 UTC) #10
pokoli
Do not exclude email
2 months, 3 weeks ago (2022-05-25 08:10:18 UTC) #11
reviewbot
checks OK URL: https://codereview.tryton.org/427221003
2 months, 3 weeks ago (2022-05-25 08:12:08 UTC) #12
ced
LGTM
2 months, 3 weeks ago (2022-05-25 08:30:13 UTC) #13
rietveld-bot_tryton.org
New changeset bc92627b6fc9 by Sergi Almacellas Abellana in branch 'default': Avoid duplicated emails in party ...
2 months, 2 weeks ago (2022-05-25 15:48:34 UTC) #14
rietveld-bot_tryton.org
New changeset 07c227942fa1 by Sergi Almacellas Abellana in branch 'default': Avoid duplicated emails in party ...
2 months, 2 weeks ago (2022-05-25 15:48:39 UTC) #15
rietveld-bot_tryton.org
2 months, 1 week ago (2022-06-02 11:42:24 UTC) #16
New changeset 50b4ba7f33f3 by Sergi Almacellas Abellana in branch '6.4':
Avoid duplicated emails in party and contact mechanism default email
https://hg.tryton.org/modules/party/rev/50b4ba7f33f3


New changeset 4987942f0c2e by Sergi Almacellas Abellana in branch '6.2':
Avoid duplicated emails in party and contact mechanism default email
https://hg.tryton.org/modules/party/rev/4987942f0c2e


New changeset 81831821a2a2 by Sergi Almacellas Abellana in branch '6.0':
Avoid duplicated emails in party and contact mechanism default email
https://hg.tryton.org/modules/party/rev/81831821a2a2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted