Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 427691003: account: Select all periods ending before the end period (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 3 weeks ago by ced
Modified:
4 months, 1 week ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

account: Select all periods ending before the end period But exclude period of one day on the last day of the period. issue10961

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move outside domain date clause computation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M account.py View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 8
ced
4 months, 3 weeks ago (2022-09-11 16:21:58 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/427691003
4 months, 3 weeks ago (2022-09-11 16:45:45 UTC) #2
pokoli
https://codereview.tryton.org/427691003/diff/417991003/account.py File account.py (right): https://codereview.tryton.org/427691003/diff/417991003/account.py#newcode1896 account.py:1896: if name.startswith('start_') else i find it very dificult to ...
4 months, 3 weeks ago (2022-09-12 12:57:36 UTC) #3
ced
4 months, 3 weeks ago (2022-09-12 14:43:27 UTC) #4
ced
https://codereview.tryton.org/427691003/diff/417991003/account.py File account.py (right): https://codereview.tryton.org/427691003/diff/417991003/account.py#newcode1896 account.py:1896: if name.startswith('start_') else On 2022/09/12 12:57:36, pokoli wrote: > ...
4 months, 3 weeks ago (2022-09-12 14:43:30 UTC) #5
pokoli
LGTM
4 months, 3 weeks ago (2022-09-12 15:37:07 UTC) #6
rietveld-bot_tryton.org
New changeset 8b4c201363d2 by Cédric Krier in branch 'default': Select all periods ending before the ...
4 months, 1 week ago (2022-09-25 18:17:24 UTC) #7
rietveld-bot_tryton.org
4 months, 1 week ago (2022-09-25 18:17:35 UTC) #8
New changeset f246fddee3dc by Cédric Krier in branch 'default':
Select all periods ending before the end period
https://hg.tryton.org/tryton-env/rev/f246fddee3dc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted