Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(429)

Issue 427811003: trytond: Support MultiSelection in MultiValue field (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by tiyujopite
Modified:
3 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 7

Patch Set 3 : Add support to MultiSelection in MultiValue field. #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 4

Patch Set 8 : #

Total comments: 1

Patch Set 9 : #

Total comments: 11

Patch Set 10 : Fix format #

Patch Set 11 : Simplify and normalize tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -4 lines) Patch
M trytond/model/multivalue.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M trytond/tests/multivalue.py View 1 2 3 4 5 6 7 8 9 10 3 chunks +45 lines, -1 line 0 comments Download
M trytond/tests/test_multivalue.py View 1 2 3 4 5 6 7 8 9 10 4 chunks +110 lines, -2 lines 0 comments Download

Messages

Total messages: 34
tiyujopite
4 months, 1 week ago (2022-09-23 16:13:15 UTC) #1
reviewbot
patch is not applicable URL: https://codereview.tryton.org/427811003
4 months, 1 week ago (2022-09-23 16:19:25 UTC) #2
ced
https://codereview.tryton.org/427811003/diff/427801004/trytond/trytond/model/multivalue.py File trytond/trytond/model/multivalue.py (right): https://codereview.tryton.org/427811003/diff/427801004/trytond/trytond/model/multivalue.py#newcode71 trytond/trytond/model/multivalue.py:71: and Value._fields[name]._type != 'multiselection'): I think I would prefer ...
4 months, 1 week ago (2022-09-26 07:59:59 UTC) #3
ced
We need a test to verify the behavior.
4 months, 1 week ago (2022-09-26 08:00:57 UTC) #4
tiyujopite
4 months, 1 week ago (2022-09-26 15:13:48 UTC) #5
reviewbot
patch is not applicable URL: https://codereview.tryton.org/427811003
4 months, 1 week ago (2022-09-26 15:32:38 UTC) #6
ced
On 2022/09/26 15:32:38, reviewbot wrote: > patch is not applicable > URL: https://codereview.tryton.org/427811003 You must ...
4 months, 1 week ago (2022-09-27 07:32:10 UTC) #7
ced
https://codereview.tryton.org/427811003/diff/419851005/trytond/trytond/model/multivalue.py File trytond/trytond/model/multivalue.py (right): https://codereview.tryton.org/427811003/diff/419851005/trytond/trytond/model/multivalue.py#newcode72 trytond/trytond/model/multivalue.py:72: return [r.id for r in value] To avoid double ...
4 months, 1 week ago (2022-09-27 07:37:30 UTC) #8
tiyujopite
4 months, 1 week ago (2022-09-27 08:43:51 UTC) #9
reviewbot
https://codereview.tryton.org/427811003/diff/418131003/trytond/tests/multivalue.py#newcode17 trytond/tests/multivalue.py:17: continuation line under-indented for hanging indent https://codereview.tryton.org/427811003/diff/418131003/trytond/tests/multivalue.py#newcode54 trytond/tests/multivalue.py:54: continuation line under-indented for hanging ...
4 months, 1 week ago (2022-09-27 09:05:50 UTC) #10
tiyujopite
4 months, 1 week ago (2022-09-27 09:10:54 UTC) #11
reviewbot
checks OK URL: https://codereview.tryton.org/427811003
4 months, 1 week ago (2022-09-27 09:35:47 UTC) #12
tiyujopite
4 months, 1 week ago (2022-09-27 10:42:37 UTC) #13
reviewbot
checks OK URL: https://codereview.tryton.org/427811003
4 months, 1 week ago (2022-09-27 10:43:21 UTC) #14
tiyujopite
4 months, 1 week ago (2022-09-27 10:47:57 UTC) #15
tiyujopite
4 months, 1 week ago (2022-09-27 10:50:44 UTC) #16
reviewbot
checks OK URL: https://codereview.tryton.org/427811003
4 months, 1 week ago (2022-09-27 11:10:32 UTC) #17
ced
https://codereview.tryton.org/427811003/diff/423941003/trytond/tests/test_multivalue.py File trytond/tests/test_multivalue.py (right): https://codereview.tryton.org/427811003/diff/423941003/trytond/tests/test_multivalue.py#newcode175 trytond/tests/test_multivalue.py:175: None) For me this test should have the code ...
4 months, 1 week ago (2022-09-28 06:33:14 UTC) #18
tiyujopite
4 months ago (2022-09-28 19:14:57 UTC) #19
reviewbot
checks OK URL: https://codereview.tryton.org/427811003
4 months ago (2022-09-28 19:32:48 UTC) #20
ced
https://codereview.tryton.org/427811003/diff/447301003/trytond/tests/test_multivalue.py File trytond/tests/test_multivalue.py (right): https://codereview.tryton.org/427811003/diff/447301003/trytond/tests/test_multivalue.py#newcode278 trytond/tests/test_multivalue.py:278: '%s,%s' % (ReferenceModel.__name__, str(test_reference.id))) Could put each kind of ...
4 months ago (2022-09-29 21:55:43 UTC) #21
tiyujopite
4 months ago (2022-10-03 15:32:11 UTC) #22
reviewbot
checks OK URL: https://codereview.tryton.org/427811003
4 months ago (2022-10-03 15:40:15 UTC) #23
ced
https://codereview.tryton.org/427811003/diff/423981003/trytond/tests/multivalue.py File trytond/tests/multivalue.py (right): https://codereview.tryton.org/427811003/diff/423981003/trytond/tests/multivalue.py#newcode15 trytond/tests/multivalue.py:15: ('foo', "Foo"), wrong indentation https://codereview.tryton.org/427811003/diff/423981003/trytond/tests/multivalue.py#newcode20 trytond/tests/multivalue.py:20: (None, ''), wrong ...
3 months, 4 weeks ago (2022-10-06 06:48:06 UTC) #24
tiyujopite
https://codereview.tryton.org/427811003/diff/423981003/trytond/tests/multivalue.py File trytond/tests/multivalue.py (right): https://codereview.tryton.org/427811003/diff/423981003/trytond/tests/multivalue.py#newcode15 trytond/tests/multivalue.py:15: ('foo', "Foo"), On 2022/10/06 06:48:06, ced wrote: > wrong ...
3 months, 4 weeks ago (2022-10-06 07:12:41 UTC) #25
ced
https://codereview.tryton.org/427811003/diff/423981003/trytond/tests/multivalue.py File trytond/tests/multivalue.py (right): https://codereview.tryton.org/427811003/diff/423981003/trytond/tests/multivalue.py#newcode15 trytond/tests/multivalue.py:15: ('foo', "Foo"), On 2022/10/06 07:12:41, tiyujopite wrote: > On ...
3 months, 4 weeks ago (2022-10-06 08:02:24 UTC) #26
ced
https://codereview.tryton.org/427811003/diff/423981003/trytond/tests/multivalue.py File trytond/tests/multivalue.py (right): https://codereview.tryton.org/427811003/diff/423981003/trytond/tests/multivalue.py#newcode15 trytond/tests/multivalue.py:15: ('foo', "Foo"), On 2022/10/06 08:02:23, ced wrote: > On ...
3 months, 4 weeks ago (2022-10-06 08:12:42 UTC) #27
tiyujopite
3 months, 3 weeks ago (2022-10-13 14:57:50 UTC) #28
reviewbot
checks OK URL: https://codereview.tryton.org/427811003
3 months, 3 weeks ago (2022-10-13 15:13:47 UTC) #29
ced
3 months, 2 weeks ago (2022-10-15 19:36:03 UTC) #30
reviewbot
checks OK URL: https://codereview.tryton.org/427811003
3 months, 2 weeks ago (2022-10-15 20:04:08 UTC) #31
ced
LGTM
3 months, 2 weeks ago (2022-10-15 20:07:42 UTC) #32
rietveld-bot_tryton.org
New changeset bd9ad6eedf5c by José Antonio Díaz in branch 'default': Support MultiSelection in MultiValue field ...
3 months, 2 weeks ago (2022-10-15 20:09:00 UTC) #33
rietveld-bot_tryton.org
3 months ago (2022-10-30 09:39:16 UTC) #34
New changeset bac74c2ea3cd by José Antonio Díaz in branch '6.4':
Support MultiSelection in MultiValue field
https://hg.tryton.org/trytond/rev/bac74c2ea3cd


New changeset 9444c2eb9be8 by José Antonio Díaz in branch '6.2':
Support MultiSelection in MultiValue field
https://hg.tryton.org/trytond/rev/9444c2eb9be8


New changeset ce982fabd69a by José Antonio Díaz in branch '6.0':
Support MultiSelection in MultiValue field
https://hg.tryton.org/trytond/rev/ce982fabd69a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted