Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(140)

Issue 42801002: stock: Manage same input and storage location

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by pokoli
Modified:
1 week, 4 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

In this case there is no need to create inventory moves issue6892

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix ced's comments #

Total comments: 3

Patch Set 3 : Fix ced's comments #

Total comments: 3

Patch Set 4 : Use child location in scenario and fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -8 lines) Patch
M CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M doc/index.rst View 1 chunk +3 lines, -0 lines 0 comments Download
M setup.py View 1 chunk +2 lines, -0 lines 0 comments Download
M shipment.py View 1 2 3 8 chunks +34 lines, -6 lines 0 comments Download
A tests/scenario_stock_shipment_in_same_storage_input.rst View 1 2 3 1 chunk +85 lines, -0 lines 0 comments Download
M tests/test_stock.py View 1 chunk +5 lines, -0 lines 0 comments Download
M view/shipment_in_form.xml View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11
pokoli
2 months, 3 weeks ago (2017-10-31 10:18:59 UTC) #1
reviewbot
https://codereview.tryton.org/42801002/diff/1/setup.py#newcode89 setup.py:89: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/42801002
2 months, 3 weeks ago (2017-10-31 10:38:01 UTC) #2
ced
https://codereview.tryton.org/42801002/diff/1/shipment.py File shipment.py (right): https://codereview.tryton.org/42801002/diff/1/shipment.py#newcode534 shipment.py:534: if m.state != 'done']) Will it not be faster ...
2 months ago (2017-11-24 09:18:52 UTC) #3
pokoli
Fix ced's comments
2 months ago (2017-11-24 10:29:27 UTC) #4
reviewbot
https://codereview.tryton.org/42801002/diff/20001/setup.py#newcode89 setup.py:89: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/42801002
2 months ago (2017-11-24 10:50:28 UTC) #5
ced
https://codereview.tryton.org/42801002/diff/20001/shipment.py File shipment.py (right): https://codereview.tryton.org/42801002/diff/20001/shipment.py#newcode129 shipment.py:129: ('to_location', '=', Eval('warehouse_input')), For me, this constraint should be ...
1 month ago (2017-12-19 22:56:47 UTC) #6
pokoli
Fix ced's comments
1 month ago (2017-12-22 11:47:47 UTC) #7
reviewbot
https://codereview.tryton.org/42801002/diff/40001/setup.py#newcode89 setup.py:89: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/42801002
1 month ago (2017-12-22 12:11:02 UTC) #8
ced
https://codereview.tryton.org/42801002/diff/40001/shipment.py File shipment.py (right): https://codereview.tryton.org/42801002/diff/40001/shipment.py#newcode125 shipment.py:125: ('to_location', '=', Eval('warehouse_input')), I guess this should also be ...
2 weeks ago (2018-01-09 17:59:41 UTC) #9
pokoli
Use child location in scenario and fix comments
1 week, 4 days ago (2018-01-12 13:54:27 UTC) #10
reviewbot
1 week, 4 days ago (2018-01-12 14:06:40 UTC) #11
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922