Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(86)

Issue 42801002: stock: Manage same input and storage location (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by pokoli
Modified:
3 weeks, 5 days ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

In this case there is no need to create inventory moves issue6892

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix ced's comments #

Total comments: 3

Patch Set 3 : Fix ced's comments #

Total comments: 3

Patch Set 4 : Use child location in scenario and fix comments #

Total comments: 1

Patch Set 5 : Use receive button instead of done #

Total comments: 2

Patch Set 6 : Remove draft to done transition #

Total comments: 2

Patch Set 7 : write state to all shipments #

Total comments: 1

Patch Set 8 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -5 lines) Patch
M CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M doc/index.rst View 1 chunk +3 lines, -0 lines 0 comments Download
M setup.py View 1 chunk +2 lines, -0 lines 0 comments Download
M shipment.py View 1 2 3 4 5 6 7 6 chunks +22 lines, -3 lines 0 comments Download
A tests/scenario_stock_shipment_in_same_storage_input.rst View 1 2 3 4 1 chunk +84 lines, -0 lines 0 comments Download
M tests/test_stock.py View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M view/shipment_in_form.xml View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 25
pokoli
5 months, 2 weeks ago (2017-10-31 10:18:59 UTC) #1
reviewbot
https://codereview.tryton.org/42801002/diff/1/setup.py#newcode89 setup.py:89: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/42801002
5 months, 2 weeks ago (2017-10-31 10:38:01 UTC) #2
ced
https://codereview.tryton.org/42801002/diff/1/shipment.py File shipment.py (right): https://codereview.tryton.org/42801002/diff/1/shipment.py#newcode534 shipment.py:534: if m.state != 'done']) Will it not be faster ...
4 months, 3 weeks ago (2017-11-24 09:18:52 UTC) #3
pokoli
Fix ced's comments
4 months, 3 weeks ago (2017-11-24 10:29:27 UTC) #4
reviewbot
https://codereview.tryton.org/42801002/diff/20001/setup.py#newcode89 setup.py:89: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/42801002
4 months, 3 weeks ago (2017-11-24 10:50:28 UTC) #5
ced
https://codereview.tryton.org/42801002/diff/20001/shipment.py File shipment.py (right): https://codereview.tryton.org/42801002/diff/20001/shipment.py#newcode129 shipment.py:129: ('to_location', '=', Eval('warehouse_input')), For me, this constraint should be ...
4 months ago (2017-12-19 22:56:47 UTC) #6
pokoli
Fix ced's comments
3 months, 4 weeks ago (2017-12-22 11:47:47 UTC) #7
reviewbot
https://codereview.tryton.org/42801002/diff/40001/setup.py#newcode89 setup.py:89: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/42801002
3 months, 4 weeks ago (2017-12-22 12:11:02 UTC) #8
ced
https://codereview.tryton.org/42801002/diff/40001/shipment.py File shipment.py (right): https://codereview.tryton.org/42801002/diff/40001/shipment.py#newcode125 shipment.py:125: ('to_location', '=', Eval('warehouse_input')), I guess this should also be ...
3 months, 1 week ago (2018-01-09 17:59:41 UTC) #9
pokoli
Use child location in scenario and fix comments
3 months, 1 week ago (2018-01-12 13:54:27 UTC) #10
reviewbot
https://codereview.tryton.org/42801002/diff/60001/setup.py#newcode89 setup.py:89: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/42801002
3 months, 1 week ago (2018-01-12 14:06:40 UTC) #11
ced
https://codereview.tryton.org/42801002/diff/60001/shipment.py File shipment.py (right): https://codereview.tryton.org/42801002/diff/60001/shipment.py#newcode207 shipment.py:207: (Eval('warehouse_input') == Eval('warehouse_storage')) I'm wondering if it should not ...
4 weeks, 1 day ago (2018-03-21 12:47:37 UTC) #12
pokoli
Use receive button instead of done
4 weeks, 1 day ago (2018-03-21 13:33:56 UTC) #13
reviewbot
https://codereview.tryton.org/42801002/diff/80001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/42801002
4 weeks, 1 day ago (2018-03-21 13:44:12 UTC) #14
ced
https://codereview.tryton.org/42801002/diff/80001/shipment.py File shipment.py (right): https://codereview.tryton.org/42801002/diff/80001/shipment.py#newcode193 shipment.py:193: ('draft', 'done'), I would prefer to not add this ...
4 weeks, 1 day ago (2018-03-21 14:17:28 UTC) #15
pokoli
Remove draft to done transition
4 weeks ago (2018-03-22 10:02:21 UTC) #16
reviewbot
https://codereview.tryton.org/42801002/diff/100001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/42801002
4 weeks ago (2018-03-22 10:22:27 UTC) #17
ced
https://codereview.tryton.org/42801002/diff/100001/shipment.py File shipment.py (right): https://codereview.tryton.org/42801002/diff/100001/shipment.py#newcode524 shipment.py:524: if s.warehouse_storage == s.warehouse_input] strange indent https://codereview.tryton.org/42801002/diff/100001/shipment.py#newcode526 shipment.py:526: cls.write(to_do, ...
4 weeks ago (2018-03-22 18:13:25 UTC) #18
pokoli
write state to all shipments
3 weeks, 6 days ago (2018-03-23 08:47:35 UTC) #19
reviewbot
https://codereview.tryton.org/42801002/diff/120001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/42801002
3 weeks, 6 days ago (2018-03-23 08:52:19 UTC) #20
ced
https://codereview.tryton.org/42801002/diff/120001/shipment.py File shipment.py (right): https://codereview.tryton.org/42801002/diff/120001/shipment.py#newcode523 shipment.py:523: cls.write(shipments, {'state': 'received'}) I would just put a comment ...
3 weeks, 6 days ago (2018-03-23 09:28:15 UTC) #21
pokoli
Add comment
3 weeks, 6 days ago (2018-03-23 11:47:21 UTC) #22
reviewbot
https://codereview.tryton.org/42801002/diff/140001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/42801002
3 weeks, 6 days ago (2018-03-23 12:15:08 UTC) #23
ced
LGTM
3 weeks, 6 days ago (2018-03-23 21:25:54 UTC) #24
rietveld-bot_tryton.org
3 weeks, 5 days ago (2018-03-24 11:04:50 UTC) #25
New changeset c317aa8e6180 by Sergi Almacellas Abellana in branch 'default':
Manage same input and storage location
http://hg.tryton.org/modules/stock/rev/c317aa8e6180
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922