Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(51)

Issue 42841002: account_payment_stripe: Support dispute (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months ago by ced
Modified:
9 months ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : No need of action_id #

Patch Set 3 : Add scenario to 2to3 #

Patch Set 4 : Fix charge id #

Unified diffs Side-by-side diffs Delta from patch set Stats (+397 lines, -1 line) Patch
M CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M doc/index.rst View 1 chunk +2 lines, -0 lines 0 comments Download
M payment.py View 1 2 3 8 chunks +77 lines, -1 line 0 comments Download
M setup.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A tests/scenario_account_payment_stripe_dispute.rst View 1 2 3 1 chunk +306 lines, -0 lines 0 comments Download
M tests/test_account_payment_stripe.py View 1 chunk +5 lines, -0 lines 0 comments Download
M view/payment_form.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11
ced
11 months ago (2017-11-14 18:03:52 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/42841002
11 months ago (2017-11-14 18:40:35 UTC) #2
pokoli
https://tryton-rietveld-hrd.appspot.com/42841002/diff/1/tests/scenario_account_payment_stripe_dispute.rst File tests/scenario_account_payment_stripe_dispute.rst (right): https://tryton-rietveld-hrd.appspot.com/42841002/diff/1/tests/scenario_account_payment_stripe_dispute.rst#newcode71 tests/scenario_account_payment_stripe_dispute.rst:71: >>> action_id = payment.click('stripe_checkout') why saving action_id? Why not ...
11 months ago (2017-11-15 09:09:45 UTC) #3
ced
No need of action_id
11 months ago (2017-11-15 09:59:18 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/42841002
11 months ago (2017-11-15 10:05:20 UTC) #5
pokoli
test scenario should be added to 2to3 on setup.py
10 months, 4 weeks ago (2017-11-20 13:05:57 UTC) #6
ced
Add scenario to 2to3
10 months, 4 weeks ago (2017-11-20 15:09:29 UTC) #7
reviewbot
https://codereview.tryton.org/42841002/diff/40001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/42841002
10 months, 4 weeks ago (2017-11-20 15:15:48 UTC) #8
ced
Fix charge id
10 months, 3 weeks ago (2017-11-22 15:21:05 UTC) #9
reviewbot
https://codereview.tryton.org/42841002/diff/60001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/42841002
10 months, 3 weeks ago (2017-11-22 15:23:23 UTC) #10
rietveld-bot_tryton.org
9 months ago (2018-01-12 12:10:35 UTC) #11
New changeset 5af9936e7f4e by Cédric Krier in branch 'default':
Support dispute
http://hg.tryton.org/modules/account_payment_stripe/rev/5af9936e7f4e
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766