Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(846)

Issue 42881002: sale_price_list: Modify the sale line price when changing the sale customer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 4 days ago by nicoe
Modified:
1 day, 4 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use the sale.sale ModelView design #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M __init__.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M sale.py View 1 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 6
nicoe
2 weeks, 4 days ago (2017-11-27 17:51:04 UTC) #1
reviewbot
https://codereview.tryton.org/42881002/diff/1/__init__.py#newcode5 __init__.py:5: F403 'from party import *' used; unable to detect undefined names https://codereview.tryton.org/42881002/diff/1/__init__.py#newcode6 __init__.py:6: ...
2 weeks, 4 days ago (2017-11-27 18:01:10 UTC) #2
ced
https://codereview.tryton.org/42881002/diff/1/sale.py File sale.py (right): https://codereview.tryton.org/42881002/diff/1/sale.py#newcode87 sale.py:87: Decimal(1) / 10 ** line.__class__.unit_price.digits[1]) This must be done ...
2 weeks, 3 days ago (2017-11-28 12:00:16 UTC) #3
nicoe
Use the sale.sale ModelView design
4 days, 4 hours ago (2017-12-11 16:55:54 UTC) #4
reviewbot
https://codereview.tryton.org/42881002/diff/20001/__init__.py#newcode5 __init__.py:5: F403 'from party import *' used; unable to detect undefined names https://codereview.tryton.org/42881002/diff/20001/__init__.py#newcode6 __init__.py:6: ...
4 days, 4 hours ago (2017-12-11 17:18:09 UTC) #5
ced
1 day, 4 hours ago (2017-12-14 17:16:20 UTC) #6
Indeed it is not needed with new version of
https://codereview.tryton.org/38991002/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922