Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 42921002: python-sql: Add comparison predicates (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 1 week ago by ced
Modified:
4 months, 3 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

bug55

Patch Set 1 #

Total comments: 10

Patch Set 2 : Add to __all__ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -5 lines) Patch
M CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M sql/operators.py View 1 3 chunks +79 lines, -3 lines 0 comments Download
M sql/tests/test_operators.py View 2 chunks +71 lines, -2 lines 0 comments Download

Messages

Total messages: 10
ced
7 months, 1 week ago (2017-12-12 18:40:50 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/42921002
7 months, 1 week ago (2017-12-12 19:20:45 UTC) #2
pokoli
https://codereview.tryton.org/42921002/diff/1/sql/operators.py File sql/operators.py (right): https://codereview.tryton.org/42921002/diff/1/sql/operators.py#newcode209 sql/operators.py:209: if self.left is Null: the new "IS" operator can ...
7 months, 1 week ago (2017-12-13 15:35:23 UTC) #3
ced
https://codereview.tryton.org/42921002/diff/1/sql/operators.py File sql/operators.py (right): https://codereview.tryton.org/42921002/diff/1/sql/operators.py#newcode209 sql/operators.py:209: if self.left is Null: On 2017/12/13 15:35:23, pokoli wrote: ...
7 months, 1 week ago (2017-12-13 15:52:39 UTC) #4
pokoli
https://codereview.tryton.org/42921002/diff/1/sql/operators.py File sql/operators.py (right): https://codereview.tryton.org/42921002/diff/1/sql/operators.py#newcode209 sql/operators.py:209: if self.left is Null: On 2017/12/13 15:52:39, ced wrote: ...
7 months, 1 week ago (2017-12-13 16:05:32 UTC) #5
ced
https://codereview.tryton.org/42921002/diff/1/sql/operators.py File sql/operators.py (right): https://codereview.tryton.org/42921002/diff/1/sql/operators.py#newcode209 sql/operators.py:209: if self.left is Null: On 2017/12/13 16:05:32, pokoli wrote: ...
7 months, 1 week ago (2017-12-13 16:16:01 UTC) #6
ced
https://codereview.tryton.org/42921002/diff/1/sql/operators.py File sql/operators.py (right): https://codereview.tryton.org/42921002/diff/1/sql/operators.py#newcode275 sql/operators.py:275: assert right in [None, True, False] On 2017/12/13 16:16:01, ...
7 months, 1 week ago (2017-12-13 23:13:13 UTC) #7
ced
Add to __all__
4 months, 3 weeks ago (2018-02-27 15:23:20 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/42921002
4 months, 3 weeks ago (2018-02-27 15:44:20 UTC) #9
rietveld-bot_tryton.org
4 months, 3 weeks ago (2018-02-28 11:55:17 UTC) #10
New changeset d2f107f10da9 by Cédric Krier in branch 'default':
Add comparison predicates
http://hg.tryton.org/python-sql/rev/d2f107f10da9
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3870a69