Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(415)

Issue 43051002: account_statement_aeb43: Initial commit

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 3 weeks ago by pokoli
Modified:
6 days, 21 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove retrofix dependency #

Patch Set 3 : Remove mysql backend #

Patch Set 4 : Fix copyright notices #

Total comments: 35

Patch Set 5 : Fix most comments #

Patch Set 6 : Test with a file with only one origin and use ascii encoding by default #

Patch Set 7 : Use csb43 library to parse the file #

Total comments: 9

Patch Set 8 : Use python api instead of converting as dict and fix metaclass possition #

Patch Set 9 : Fix comments and update to tip #

Total comments: 12

Patch Set 10 : Fix ced's comments #

Patch Set 11 : Disable strict mode #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+1309 lines, -0 lines) Patch
A .drone.yml View 1 chunk +51 lines, -0 lines 0 comments Download
A COPYRIGHT View 1 1 chunk +14 lines, -0 lines 0 comments Download
A INSTALL View 1 2 3 4 5 6 1 chunk +33 lines, -0 lines 2 comments Download
A LICENSE View 1 chunk +674 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
A README View 1 chunk +35 lines, -0 lines 0 comments Download
A __init__.py View 1 chunk +16 lines, -0 lines 0 comments Download
A doc/index.rst View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -0 lines 0 comments Download
A setup.py View 1 2 3 4 5 6 7 8 9 1 chunk +128 lines, -0 lines 0 comments Download
A statement.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +108 lines, -0 lines 3 comments Download
A statement.xml View 1 2 3 4 5 6 1 chunk +56 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 chunk +9 lines, -0 lines 0 comments Download
A tests/n43.txt View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
A tests/scenario_account_statement_aeb43.rst View 1 2 3 4 5 6 7 8 9 1 chunk +119 lines, -0 lines 0 comments Download
A tests/test_account_statement_aeb43.py View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
A tox.ini View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A tryton.cfg View 1 2 3 4 5 6 7 8 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 42
pokoli
3 months, 3 weeks ago (2018-01-23 16:02:56 UTC) #1
reviewbot
https://codereview.tryton.org/43051002/diff/1/setup.py#newcode87 setup.py:87: E501 line too long (85 > 79 characters) https://codereview.tryton.org/43051002/diff/1/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
3 months, 3 weeks ago (2018-01-23 16:05:21 UTC) #2
pokoli
Remove retrofix dependency
3 months, 3 weeks ago (2018-01-24 11:21:26 UTC) #3
reviewbot
https://codereview.tryton.org/43051002/diff/20001/setup.py#newcode87 setup.py:87: E501 line too long (85 > 79 characters) https://codereview.tryton.org/43051002/diff/20001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
3 months, 3 weeks ago (2018-01-24 11:32:14 UTC) #4
pokoli
Remove mysql backend
3 months, 3 weeks ago (2018-01-25 08:19:57 UTC) #5
reviewbot
https://codereview.tryton.org/43051002/diff/40001/setup.py#newcode87 setup.py:87: E501 line too long (85 > 79 characters) https://codereview.tryton.org/43051002/diff/40001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
3 months, 3 weeks ago (2018-01-25 08:40:31 UTC) #6
pokoli
Fix copyright notices
3 months, 2 weeks ago (2018-01-31 09:17:10 UTC) #7
reviewbot
https://codereview.tryton.org/43051002/diff/60001/setup.py#newcode87 setup.py:87: E501 line too long (85 > 79 characters) https://codereview.tryton.org/43051002/diff/60001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
3 months, 2 weeks ago (2018-01-31 09:28:14 UTC) #8
ced
https://codereview.tryton.org/43051002/diff/60001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/43051002/diff/60001/doc/index.rst#newcode1 doc/index.rst:1: Account Statement Aeb43 Module Aeb43 is not an abbreviation? ...
2 months, 2 weeks ago (2018-03-07 16:42:53 UTC) #9
pokoli
Fix most comments
2 months, 1 week ago (2018-03-14 11:19:03 UTC) #10
pokoli
https://codereview.tryton.org/43051002/diff/60001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/43051002/diff/60001/doc/index.rst#newcode5 doc/index.rst:5: <https://www.caixabank.es/deployedfiles/empresas/Estaticos/pdf/Transferenciasyficheros/q43Junio2012.pdf>`_ On 2018/03/07 16:42:51, ced wrote: > I do ...
2 months, 1 week ago (2018-03-14 11:19:25 UTC) #11
reviewbot
https://codereview.tryton.org/43051002/diff/80001/setup.py#newcode87 setup.py:87: E501 line too long (85 > 79 characters) https://codereview.tryton.org/43051002/diff/80001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
2 months, 1 week ago (2018-03-14 11:22:32 UTC) #12
ced
https://codereview.tryton.org/43051002/diff/60001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/43051002/diff/60001/doc/index.rst#newcode5 doc/index.rst:5: <https://www.caixabank.es/deployedfiles/empresas/Estaticos/pdf/Transferenciasyficheros/q43Junio2012.pdf>`_ On 2018/03/14 11:19:25, pokoli wrote: > On 2018/03/07 ...
2 months, 1 week ago (2018-03-14 14:20:48 UTC) #13
pokoli
Test with a file with only one origin and use ascii encoding by default
2 months ago (2018-03-20 13:38:04 UTC) #14
reviewbot
https://codereview.tryton.org/43051002/diff/100001/setup.py#newcode87 setup.py:87: E501 line too long (85 > 79 characters) https://codereview.tryton.org/43051002/diff/100001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
2 months ago (2018-03-20 13:55:32 UTC) #15
pokoli
Use csb43 library to parse the file
2 months ago (2018-03-21 09:09:23 UTC) #16
pokoli
https://codereview.tryton.org/43051002/diff/60001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/43051002/diff/60001/doc/index.rst#newcode5 doc/index.rst:5: <https://www.caixabank.es/deployedfiles/empresas/Estaticos/pdf/Transferenciasyficheros/q43Junio2012.pdf>`_ On 2018/03/14 14:20:48, ced wrote: > On 2018/03/14 ...
2 months ago (2018-03-21 09:10:16 UTC) #17
pokoli
https://codereview.tryton.org/43051002/diff/60001/statement.py File statement.py (right): https://codereview.tryton.org/43051002/diff/60001/statement.py#newcode78 statement.py:78: 'end_date': datetime.strptime(header[26:32], '%y%m%d').date(), On 2018/03/14 14:20:48, ced wrote: > ...
2 months ago (2018-03-21 09:12:11 UTC) #18
reviewbot
https://codereview.tryton.org/43051002/diff/120001/setup.py#newcode87 setup.py:87: E501 line too long (85 > 79 characters) https://codereview.tryton.org/43051002/diff/120001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
2 months ago (2018-03-21 09:14:50 UTC) #19
ced
https://codereview.tryton.org/43051002/diff/60001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/43051002/diff/60001/doc/index.rst#newcode5 doc/index.rst:5: <https://www.caixabank.es/deployedfiles/empresas/Estaticos/pdf/Transferenciasyficheros/q43Junio2012.pdf>`_ On 2018/03/21 09:10:16, pokoli wrote: > On 2018/03/14 ...
2 months ago (2018-03-21 12:59:16 UTC) #20
pokoli
Use python api instead of converting as dict and fix metaclass possition
2 months ago (2018-03-21 16:52:41 UTC) #21
pokoli
https://codereview.tryton.org/43051002/diff/60001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/43051002/diff/60001/doc/index.rst#newcode5 doc/index.rst:5: <https://www.caixabank.es/deployedfiles/empresas/Estaticos/pdf/Transferenciasyficheros/q43Junio2012.pdf>`_ On 2018/03/21 12:59:14, ced wrote: > On 2018/03/21 ...
2 months ago (2018-03-21 16:52:48 UTC) #22
ced
https://codereview.tryton.org/43051002/diff/60001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/43051002/diff/60001/doc/index.rst#newcode5 doc/index.rst:5: <https://www.caixabank.es/deployedfiles/empresas/Estaticos/pdf/Transferenciasyficheros/q43Junio2012.pdf>`_ On 2018/03/21 16:52:48, pokoli wrote: > On 2018/03/21 ...
2 months ago (2018-03-21 17:11:16 UTC) #23
reviewbot
https://codereview.tryton.org/43051002/diff/140001/setup.py#newcode87 setup.py:87: E501 line too long (85 > 79 characters) https://codereview.tryton.org/43051002/diff/140001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
2 months ago (2018-03-21 17:13:18 UTC) #24
ced
https://codereview.tryton.org/43051002/diff/120001/statement.py File statement.py (right): https://codereview.tryton.org/43051002/diff/120001/statement.py#newcode96 statement.py:96: origin.amount = Decimal(str(transaction['amount'])) On 2018/03/21 16:52:48, pokoli wrote: > ...
2 months ago (2018-03-21 18:35:18 UTC) #25
pokoli
https://codereview.tryton.org/43051002/diff/120001/statement.py File statement.py (right): https://codereview.tryton.org/43051002/diff/120001/statement.py#newcode96 statement.py:96: origin.amount = Decimal(str(transaction['amount'])) On 2018/03/21 18:35:18, ced wrote: > ...
1 month, 4 weeks ago (2018-03-22 08:54:19 UTC) #26
pokoli
Fix comments and update to tip
3 weeks, 2 days ago (2018-04-27 11:49:56 UTC) #27
pokoli
https://codereview.tryton.org/43051002/diff/120001/statement.py File statement.py (right): https://codereview.tryton.org/43051002/diff/120001/statement.py#newcode96 statement.py:96: origin.amount = Decimal(str(transaction['amount'])) On 2018/03/22 08:54:18, pokoli wrote: > ...
3 weeks, 2 days ago (2018-04-27 11:51:59 UTC) #28
reviewbot
https://codereview.tryton.org/43051002/diff/160001/setup.py#newcode87 setup.py:87: E501 line too long (85 > 79 characters) https://codereview.tryton.org/43051002/diff/160001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
3 weeks, 2 days ago (2018-04-27 12:00:30 UTC) #29
ced
https://codereview.tryton.org/43051002/diff/160001/doc/index.rst File doc/index.rst (right): https://codereview.tryton.org/43051002/diff/160001/doc/index.rst#newcode5 doc/index.rst:5: <https://downloads.tryton.org/aeb43.pdf>`_ of the spanish banks association Is it not ...
1 week, 6 days ago (2018-05-07 13:40:13 UTC) #30
pokoli
Fix ced's comments
1 week, 4 days ago (2018-05-09 07:56:07 UTC) #31
reviewbot
https://codereview.tryton.org/43051002/diff/180001/setup.py#newcode74 setup.py:74: E901 SyntaxError: invalid syntax https://codereview.tryton.org/43051002/diff/180001/setup.py#newcode73 setup.py:73: E501 line too long (84 > 79 ...
1 week, 4 days ago (2018-05-09 08:13:31 UTC) #32
pokoli
Disable strict mode
1 week, 2 days ago (2018-05-11 15:17:33 UTC) #33
reviewbot
https://codereview.tryton.org/43051002/diff/200001/setup.py#newcode74 setup.py:74: E901 SyntaxError: invalid syntax https://codereview.tryton.org/43051002/diff/200001/setup.py#newcode73 setup.py:73: E501 line too long (84 > 79 ...
1 week, 2 days ago (2018-05-11 15:41:46 UTC) #34
ced
https://codereview.tryton.org/43051002/diff/200001/statement.py File statement.py (right): https://codereview.tryton.org/43051002/diff/200001/statement.py#newcode40 statement.py:40: aeb43 = csb43.File(StringIO(file_), strict=False) I think it could be ...
1 week, 2 days ago (2018-05-11 23:13:41 UTC) #35
pokoli
https://codereview.tryton.org/43051002/diff/200001/statement.py File statement.py (right): https://codereview.tryton.org/43051002/diff/200001/statement.py#newcode40 statement.py:40: aeb43 = csb43.File(StringIO(file_), strict=False) On 2018/05/11 23:13:41, ced wrote: ...
1 week, 1 day ago (2018-05-12 18:34:57 UTC) #36
ced
https://codereview.tryton.org/43051002/diff/200001/statement.py File statement.py (right): https://codereview.tryton.org/43051002/diff/200001/statement.py#newcode40 statement.py:40: aeb43 = csb43.File(StringIO(file_), strict=False) On 2018/05/12 18:34:57, pokoli wrote: ...
1 week, 1 day ago (2018-05-12 21:55:50 UTC) #37
pokoli
On 2018/05/12 21:55:50, ced wrote: > https://codereview.tryton.org/43051002/diff/200001/statement.py > File statement.py (right): > > https://codereview.tryton.org/43051002/diff/200001/statement.py#newcode40 > ...
6 days, 21 hours ago (2018-05-14 08:59:32 UTC) #38
ced
On 2018/05/14 08:59:32, pokoli wrote: > On 2018/05/12 21:55:50, ced wrote: > > > > ...
6 days, 21 hours ago (2018-05-14 09:10:01 UTC) #39
ced
https://codereview.tryton.org/43051002/diff/200001/INSTALL File INSTALL (right): https://codereview.tryton.org/43051002/diff/200001/INSTALL#newcode12 INSTALL:12: * csb43 (https://bitbucket.org/wmj/csb43) I can not find on PyPI.
6 days, 21 hours ago (2018-05-14 09:13:22 UTC) #40
pokoli
https://codereview.tryton.org/43051002/diff/200001/INSTALL File INSTALL (right): https://codereview.tryton.org/43051002/diff/200001/INSTALL#newcode12 INSTALL:12: * csb43 (https://bitbucket.org/wmj/csb43) On 2018/05/14 09:13:22, ced wrote: > ...
6 days, 21 hours ago (2018-05-14 09:20:38 UTC) #41
ced
6 days, 21 hours ago (2018-05-14 09:41:45 UTC) #42
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922