Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(381)

Issue 43071002: project_invoice: Allow to invoice subproject with a different party (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 3 weeks ago by nicoe
Modified:
2 months, 1 week ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 : reupload with .rst file #

Patch Set 2 : Add .rst to setup.py #

Total comments: 1

Patch Set 3 : remove payment_term from scenario #

Total comments: 2

Patch Set 4 : fix CHANGELOG message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -4 lines) Patch
M CHANGELOG View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M setup.py View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/scenario_project_invoice_multiple_party.rst View 1 2 1 chunk +120 lines, -0 lines 0 comments Download
M tests/test_project_invoice.py View 1 chunk +5 lines, -0 lines 0 comments Download
M work.py View 1 2 3 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 19
nicoe
3 months, 3 weeks ago (2018-01-29 18:08:06 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/43071002
3 months, 3 weeks ago (2018-01-29 18:17:07 UTC) #2
ced
Can not review the rst. https://codereview.tryton.org/43071002/diff/1/work.py File work.py (left): https://codereview.tryton.org/43071002/diff/1/work.py#oldcode527 work.py:527: 'description': self.name, In another ...
3 months, 3 weeks ago (2018-01-29 18:18:39 UTC) #3
nicoe
reupload with .rst file
3 months, 2 weeks ago (2018-01-30 10:58:13 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/43071002
3 months, 2 weeks ago (2018-01-30 11:20:08 UTC) #5
ced
Still can not review the rst.
3 months, 1 week ago (2018-02-06 11:44:59 UTC) #6
pokoli
rst file should be added on setup.py in order to make it 2to3 convert it ...
3 months, 1 week ago (2018-02-06 13:37:10 UTC) #7
nicoe
Add .rst to setup.py
3 months, 1 week ago (2018-02-06 17:02:07 UTC) #8
nicoe
On 2018/02/06 11:44:59, ced wrote: > Still can not review the rst. You can click ...
3 months, 1 week ago (2018-02-06 17:05:51 UTC) #9
reviewbot
https://codereview.tryton.org/43071002/diff/40001/setup.py#newcode87 setup.py:87: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/43071002
3 months, 1 week ago (2018-02-06 17:20:09 UTC) #10
pokoli
https://codereview.tryton.org/43071002/diff/40001/tests/scenario_project_invoice_multiple_party.rst File tests/scenario_project_invoice_multiple_party.rst (right): https://codereview.tryton.org/43071002/diff/40001/tests/scenario_project_invoice_multiple_party.rst#newcode35 tests/scenario_project_invoice_multiple_party.rst:35: Create payment term:: Payment term is no more required, ...
3 months, 1 week ago (2018-02-07 10:30:25 UTC) #11
nicoe
remove payment_term from scenario
3 months, 1 week ago (2018-02-07 12:25:51 UTC) #12
reviewbot
https://codereview.tryton.org/43071002/diff/60001/setup.py#newcode87 setup.py:87: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/43071002
3 months, 1 week ago (2018-02-07 12:47:40 UTC) #13
ced
The rest is still not diffable. https://codereview.tryton.org/43071002/diff/60001/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/43071002/diff/60001/CHANGELOG#newcode1 CHANGELOG:1: * Allow to ...
3 months, 1 week ago (2018-02-12 23:49:54 UTC) #14
nicoe
fix CHANGELOG message
2 months, 3 weeks ago (2018-02-28 12:40:03 UTC) #15
nicoe
https://codereview.tryton.org/43071002/diff/60001/CHANGELOG File CHANGELOG (right): https://codereview.tryton.org/43071002/diff/60001/CHANGELOG#newcode1 CHANGELOG:1: * Allow to invoice subproject with a different party ...
2 months, 3 weeks ago (2018-02-28 12:40:14 UTC) #16
reviewbot
https://codereview.tryton.org/43071002/diff/80001/setup.py#newcode87 setup.py:87: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/43071002
2 months, 3 weeks ago (2018-02-28 12:51:26 UTC) #17
ced
LGTM
2 months, 3 weeks ago (2018-02-28 13:36:48 UTC) #18
rietveld-bot_tryton.org
2 months, 1 week ago (2018-03-10 11:49:07 UTC) #19
New changeset c81e597b6369 by Nicolas Évrard in branch 'default':
Allow to invoice sub-project with a different party
http://hg.tryton.org/modules/project_invoice/rev/c81e597b6369
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922