analytic_account: Add company domain on AnalyticMixin analytic accounts

Ensure that the accounts of the analytic mixin are only linked to the 
company of the parent

issue7198

[reviewbot, 2018-03-08 10:24:37]

https://codereview.tryton.org/43211002/diff/1/account.py#newcode215
account.py:215:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/43211002/diff/1/account.py#newcode270
account.py:270:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/43211002/diff/1/account.py#newcode536
account.py:536:
E711 comparison to None should be 'if cond is not None:'

URL: https://codereview.tryton.org/43211002

[ced, 2018-03-08 10:39:02]

https://codereview.tryton.org/43211002/diff/1/account.py
File account.py (right):

https://codereview.tryton.org/43211002/diff/1/account.py#newcode507
account.py:507: ],
It is wrong to use context for domain. It should use a company field of the
Model.

[pokoli, 2018-04-18 08:32:40]

Use company field of the model

[ced, 2018-04-18 08:55:23]

https://codereview.tryton.org/43211002/diff/20001/account.py
File account.py (right):

https://codereview.tryton.org/43211002/diff/20001/account.py#newcode510
account.py:510: if hasattr(cls, 'company'):
It does not ensure that company is actually the field we want.
I think this must probably be set case be case. Or at least the name 'company'
should be modifiable.
Also I think it must fail if the field does not exist as I do not think there
are cases where the mixin will fill different companies.

[ced, 2018-04-18 08:56:00]

Also I think the description should explain what the domain addition is fixing.

[reviewbot, 2018-04-18 08:56:32]

https://codereview.tryton.org/43211002/diff/20001/account.py#newcode13
account.py:13:
F401 'Bool' imported but unused

https://codereview.tryton.org/43211002/diff/20001/account.py#newcode210
account.py:210:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/43211002/diff/20001/account.py#newcode266
account.py:266:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/43211002/diff/20001/account.py#newcode533
account.py:533:
E711 comparison to None should be 'if cond is not None:'

URL: https://codereview.tryton.org/43211002

[pokoli, 2018-05-21 09:57:43]

Fail if no company field and allow to configure the field name

[reviewbot, 2018-05-21 10:19:59]

https://codereview.tryton.org/43211002/diff/40001/account.py#newcode211
account.py:211:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/43211002/diff/40001/account.py#newcode267
account.py:267:
E712 comparison to True should be 'if cond is True:' or 'if cond:'

https://codereview.tryton.org/43211002/diff/40001/account.py#newcode537
account.py:537:
E711 comparison to None should be 'if cond is not None:'

URL: https://codereview.tryton.org/43211002

[ced, 2018-05-23 21:39:22]

https://codereview.tryton.org/43211002/diff/40001/account.py
File account.py (right):

https://codereview.tryton.org/43211002/diff/40001/account.py#newcode516
account.py:516: 'Missing analytic company on analytic mixin %s' % cls.__name__)
When could this happen? The attribute is defined in the mixin.

https://codereview.tryton.org/43211002/diff/40001/account.py#newcode517
account.py:517: cls.analytic_accounts.domain.append(
You can not happen like that because you do not know if the current list is
AND-ed or OR-ed.