Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 433141003: tryton-env: Select the clicked line when activating a button in list view

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 2 weeks ago by nicoe
Modified:
2 weeks ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

tryton-env: Select the clicked line when activating a button in list view issue11212

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tryton/tryton/gui/window/view_form/view/list_gtk/widget.py View 1 chunk +8 lines, -0 lines 5 comments Download

Messages

Total messages: 7
nicoe
1 month, 2 weeks ago (2022-05-19 14:36:19 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/433141003
1 month, 2 weeks ago (2022-05-19 14:47:31 UTC) #2
ced
https://codereview.tryton.org/433141003/diff/421181003/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/433141003/diff/421181003/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode1305 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:1305: return True Why not do like sao and just ...
1 month, 2 weeks ago (2022-05-20 05:43:05 UTC) #3
nicoe
https://codereview.tryton.org/433141003/diff/421181003/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/433141003/diff/421181003/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode1305 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:1305: return True On 2022/05/20 05:43:05, ced wrote: > Why ...
1 month ago (2022-05-30 18:27:12 UTC) #4
ced
https://codereview.tryton.org/433141003/diff/421181003/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/433141003/diff/421181003/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode1305 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:1305: return True On 2022/05/30 18:27:12, nicoe wrote: > On ...
1 month ago (2022-06-01 21:29:11 UTC) #5
nicoe
https://codereview.tryton.org/433141003/diff/421181003/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right): https://codereview.tryton.org/433141003/diff/421181003/tryton/tryton/gui/window/view_form/view/list_gtk/widget.py#newcode1305 tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:1305: return True On 2022/06/01 21:29:10, ced wrote: > On ...
2 weeks, 1 day ago (2022-06-20 15:57:37 UTC) #6
ced
2 weeks ago (2022-06-20 21:28:03 UTC) #7
https://codereview.tryton.org/433141003/diff/421181003/tryton/tryton/gui/wind...
File tryton/tryton/gui/window/view_form/view/list_gtk/widget.py (right):

https://codereview.tryton.org/433141003/diff/421181003/tryton/tryton/gui/wind...
tryton/tryton/gui/window/view_form/view/list_gtk/widget.py:1305: return True
On 2022/06/20 15:57:37, nicoe wrote:
> On 2022/06/01 21:29:10, ced wrote:
> > On 2022/05/30 18:27:12, nicoe wrote:
> > > On 2022/05/20 05:43:05, ced wrote:
> > > > Why not do like sao and just stop if record different of screen current
> > > record?
> > > 
> > > I don't know, I thought GTK behaved by default differently.
> > > I guess it should be tested.
> > 
> > For me we must always try to have the same behavior between clients.
> 
> I kind of agree but it's complicated eg: the left menu on sao will open the
> action on selection while in GTK a double click is required.

We should have the same behavior each time it is possible.
 
> So I wonder if in this case it's not the same but I don't know really what's
the
> standard behaviour on this and a search on the internet didn't provide much
info
> either.

There is no standard behavior. But the current behavior of tryton ensures that
record is saved when button is clicked.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted