Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 43571002: sao: add missing tooltips for toolbars' buttons and xxx2M fields

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 2 days ago by fmorato
Modified:
2 weeks, 1 day ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 7

Patch Set 2 : Implement cedk's suggestions and explain data-original-title #

Patch Set 3 : Finish call gettext only once per button. Set bookmark button tooltip placement top #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -48 lines) Patch
M src/screen.js View 1 2 4 chunks +42 lines, -13 lines 0 comments Download
M src/view/form.js View 1 2 9 chunks +132 lines, -35 lines 0 comments Download

Messages

Total messages: 7
fmorato
2 weeks, 2 days ago (2017-10-06 19:34:03 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/43571002
2 weeks, 2 days ago (2017-10-06 19:40:53 UTC) #2
ced
https://codereview.tryton.org/43571002/diff/1/src/screen.js File src/screen.js (right): https://codereview.tryton.org/43571002/diff/1/src/screen.js#newcode49 src/screen.js:49: 'aria-label': Sao.i18n.gettext('Search') Would be better to ensure we use ...
2 weeks, 2 days ago (2017-10-06 22:37:53 UTC) #3
fmorato
Implement cedk's suggestions and explain data-original-title
2 weeks, 1 day ago (2017-10-07 16:26:08 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/43571002
2 weeks, 1 day ago (2017-10-07 16:46:08 UTC) #5
fmorato
Finish call gettext only once per button. Set bookmark button tooltip placement top
2 weeks, 1 day ago (2017-10-07 17:04:39 UTC) #6
reviewbot
2 weeks, 1 day ago (2017-10-07 17:17:56 UTC) #7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842