Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 435841003: tryton-env: Process shipments and invoices one by one when grouping (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by pokoli
Modified:
3 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

issue11685 COLLABORATOR=cedric.krier@b2ck.com

Patch Set 1 #

Total comments: 12

Patch Set 2 : Fix remarks #

Patch Set 3 : Simplify design #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -0 lines) Patch
M modules/sale_invoice_grouping/sale.py View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
A modules/sale_invoice_grouping/tests/scenario_sale_invoice_grouping_multiple.rst View 1 2 1 chunk +103 lines, -0 lines 0 comments Download
M modules/sale_shipment_grouping/sale.py View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
A modules/sale_shipment_grouping/tests/scenario_sale_shipment_grouping_multiple.rst View 1 2 1 chunk +107 lines, -0 lines 0 comments Download

Messages

Total messages: 14
pokoli
4 months, 1 week ago (2022-09-23 18:04:05 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/435841003
4 months, 1 week ago (2022-09-23 18:15:14 UTC) #2
ced
https://codereview.tryton.org/435841003/diff/427821003/modules/sale/sale.py File modules/sale/sale.py (right): https://codereview.tryton.org/435841003/diff/427821003/modules/sale/sale.py#newcode1030 modules/sale/sale.py:1030: shipments = ShipmentOut.browse(set(map(int, shipments))) I do not see the ...
4 months, 1 week ago (2022-09-23 21:43:54 UTC) #3
pokoli
Fix remarks
4 months, 1 week ago (2022-09-26 11:07:55 UTC) #4
pokoli
https://codereview.tryton.org/435841003/diff/427821003/modules/sale/sale.py File modules/sale/sale.py (right): https://codereview.tryton.org/435841003/diff/427821003/modules/sale/sale.py#newcode1030 modules/sale/sale.py:1030: shipments = ShipmentOut.browse(set(map(int, shipments))) On 2022/09/23 21:43:53, ced wrote: ...
4 months, 1 week ago (2022-09-26 11:08:16 UTC) #5
reviewbot
checks OK URL: https://codereview.tryton.org/435841003
4 months, 1 week ago (2022-09-26 11:34:12 UTC) #6
ced
https://codereview.tryton.org/435841003/diff/427821003/modules/sale/sale.py File modules/sale/sale.py (right): https://codereview.tryton.org/435841003/diff/427821003/modules/sale/sale.py#newcode1030 modules/sale/sale.py:1030: shipments = ShipmentOut.browse(set(map(int, shipments))) On 2022/09/26 11:08:15, pokoli wrote: ...
4 months, 1 week ago (2022-09-26 11:52:24 UTC) #7
ced
3 months, 1 week ago (2022-10-23 21:59:49 UTC) #8
reviewbot
checks OK URL: https://codereview.tryton.org/435841003
3 months, 1 week ago (2022-10-23 22:11:51 UTC) #9
rietveld-bot_tryton.org
New changeset b783324efce5 by Cédric Krier in branch 'default': Process invoices one by one when ...
3 months, 1 week ago (2022-10-27 22:33:02 UTC) #10
rietveld-bot_tryton.org
New changeset b6ce941ef786 by Cédric Krier in branch 'default': Process shipments one by one when ...
3 months, 1 week ago (2022-10-27 22:33:15 UTC) #11
rietveld-bot_tryton.org
New changeset 6025fbb2f018 by Cédric Krier in branch 'default': Process invoices one by one when ...
3 months, 1 week ago (2022-10-27 22:33:22 UTC) #12
rietveld-bot_tryton.org
New changeset 70991f1d23ed by Cédric Krier in branch '6.4': Process invoices one by one when ...
3 months ago (2022-10-30 09:37:34 UTC) #13
rietveld-bot_tryton.org
3 months ago (2022-10-30 09:38:07 UTC) #14
New changeset 701058e8efd0 by Cédric Krier in branch '6.4':
Process shipments one by one when grouping
https://hg.tryton.org/modules/sale_shipment_grouping/rev/701058e8efd0


New changeset 0cd1bf65390d by Cédric Krier in branch '6.2':
Process shipments one by one when grouping
https://hg.tryton.org/modules/sale_shipment_grouping/rev/0cd1bf65390d
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted