tryton-env: Process shipments and invoices one by one when grouping

issue11685

COLLABORATOR=cedric.krier@b2ck.com

[reviewbot, 2022-09-23 18:15:14]

checks OK
URL: https://codereview.tryton.org/435841003

[ced, 2022-09-23 21:43:54]

https://codereview.tryton.org/435841003/diff/427821003/modules/sale/sale.py
File modules/sale/sale.py (right):

https://codereview.tryton.org/435841003/diff/427821003/modules/sale/sale.py#n...
modules/sale/sale.py:1030: shipments = ShipmentOut.browse(set(map(int,
shipments)))
I do not see the point.

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_invoice_g...
File modules/sale_invoice_grouping/sale.py (right):

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_invoice_g...
modules/sale_invoice_grouping/sale.py:52: invoice, = grouped_invoices
Why not make the save here and avoid the variable name change.

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_invoice_g...
File
modules/sale_invoice_grouping/tests/scenario_sale_invoice_grouping_multiple.rst
(right):

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_invoice_g...
modules/sale_invoice_grouping/tests/scenario_sale_invoice_grouping_multiple.rst:23:
>>> config = activate_modules('sale_invoice_grouping')
better to leave an empty line

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_invoice_g...
modules/sale_invoice_grouping/tests/scenario_sale_invoice_grouping_multiple.rst:85:
>>> sale.click('confirm')
The point of the test is to confirm both together

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_invoice_g...
modules/sale_invoice_grouping/tests/scenario_sale_invoice_grouping_multiple.rst:105:

trailing line

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_shipment_...
File modules/sale_shipment_grouping/sale.py (right):

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_shipment_...
modules/sale_shipment_grouping/sale.py:58: shipment, = grouped_shipments
Why not save here?

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_shipment_...
File
modules/sale_shipment_grouping/tests/scenario_sale_shipment_grouping_multiple.rst
(right):

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_shipment_...
modules/sale_shipment_grouping/tests/scenario_sale_shipment_grouping_multiple.rst:85:
>>> sale.click('confirm')
idem

[pokoli, 2022-09-26 11:07:55]

Fix remarks

[pokoli, 2022-09-26 11:08:16]

https://codereview.tryton.org/435841003/diff/427821003/modules/sale/sale.py
File modules/sale/sale.py (right):

https://codereview.tryton.org/435841003/diff/427821003/modules/sale/sale.py#n...
modules/sale/sale.py:1030: shipments = ShipmentOut.browse(set(map(int,
shipments)))
On 2022/09/23 21:43:53, ced wrote:
> I do not see the point.

Otherwise I get a duplicaterecords with the new scenario because same shipment
is returned for both sales.

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_invoice_g...
File modules/sale_invoice_grouping/sale.py (right):

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_invoice_g...
modules/sale_invoice_grouping/sale.py:52: invoice, = grouped_invoices
On 2022/09/23 21:43:53, ced wrote:
> Why not make the save here and avoid the variable name change.

Can not be saved here because here we have no lines and the domain searches for
lines origin. 

I removed the variable name change.

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_shipment_...
File modules/sale_shipment_grouping/sale.py (right):

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_shipment_...
modules/sale_shipment_grouping/sale.py:58: shipment, = grouped_shipments
On 2022/09/23 21:43:53, ced wrote:
> Why not save here?

We need to save after the shipment has moves otherwise the origin domain fails
and sceanrio is broken.

[reviewbot, 2022-09-26 11:34:12]

checks OK
URL: https://codereview.tryton.org/435841003

[ced, 2022-09-26 11:52:24]

https://codereview.tryton.org/435841003/diff/427821003/modules/sale/sale.py
File modules/sale/sale.py (right):

https://codereview.tryton.org/435841003/diff/427821003/modules/sale/sale.py#n...
modules/sale/sale.py:1030: shipments = ShipmentOut.browse(set(map(int,
shipments)))
On 2022/09/26 11:08:15, pokoli wrote:
> On 2022/09/23 21:43:53, ced wrote:
> > I do not see the point.
> 
> Otherwise I get a duplicaterecords with the new scenario because same shipment
> is returned for both sales. 

So something is wrong in the design.

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_shipment_...
File modules/sale_shipment_grouping/sale.py (right):

https://codereview.tryton.org/435841003/diff/427821003/modules/sale_shipment_...
modules/sale_shipment_grouping/sale.py:78:
ShipmentOutReturn.save(shipments_return)
Normally you can deduce the shipment from the shipment_type

[reviewbot, 2022-10-23 22:11:51]

checks OK
URL: https://codereview.tryton.org/435841003

[rietveld-bot_tryton.org, 2022-10-27 22:33:02]

New changeset b783324efce5 by Cédric Krier in branch 'default':
Process invoices one by one when grouping
https://hg.tryton.org/modules/sale_invoice_grouping/rev/b783324efce5


New changeset 1b6826e088f7 by Cédric Krier in branch 'default':
Add scenario to test grouping when sale is processing is grouped
https://hg.tryton.org/modules/sale_invoice_grouping/rev/1b6826e088f7

[rietveld-bot_tryton.org, 2022-10-27 22:33:15]

New changeset b6ce941ef786 by Cédric Krier in branch 'default':
Process shipments one by one when grouping
https://hg.tryton.org/modules/sale_shipment_grouping/rev/b6ce941ef786


New changeset a2229e9c4202 by Cédric Krier in branch 'default':
Add scenario to test grouping when sale is processing is grouped
https://hg.tryton.org/modules/sale_shipment_grouping/rev/a2229e9c4202

[rietveld-bot_tryton.org, 2022-10-27 22:33:22]

New changeset 6025fbb2f018 by Cédric Krier in branch 'default':
Process invoices one by one when grouping
https://hg.tryton.org/tryton-env/rev/6025fbb2f018


New changeset 0fe2d70aed6a by Cédric Krier in branch 'default':
Process shipments one by one when grouping
https://hg.tryton.org/tryton-env/rev/0fe2d70aed6a


New changeset e1bd70a460b8 by Cédric Krier in branch 'default':
Add scenario to test grouping when sale is processing is grouped
https://hg.tryton.org/tryton-env/rev/e1bd70a460b8

[rietveld-bot_tryton.org, 2022-10-30 09:37:34]

New changeset 70991f1d23ed by Cédric Krier in branch '6.4':
Process invoices one by one when grouping
https://hg.tryton.org/modules/sale_invoice_grouping/rev/70991f1d23ed


New changeset 793387502c52 by Cédric Krier in branch '6.2':
Process invoices one by one when grouping
https://hg.tryton.org/modules/sale_invoice_grouping/rev/793387502c52

[rietveld-bot_tryton.org, 2022-10-30 09:38:07]

New changeset 701058e8efd0 by Cédric Krier in branch '6.4':
Process shipments one by one when grouping
https://hg.tryton.org/modules/sale_shipment_grouping/rev/701058e8efd0


New changeset 0cd1bf65390d by Cédric Krier in branch '6.2':
Process shipments one by one when grouping
https://hg.tryton.org/modules/sale_shipment_grouping/rev/0cd1bf65390d