tryton-env: Add header parameter on export data

issue9301

[reviewbot, 2022-05-25 15:54:40]

checks OK
URL: https://codereview.tryton.org/439151003

[ced, 2022-06-17 09:57:44]

https://codereview.tryton.org/439151003/diff/417251003/sao/src/window.js
File sao/src/window.js (right):

https://codereview.tryton.org/439151003/diff/417251003/sao/src/window.js#newc...
sao/src/window.js:2008: domain, fields, hedar, offset, limit,
header

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/ir/exp...
File trytond/trytond/ir/export.py (right):

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/ir/exp...
trytond/trytond/ir/export.py:31: header = fields.Boolean("Header",
break line on opening (

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/ir/exp...
trytond/trytond/ir/export.py:32: help="If set the field names will be included
on the export.")
Use present in help text: If set ... are included...

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/ir/mes...
File trytond/trytond/ir/message.xml (right):

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/ir/mes...
trytond/trytond/ir/message.xml:394: <field name="text">%(field)s
(String)</field>
use lower case like in client

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/ir/mes...
trytond/trytond/ir/message.xml:397: <field name="text">%(field)s (Model
Name)</field>
idem

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/ir/vie...
File trytond/trytond/ir/view/export_form.xml (right):

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/ir/vie...
trytond/trytond/ir/view/export_form.xml:6: <field name="name"/>
Maybe good to add a colspan 3

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/model/...
File trytond/trytond/model/modelstorage.py (right):

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/model/...
trytond/trytond/model/modelstorage.py:749: field_name =
name.replace('.translated', '')
it will be safer to ensure that it is at the end.

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/model/...
trytond/trytond/model/modelstorage.py:758: 'ir.msg_field_model_name',
field=field_name)
We may need a special case for reference/rec_name as the header in client is
lower case.

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/model/...
trytond/trytond/model/modelstorage.py:777: cls, domain, fields_names,
header=False, offset=0, limit=None,
safer to add new parameter at the end.

[pokoli, 2022-06-17 11:45:21]

Fix remarks

[pokoli, 2022-06-17 11:47:17]

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/model/...
File trytond/trytond/model/modelstorage.py (right):

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/model/...
trytond/trytond/model/modelstorage.py:758: 'ir.msg_field_model_name',
field=field_name)
On 2022/06/17 09:57:44, ced wrote:
> We may need a special case for reference/rec_name as the header in client is
> lower case.

Why should be in lower case? As the rec name is a field of the nested model I
think it is better to use it's descrption and this is what is done here. 

P.S: I added a test case to ensure it works as expected.

[reviewbot, 2022-06-17 11:58:46]

checks OK
URL: https://codereview.tryton.org/439151003

[ced, 2022-06-17 12:48:11]

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/model/...
File trytond/trytond/model/modelstorage.py (right):

https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/model/...
trytond/trytond/model/modelstorage.py:758: 'ir.msg_field_model_name',
field=field_name)
On 2022/06/17 11:47:16, pokoli wrote:
> On 2022/06/17 09:57:44, ced wrote:
> > We may need a special case for reference/rec_name as the header in client is
> > lower case.
> 
> Why should be in lower case? As the rec name is a field of the nested model I
> think it is better to use it's descrption and this is what is done here. 
> 
> P.S: I added a test case to ensure it works as expected.

Then client must behave the same.

[pokoli, 2022-06-20 10:31:17]

Use same record name on client and server

[reviewbot, 2022-06-20 10:37:38]

checks OK
URL: https://codereview.tryton.org/439151003

[ced, 2022-06-20 21:41:48]

https://codereview.tryton.org/439151003/diff/441201004/tryton/tryton/gui/wind...
File tryton/tryton/gui/window/win_export.py (right):

https://codereview.tryton.org/439151003/diff/441201004/tryton/tryton/gui/wind...
tryton/tryton/gui/window/win_export.py:166: _("%s/Record Name)") % string_))
there is a trailing )

https://codereview.tryton.org/439151003/diff/441201004/trytond/trytond/ir/exp...
File trytond/trytond/ir/export.py (right):

https://codereview.tryton.org/439151003/diff/441201004/trytond/trytond/ir/exp...
trytond/trytond/ir/export.py:32: "Header", help="Check to include field names on
the export.")
style is to put help on a new line.

https://codereview.tryton.org/439151003/diff/441201004/trytond/trytond/model/...
File trytond/trytond/model/modelstorage.py (right):

https://codereview.tryton.org/439151003/diff/441201004/trytond/trytond/model/...
trytond/trytond/model/modelstorage.py:752: translated = True
It will be cleaner like this:

translated = name.endswith('.translated')
if translated:
    name = name[:-len('.translated')]

https://codereview.tryton.org/439151003/diff/441201004/trytond/trytond/tests/...
File trytond/trytond/tests/test_routes.py (right):

https://codereview.tryton.org/439151003/diff/441201004/trytond/trytond/tests/...
trytond/trytond/tests/test_routes.py:172:
b'Nomn*Identifiant*\r\n*Administrator*n*admin*\r\n')
This is a strange value.

[pokoli, 2022-06-27 13:56:35]

Fix remarks

[pokoli, 2022-06-27 13:56:50]

https://codereview.tryton.org/439151003/diff/441201004/trytond/trytond/tests/...
File trytond/trytond/tests/test_routes.py (right):

https://codereview.tryton.org/439151003/diff/441201004/trytond/trytond/tests/...
trytond/trytond/tests/test_routes.py:172:
b'Nomn*Identifiant*\r\n*Administrator*n*admin*\r\n')
On 2022/06/20 21:41:48, ced wrote:
> This is a strange value.

This is because we are using
https://docs.python.org/3/library/csv.html?highlight=delimiter#csv.QUOTE_MINIMAL
which is de default quoting value. 

As the "Nom" string does not contain now the deliminter char (n) the value is
not quoted. But all other fields are quoted as they contain the n char.

[reviewbot, 2022-06-27 14:09:45]

checks OK
URL: https://codereview.tryton.org/439151003

[ced, 2022-06-28 13:30:57]

LGTM

[rietveld-bot_tryton.org, 2022-07-01 10:48:51]

New changeset 2fe23af89625 by Sergi Almacellas Abellana in branch 'default':
Add header parameter on export data
https://hg.tryton.org/sao/rev/2fe23af89625

[rietveld-bot_tryton.org, 2022-07-01 10:48:57]

New changeset b5a89e6c45ad by Sergi Almacellas Abellana in branch 'default':
Add header parameter on export data
https://hg.tryton.org/tryton/rev/b5a89e6c45ad

[rietveld-bot_tryton.org, 2022-07-01 10:49:03]

New changeset 6abb3942043f by Sergi Almacellas Abellana in branch 'default':
Add header parameter on export data
https://hg.tryton.org/trytond/rev/6abb3942043f

[rietveld-bot_tryton.org, 2022-07-01 10:49:12]

New changeset c227f8c05097 by Sergi Almacellas Abellana in branch 'default':
Add header parameter on export data
https://hg.tryton.org/tryton-env/rev/c227f8c05097