Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77)

Issue 439151003: tryton-env: Add header parameter on export data (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by pokoli
Modified:
4 days, 8 hours ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 11

Patch Set 2 : Fix remarks #

Patch Set 3 : Use same record name on client and server #

Total comments: 5

Patch Set 4 : Fix remarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -50 lines) Patch
M sao/src/tab.js View 1 chunk +2 lines, -2 lines 0 comments Download
M sao/src/window.js View 1 2 3 7 chunks +8 lines, -12 lines 0 comments Download
M tryton/tryton/gui/window/form.py View 2 chunks +1 line, -2 lines 0 comments Download
M tryton/tryton/gui/window/win_export.py View 1 2 3 8 chunks +10 lines, -12 lines 0 comments Download
M trytond/CHANGELOG View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M trytond/doc/ref/models.rst View 1 1 chunk +3 lines, -2 lines 0 comments Download
M trytond/trytond/ir/export.py View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M trytond/trytond/ir/message.xml View 1 1 chunk +6 lines, -0 lines 0 comments Download
M trytond/trytond/ir/routes.py View 1 1 chunk +2 lines, -4 lines 0 comments Download
M trytond/trytond/ir/view/export_form.xml View 1 1 chunk +3 lines, -1 line 0 comments Download
M trytond/trytond/model/modelstorage.py View 1 2 3 1 chunk +33 lines, -8 lines 0 comments Download
M trytond/trytond/model/modelview.py View 1 chunk +1 line, -1 line 0 comments Download
M trytond/trytond/tests/test_exportdata.py View 1 1 chunk +46 lines, -0 lines 0 comments Download
M trytond/trytond/tests/test_routes.py View 1 6 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 18
pokoli
1 month, 1 week ago (2022-05-25 15:36:55 UTC) #1
reviewbot
checks OK URL: https://codereview.tryton.org/439151003
1 month, 1 week ago (2022-05-25 15:54:40 UTC) #2
ced
https://codereview.tryton.org/439151003/diff/417251003/sao/src/window.js File sao/src/window.js (right): https://codereview.tryton.org/439151003/diff/417251003/sao/src/window.js#newcode2008 sao/src/window.js:2008: domain, fields, hedar, offset, limit, header https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/ir/export.py File trytond/trytond/ir/export.py ...
2 weeks, 4 days ago (2022-06-17 09:57:44 UTC) #3
pokoli
Fix remarks
2 weeks, 4 days ago (2022-06-17 11:45:21 UTC) #4
pokoli
https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/model/modelstorage.py File trytond/trytond/model/modelstorage.py (right): https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/model/modelstorage.py#newcode758 trytond/trytond/model/modelstorage.py:758: 'ir.msg_field_model_name', field=field_name) On 2022/06/17 09:57:44, ced wrote: > We ...
2 weeks, 4 days ago (2022-06-17 11:47:17 UTC) #5
reviewbot
checks OK URL: https://codereview.tryton.org/439151003
2 weeks, 4 days ago (2022-06-17 11:58:46 UTC) #6
ced
https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/model/modelstorage.py File trytond/trytond/model/modelstorage.py (right): https://codereview.tryton.org/439151003/diff/417251003/trytond/trytond/model/modelstorage.py#newcode758 trytond/trytond/model/modelstorage.py:758: 'ir.msg_field_model_name', field=field_name) On 2022/06/17 11:47:16, pokoli wrote: > On ...
2 weeks, 4 days ago (2022-06-17 12:48:11 UTC) #7
pokoli
Use same record name on client and server
2 weeks, 1 day ago (2022-06-20 10:31:17 UTC) #8
reviewbot
checks OK URL: https://codereview.tryton.org/439151003
2 weeks, 1 day ago (2022-06-20 10:37:38 UTC) #9
ced
https://codereview.tryton.org/439151003/diff/441201004/tryton/tryton/gui/window/win_export.py File tryton/tryton/gui/window/win_export.py (right): https://codereview.tryton.org/439151003/diff/441201004/tryton/tryton/gui/window/win_export.py#newcode166 tryton/tryton/gui/window/win_export.py:166: _("%s/Record Name)") % string_)) there is a trailing ) ...
2 weeks ago (2022-06-20 21:41:48 UTC) #10
pokoli
Fix remarks
1 week, 1 day ago (2022-06-27 13:56:35 UTC) #11
pokoli
https://codereview.tryton.org/439151003/diff/441201004/trytond/trytond/tests/test_routes.py File trytond/trytond/tests/test_routes.py (right): https://codereview.tryton.org/439151003/diff/441201004/trytond/trytond/tests/test_routes.py#newcode172 trytond/trytond/tests/test_routes.py:172: b'Nomn*Identifiant*\r\n*Administrator*n*admin*\r\n') On 2022/06/20 21:41:48, ced wrote: > This is ...
1 week, 1 day ago (2022-06-27 13:56:50 UTC) #12
reviewbot
checks OK URL: https://codereview.tryton.org/439151003
1 week, 1 day ago (2022-06-27 14:09:45 UTC) #13
ced
LGTM
1 week ago (2022-06-28 13:30:57 UTC) #14
rietveld-bot_tryton.org
New changeset 2fe23af89625 by Sergi Almacellas Abellana in branch 'default': Add header parameter on export ...
4 days, 8 hours ago (2022-07-01 10:48:51 UTC) #15
rietveld-bot_tryton.org
New changeset b5a89e6c45ad by Sergi Almacellas Abellana in branch 'default': Add header parameter on export ...
4 days, 8 hours ago (2022-07-01 10:48:57 UTC) #16
rietveld-bot_tryton.org
New changeset 6abb3942043f by Sergi Almacellas Abellana in branch 'default': Add header parameter on export ...
4 days, 8 hours ago (2022-07-01 10:49:03 UTC) #17
rietveld-bot_tryton.org
4 days, 8 hours ago (2022-07-01 10:49:12 UTC) #18
New changeset c227f8c05097 by Sergi Almacellas Abellana in branch 'default':
Add header parameter on export data
https://hg.tryton.org/tryton-env/rev/c227f8c05097
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d9ca037-tainted