Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(149)

Issue 43961002: account: Open general ledger accounts from Income Statement relate (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 2 weeks ago by pokoli
Modified:
6 months, 4 weeks ago
Reviewers:
udono, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove view file #

Patch Set 3 : ReAdd the open type wizard #

Total comments: 1

Patch Set 4 : Use context model to decide which action to trigger and add context model to account list #

Total comments: 3

Patch Set 5 : Include udono suggestions #

Total comments: 13

Patch Set 6 : Use unique function to build action values #

Patch Set 7 : Add changelog #

Patch Set 8 : Rename view ids and name #

Patch Set 9 : Use new context model for account balance sheet list #

Total comments: 6

Patch Set 10 : Fix ced's comments #

Total comments: 1

Patch Set 11 : Use all the field of context model + active_id #

Total comments: 2

Patch Set 12 : Skip id and support context_model not being set #

Total comments: 1

Patch Set 13 : Use generic method name #

Total comments: 1

Patch Set 14 : Copy all active_* keys #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -35 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M __init__.py View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -0 lines 0 comments Download
M account.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +57 lines, -10 lines 0 comments Download
M account.xml View 1 2 3 4 5 6 7 8 9 5 chunks +39 lines, -7 lines 0 comments Download
R view/account_list2.xml View 1 3 4 5 6 7 8 9 10 1 chunk +0 lines, -13 lines 0 comments Download
A view/account_list_balance_sheet.xml View 1 2 3 4 5 6 7 8 9 10 1 chunk +13 lines, -0 lines 0 comments Download
A view/balance_sheet_context_comparision_form.xml View 1 2 3 4 5 6 7 8 9 10 1 chunk +12 lines, -0 lines 0 comments Download
M view/balance_sheet_context_form.xml View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 46
pokoli
8 months, 2 weeks ago (2018-02-01 13:36:06 UTC) #1
pokoli
Remove view file
8 months, 2 weeks ago (2018-02-01 13:40:05 UTC) #2
reviewbot
https://codereview.tryton.org/43961002/diff/20001/account.py#newcode728 account.py:728: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
8 months, 2 weeks ago (2018-02-01 13:56:22 UTC) #3
pokoli
ReAdd the open type wizard
8 months, 2 weeks ago (2018-02-05 09:46:58 UTC) #4
reviewbot
https://codereview.tryton.org/43961002/diff/40001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/43961002/diff/40001/__init__.py#newcode6 __init__.py:6: ...
8 months, 2 weeks ago (2018-02-05 09:58:28 UTC) #5
ced
https://codereview.tryton.org/43961002/diff/40001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/40001/account.py#newcode319 account.py:319: parent = Type(Transaction().context['active_id']) Can not rely on the record ...
8 months, 2 weeks ago (2018-02-05 23:11:58 UTC) #6
pokoli
Use context model to decide which action to trigger and add context model to account ...
8 months, 2 weeks ago (2018-02-06 12:15:57 UTC) #7
reviewbot
https://codereview.tryton.org/43961002/diff/60001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/43961002/diff/60001/__init__.py#newcode6 __init__.py:6: ...
8 months, 2 weeks ago (2018-02-06 12:24:26 UTC) #8
udono
With my additions it works good for me. Thank you a lot! https://codereview.tryton.org/43961002/diff/60001/account.py File account.py ...
8 months ago (2018-02-13 19:25:27 UTC) #9
pokoli
Include udono suggestions
8 months ago (2018-02-14 08:53:46 UTC) #10
reviewbot
https://codereview.tryton.org/43961002/diff/80001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/43961002/diff/80001/__init__.py#newcode6 __init__.py:6: ...
8 months ago (2018-02-14 08:55:37 UTC) #11
udono
LGTM
8 months ago (2018-02-14 13:28:07 UTC) #12
ced
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode331 account.py:331: 'cumulate': Transaction().context.get('cumulate'), I think it is more flexible to ...
8 months ago (2018-02-14 18:17:10 UTC) #13
ced
Missing changelog entry.
8 months ago (2018-02-14 18:17:24 UTC) #14
udono
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode1679 account.py:1679: 'invisible': Eval('context', {}).get('date', False), On 2018/02/14 18:17:10, ced wrote: ...
8 months ago (2018-02-14 20:11:31 UTC) #15
ced
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode1679 account.py:1679: 'invisible': Eval('context', {}).get('date', False), On 2018/02/14 20:11:31, udono wrote: ...
8 months ago (2018-02-14 21:53:59 UTC) #16
pokoli
Use unique function to build action values
8 months ago (2018-02-15 16:20:00 UTC) #17
pokoli
Add changelog
8 months ago (2018-02-15 16:20:26 UTC) #18
reviewbot
https://codereview.tryton.org/43961002/diff/120001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/43961002/diff/120001/__init__.py#newcode6 __init__.py:6: ...
8 months ago (2018-02-15 16:24:03 UTC) #19
pokoli
Rename view ids and name
8 months ago (2018-02-15 16:24:50 UTC) #20
pokoli
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode331 account.py:331: 'cumulate': Transaction().context.get('cumulate'), On 2018/02/14 18:17:10, ced wrote: > I ...
8 months ago (2018-02-15 16:25:00 UTC) #21
ced
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode1679 account.py:1679: 'invisible': Eval('context', {}).get('date', False), On 2018/02/15 16:25:00, pokoli wrote: ...
8 months ago (2018-02-15 16:39:46 UTC) #22
ced
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode1679 account.py:1679: 'invisible': Eval('context', {}).get('date', False), On 2018/02/15 16:39:46, ced wrote: ...
8 months ago (2018-02-15 16:41:15 UTC) #23
pokoli
Use new context model for account balance sheet list
8 months ago (2018-02-15 16:51:26 UTC) #24
reviewbot
https://codereview.tryton.org/43961002/diff/140006/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/43961002/diff/140006/__init__.py#newcode6 __init__.py:6: ...
8 months ago (2018-02-15 16:52:32 UTC) #25
pokoli
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode1679 account.py:1679: 'invisible': Eval('context', {}).get('date', False), On 2018/02/15 16:41:15, ced wrote: ...
8 months ago (2018-02-15 16:53:22 UTC) #26
ced
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode1679 account.py:1679: 'invisible': Eval('context', {}).get('date', False), On 2018/02/15 16:53:22, pokoli wrote: ...
8 months ago (2018-02-15 17:15:04 UTC) #27
pokoli
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode1679 account.py:1679: 'invisible': Eval('context', {}).get('date', False), On 2018/02/15 17:15:04, ced wrote: ...
8 months ago (2018-02-20 16:52:50 UTC) #28
ced
https://codereview.tryton.org/43961002/diff/140006/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/140006/account.py#newcode330 account.py:330: } strange indent https://codereview.tryton.org/43961002/diff/140006/account.py#newcode344 account.py:344: 'to_date': Transaction().context.get('to_date'), Why not ...
7 months, 3 weeks ago (2018-02-25 22:26:11 UTC) #29
pokoli
Fix ced's comments
7 months, 1 week ago (2018-03-13 11:17:47 UTC) #30
reviewbot
patch is not applicable URL: https://codereview.tryton.org/43961002
7 months, 1 week ago (2018-03-13 11:50:45 UTC) #31
ced
https://codereview.tryton.org/43961002/diff/150001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/150001/account.py#newcode356 account.py:356: 'to_date': trans_context.get('to_date'), Will it not be more generic to ...
7 months, 1 week ago (2018-03-15 09:56:09 UTC) #32
pokoli
Use all the field of context model + active_id
7 months ago (2018-03-16 13:42:24 UTC) #33
reviewbot
https://codereview.tryton.org/43961002/diff/170001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/43961002/diff/170001/__init__.py#newcode6 __init__.py:6: ...
7 months ago (2018-03-16 13:47:13 UTC) #34
ced
https://codereview.tryton.org/43961002/diff/170001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/170001/account.py#newcode354 account.py:354: for fname in Model._fields.keys(): I think we should skip ...
7 months ago (2018-03-16 16:22:34 UTC) #35
ced
https://codereview.tryton.org/43961002/diff/170001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/170001/account.py#newcode350 account.py:350: Model = pool.get(trans_context['context_model']) I think we should also support ...
7 months ago (2018-03-16 16:23:26 UTC) #36
pokoli
Skip id and support context_model not being set
7 months ago (2018-03-19 08:51:07 UTC) #37
reviewbot
https://codereview.tryton.org/43961002/diff/190001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/43961002/diff/190001/__init__.py#newcode6 __init__.py:6: ...
7 months ago (2018-03-19 09:24:30 UTC) #38
ced
https://codereview.tryton.org/43961002/diff/190001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/190001/account.py#newcode344 account.py:344: def do_account(self, action): I would prefer to have a ...
7 months ago (2018-03-21 12:35:08 UTC) #39
pokoli
Use generic view name
7 months ago (2018-03-22 10:29:45 UTC) #40
ced
https://codereview.tryton.org/43961002/diff/210001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/210001/account.py#newcode351 account.py:351: 'active_id': trans_context.get('active_id'), Should not all the active_* key be ...
7 months ago (2018-03-22 10:46:30 UTC) #41
reviewbot
https://codereview.tryton.org/43961002/diff/210001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/43961002/diff/210001/__init__.py#newcode6 __init__.py:6: ...
7 months ago (2018-03-22 10:51:22 UTC) #42
pokoli
Copy all active_* keys
7 months ago (2018-03-22 15:08:09 UTC) #43
reviewbot
https://codereview.tryton.org/43961002/diff/230001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/43961002/diff/230001/__init__.py#newcode6 __init__.py:6: ...
7 months ago (2018-03-22 15:24:29 UTC) #44
ced
LGTM
7 months ago (2018-03-22 15:59:30 UTC) #45
rietveld-bot_tryton.org
6 months, 4 weeks ago (2018-03-23 12:23:08 UTC) #46
New changeset 27d92e32a265 by Sergi Almacellas Abellana in branch 'default':
Open general ledger accounts from Income Statement relate
http://hg.tryton.org/modules/account/rev/27d92e32a265
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 0147766