Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(163)

Issue 43961002: account: Open general ledger accounts from Income Statement relate

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 3 days ago by pokoli
Modified:
42 minutes ago
Reviewers:
udono, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove view file #

Patch Set 3 : ReAdd the open type wizard #

Total comments: 1

Patch Set 4 : Use context model to decide which action to trigger and add context model to account list #

Total comments: 3

Patch Set 5 : Include udono suggestions #

Total comments: 13

Patch Set 6 : Use unique function to build action values #

Patch Set 7 : Add changelog #

Patch Set 8 : Rename view ids and name #

Patch Set 9 : Use new context model for account balance sheet list #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -18 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M __init__.py View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -0 lines 0 comments Download
M account.py View 1 2 3 4 5 6 7 8 5 chunks +64 lines, -13 lines 4 comments Download
M account.xml View 1 2 3 4 5 6 7 8 4 chunks +36 lines, -6 lines 2 comments Download
A view/account_balance_sheet_context_form.xml View 1 2 3 4 5 6 7 8 1 chunk +11 lines, -0 lines 0 comments Download
A view/account_list_balance_sheet.xml View 1 2 3 4 5 6 7 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 29
pokoli
3 weeks, 3 days ago (2018-02-01 13:36:06 UTC) #1
pokoli
Remove view file
3 weeks, 3 days ago (2018-02-01 13:40:05 UTC) #2
reviewbot
https://codereview.tryton.org/43961002/diff/20001/account.py#newcode728 account.py:728: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
3 weeks, 3 days ago (2018-02-01 13:56:22 UTC) #3
pokoli
ReAdd the open type wizard
2 weeks, 6 days ago (2018-02-05 09:46:58 UTC) #4
reviewbot
https://codereview.tryton.org/43961002/diff/40001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/43961002/diff/40001/__init__.py#newcode6 __init__.py:6: ...
2 weeks, 6 days ago (2018-02-05 09:58:28 UTC) #5
ced
https://codereview.tryton.org/43961002/diff/40001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/40001/account.py#newcode319 account.py:319: parent = Type(Transaction().context['active_id']) Can not rely on the record ...
2 weeks, 5 days ago (2018-02-05 23:11:58 UTC) #6
pokoli
Use context model to decide which action to trigger and add context model to account ...
2 weeks, 5 days ago (2018-02-06 12:15:57 UTC) #7
reviewbot
https://codereview.tryton.org/43961002/diff/60001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/43961002/diff/60001/__init__.py#newcode6 __init__.py:6: ...
2 weeks, 5 days ago (2018-02-06 12:24:26 UTC) #8
udono
With my additions it works good for me. Thank you a lot! https://codereview.tryton.org/43961002/diff/60001/account.py File account.py ...
1 week, 5 days ago (2018-02-13 19:25:27 UTC) #9
pokoli
Include udono suggestions
1 week, 4 days ago (2018-02-14 08:53:46 UTC) #10
reviewbot
https://codereview.tryton.org/43961002/diff/80001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/43961002/diff/80001/__init__.py#newcode6 __init__.py:6: ...
1 week, 4 days ago (2018-02-14 08:55:37 UTC) #11
udono
LGTM
1 week, 4 days ago (2018-02-14 13:28:07 UTC) #12
ced
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode331 account.py:331: 'cumulate': Transaction().context.get('cumulate'), I think it is more flexible to ...
1 week, 4 days ago (2018-02-14 18:17:10 UTC) #13
ced
Missing changelog entry.
1 week, 4 days ago (2018-02-14 18:17:24 UTC) #14
udono
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode1679 account.py:1679: 'invisible': Eval('context', {}).get('date', False), On 2018/02/14 18:17:10, ced wrote: ...
1 week, 4 days ago (2018-02-14 20:11:31 UTC) #15
ced
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode1679 account.py:1679: 'invisible': Eval('context', {}).get('date', False), On 2018/02/14 20:11:31, udono wrote: ...
1 week, 4 days ago (2018-02-14 21:53:59 UTC) #16
pokoli
Use unique function to build action values
1 week, 3 days ago (2018-02-15 16:20:00 UTC) #17
pokoli
Add changelog
1 week, 3 days ago (2018-02-15 16:20:26 UTC) #18
reviewbot
https://codereview.tryton.org/43961002/diff/120001/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/43961002/diff/120001/__init__.py#newcode6 __init__.py:6: ...
1 week, 3 days ago (2018-02-15 16:24:03 UTC) #19
pokoli
Rename view ids and name
1 week, 3 days ago (2018-02-15 16:24:50 UTC) #20
pokoli
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode331 account.py:331: 'cumulate': Transaction().context.get('cumulate'), On 2018/02/14 18:17:10, ced wrote: > I ...
1 week, 3 days ago (2018-02-15 16:25:00 UTC) #21
ced
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode1679 account.py:1679: 'invisible': Eval('context', {}).get('date', False), On 2018/02/15 16:25:00, pokoli wrote: ...
1 week, 3 days ago (2018-02-15 16:39:46 UTC) #22
ced
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode1679 account.py:1679: 'invisible': Eval('context', {}).get('date', False), On 2018/02/15 16:39:46, ced wrote: ...
1 week, 3 days ago (2018-02-15 16:41:15 UTC) #23
pokoli
Use new context model for account balance sheet list
1 week, 3 days ago (2018-02-15 16:51:26 UTC) #24
reviewbot
https://codereview.tryton.org/43961002/diff/140006/__init__.py#newcode5 __init__.py:5: F403 'from fiscalyear import *' used; unable to detect undefined names https://codereview.tryton.org/43961002/diff/140006/__init__.py#newcode6 __init__.py:6: ...
1 week, 3 days ago (2018-02-15 16:52:32 UTC) #25
pokoli
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode1679 account.py:1679: 'invisible': Eval('context', {}).get('date', False), On 2018/02/15 16:41:15, ced wrote: ...
1 week, 3 days ago (2018-02-15 16:53:22 UTC) #26
ced
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode1679 account.py:1679: 'invisible': Eval('context', {}).get('date', False), On 2018/02/15 16:53:22, pokoli wrote: ...
1 week, 3 days ago (2018-02-15 17:15:04 UTC) #27
pokoli
https://codereview.tryton.org/43961002/diff/80001/account.py File account.py (right): https://codereview.tryton.org/43961002/diff/80001/account.py#newcode1679 account.py:1679: 'invisible': Eval('context', {}).get('date', False), On 2018/02/15 17:15:04, ced wrote: ...
5 days, 6 hours ago (2018-02-20 16:52:50 UTC) #28
ced
42 minutes ago (2018-02-25 22:26:11 UTC) #29
https://codereview.tryton.org/43961002/diff/140006/account.py
File account.py (right):

https://codereview.tryton.org/43961002/diff/140006/account.py#newcode330
account.py:330: }
strange indent

https://codereview.tryton.org/43961002/diff/140006/account.py#newcode344
account.py:344: 'to_date': Transaction().context.get('to_date'),
Why not store the transaction context in one variable?

https://codereview.tryton.org/43961002/diff/140006/account.py#newcode350
account.py:350: do_ledger_account = set_action_values
Do we really need to use the same method? half of it is in an if-statement.

https://codereview.tryton.org/43961002/diff/140006/account.py#newcode1689
account.py:1689: __name__ = 'account.account.balance_sheet.context'
I do not think it is right to have "Account" prefix.

What about having:

BalanceSheetContext
BalanceSheetComparisonContext

https://codereview.tryton.org/43961002/diff/140006/account.xml
File account.xml (right):

https://codereview.tryton.org/43961002/diff/140006/account.xml#newcode496
account.xml:496: <field name="domain"
I think our new style will require to have name on a new line.

https://codereview.tryton.org/43961002/diff/140006/account.xml#newcode636
account.xml:636: <field name="name">balance_sheet_context_form</field>
I think it should inherit with a different model name from the
account.account.balance_sheet.context
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922